From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D3CC43334 for ; Fri, 17 Jun 2022 15:12:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382988AbiFQPML (ORCPT ); Fri, 17 Jun 2022 11:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382971AbiFQPMJ (ORCPT ); Fri, 17 Jun 2022 11:12:09 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3F2C40E62 for ; Fri, 17 Jun 2022 08:12:08 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id 187so4408693pfu.9 for ; Fri, 17 Jun 2022 08:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3mgvhKmrqaYUspBn6nABZ88HosdbgWN7FHxrlSXkE+I=; b=hTERR44sQ02GCKZjqwMUtxMSduYjK9pDoqnBAlk1bS16iMGjnVJpFsEEhxXsb0t1Lk AIdchbUIXed1op+Irh496vAc86DXlcZSXYYZUiMP0bAGwp4OABZqoEssbrcAmYwrC+KN 2PXyVzDVabFo/w+KgK0V7Tm0go4bEd7Rres9V8lP2u0DIrrrM8q+EkUFG50Y0I9uz8WU KacIUUPIB1gZdjf2LexJPt8fmL3luaR9ATaG32+/B3NlZg24Q1VglatRlHZkldmJjvyk HTpkJ3sUqm9hzkGzzdm7Jghe0lzwpOhce2y1NHpKp7E4DQ9KhkuEvO4yu+9JNpcKR4fl avLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3mgvhKmrqaYUspBn6nABZ88HosdbgWN7FHxrlSXkE+I=; b=PIoL1/2pEjGvIXpJK6x8iRR530M4LSpWfv60qLeobBezaWpkKl+qSH1mMw4EiT2YFZ 9Qhbya9gBlMrQdItrn5BaslcB6kujbzAIFKKi7aSebJDHJEPEf96vr1uEK9jJvfwyzA8 ivDowsVawXjjedHfxqrvZd3wlWO6sXeqNGC6C+6fiB8GjwXyxk0RL4Dv0hmgi3I2+y0U xNoIBg5Im4HhpcuZT5Kk2bJg6SSwGIadUwx0xgPlYUctX2M0nAt5xEcgci8Q5W2HpmNn c9rY9cq2wfjAbzJ9K/Wyl8Cd5wroz+B0z4kKqSHR0WlJTD50278jFqLvqu6P5LpBPUqd jIzw== X-Gm-Message-State: AJIora/o+XWvq9KSEUUCSyJ6aw6xVzUOq/BfVlu4pDgsPwr2EcdRHhix /VmCTYGKGfCn2WS6nZSbZQApXw== X-Google-Smtp-Source: AGRyM1vfbbnxwQFV1uQ+YDKGOWDgTFUZzxCaEFFsVM4p7M9tq5Wv+ppIzZKQQB6z6heUAcwABxAbwg== X-Received: by 2002:a65:404c:0:b0:3c6:4018:ffbf with SMTP id h12-20020a65404c000000b003c64018ffbfmr9685028pgp.408.1655478728062; Fri, 17 Jun 2022 08:12:08 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id k17-20020a628e11000000b0050dc76281a2sm3808947pfe.124.2022.06.17.08.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 08:12:07 -0700 (PDT) Date: Fri, 17 Jun 2022 15:12:04 +0000 From: Sean Christopherson To: David Matlack Cc: Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Jones , Ben Gardon , Peter Xu , maciej.szmigiero@oracle.com, "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" , "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" , "open list:KERNEL VIRTUAL MACHINE FOR RISC-V (KVM/riscv)" , Peter Feiner , Lai Jiangshan Subject: Re: [PATCH v6 04/22] KVM: x86/mmu: Derive shadow MMU page role from parent Message-ID: References: <20220516232138.1783324-1-dmatlack@google.com> <20220516232138.1783324-5-dmatlack@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220516232138.1783324-5-dmatlack@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, May 16, 2022, David Matlack wrote: > +static struct kvm_mmu_page *kvm_mmu_get_child_sp(struct kvm_vcpu *vcpu, > + u64 *sptep, gfn_t gfn, > + bool direct, u32 access) Please use "unsigned int" for @access, here and everywhere else, so that KVM is consistent in how it refers to access. @access can actually squeeze into a u8, but it's referenced as a "unsigned int" because sp->role.access is an unsigned int. For me at least, when I see "ukvm, vcpu, &caches, gfn, role); } -static union kvm_mmu_page_role kvm_mmu_child_role(u64 *sptep, bool direct, u32 access) +static union kvm_mmu_page_role kvm_mmu_child_role(u64 *sptep, bool direct, + unsigned int access) { struct kvm_mmu_page *parent_sp = sptep_to_sp(sptep); union kvm_mmu_page_role role; @@ -2242,7 +2243,7 @@ static union kvm_mmu_page_role kvm_mmu_child_role(u64 *sptep, bool direct, u32 a static struct kvm_mmu_page *kvm_mmu_get_child_sp(struct kvm_vcpu *vcpu, u64 *sptep, gfn_t gfn, - bool direct, u32 access) + bool direct, unsigned int access) { union kvm_mmu_page_role role; > +{ > + union kvm_mmu_page_role role; > + > + role = kvm_mmu_child_role(sptep, direct, access); > + return kvm_mmu_get_page(vcpu, gfn, role); > +} > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A733C433EF for ; Fri, 17 Jun 2022 15:12:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0317A49E1E; Fri, 17 Jun 2022 11:12:14 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x82Znf4ZFYT3; Fri, 17 Jun 2022 11:12:11 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B80104B178; Fri, 17 Jun 2022 11:12:11 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 575D549E1E for ; Fri, 17 Jun 2022 11:12:10 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pLu6JXroTeyD for ; Fri, 17 Jun 2022 11:12:09 -0400 (EDT) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4952D411C7 for ; Fri, 17 Jun 2022 11:12:09 -0400 (EDT) Received: by mail-pg1-f169.google.com with SMTP id d129so4287319pgc.9 for ; Fri, 17 Jun 2022 08:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3mgvhKmrqaYUspBn6nABZ88HosdbgWN7FHxrlSXkE+I=; b=hTERR44sQ02GCKZjqwMUtxMSduYjK9pDoqnBAlk1bS16iMGjnVJpFsEEhxXsb0t1Lk AIdchbUIXed1op+Irh496vAc86DXlcZSXYYZUiMP0bAGwp4OABZqoEssbrcAmYwrC+KN 2PXyVzDVabFo/w+KgK0V7Tm0go4bEd7Rres9V8lP2u0DIrrrM8q+EkUFG50Y0I9uz8WU KacIUUPIB1gZdjf2LexJPt8fmL3luaR9ATaG32+/B3NlZg24Q1VglatRlHZkldmJjvyk HTpkJ3sUqm9hzkGzzdm7Jghe0lzwpOhce2y1NHpKp7E4DQ9KhkuEvO4yu+9JNpcKR4fl avLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3mgvhKmrqaYUspBn6nABZ88HosdbgWN7FHxrlSXkE+I=; b=5NaBSILNX5Z2ncnqhGgE/7tXWlaYLIBq2sP91a55x4lysPv6NE+XyCvL2LZDMocxxZ 4yXCIdRx+uDaR+XQt0E3RBjujmsRZjywGSIaKfjzxFtFdpEbeumssvC38pxLbeek7FNq kt4HYD4PppPdffhHYXR17TSLTe/+epI16jqpSvbfiUotPSmmgcSQCq32YxqGdCnKLE4r trYtBzCJT4NLQwzQJ6dpNxj5g5x/5tsQeDKczaeW6d/v8VDL8U3HG4dCUNBCoqeK35B8 1wbkg5CCszR3GH/r979GF81qCnHqqixPMvLNFpujKtITopoR79V+5xhXwPodo4fEMthj Poeg== X-Gm-Message-State: AJIora9IXA8UqqGcLxt0j/yN9ksMzulLEjmXqHP/Bb4cMJ1FIm2QaR3c 2tzwTqFfvKEjW7g5lmnD2lRCnQ== X-Google-Smtp-Source: AGRyM1vfbbnxwQFV1uQ+YDKGOWDgTFUZzxCaEFFsVM4p7M9tq5Wv+ppIzZKQQB6z6heUAcwABxAbwg== X-Received: by 2002:a65:404c:0:b0:3c6:4018:ffbf with SMTP id h12-20020a65404c000000b003c64018ffbfmr9685028pgp.408.1655478728062; Fri, 17 Jun 2022 08:12:08 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id k17-20020a628e11000000b0050dc76281a2sm3808947pfe.124.2022.06.17.08.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 08:12:07 -0700 (PDT) Date: Fri, 17 Jun 2022 15:12:04 +0000 From: Sean Christopherson To: David Matlack Subject: Re: [PATCH v6 04/22] KVM: x86/mmu: Derive shadow MMU page role from parent Message-ID: References: <20220516232138.1783324-1-dmatlack@google.com> <20220516232138.1783324-5-dmatlack@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220516232138.1783324-5-dmatlack@google.com> Cc: Marc Zyngier , Albert Ou , "open list:KERNEL VIRTUAL MACHINE FOR MIPS \(KVM/mips\)" , Huacai Chen , Lai Jiangshan , "open list:KERNEL VIRTUAL MACHINE FOR MIPS \(KVM/mips\)" , Aleksandar Markovic , Palmer Dabbelt , "open list:KERNEL VIRTUAL MACHINE FOR RISC-V \(KVM/riscv\)" , Paul Walmsley , Ben Gardon , Paolo Bonzini , maciej.szmigiero@oracle.com, "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" , Peter Feiner X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, May 16, 2022, David Matlack wrote: > +static struct kvm_mmu_page *kvm_mmu_get_child_sp(struct kvm_vcpu *vcpu, > + u64 *sptep, gfn_t gfn, > + bool direct, u32 access) Please use "unsigned int" for @access, here and everywhere else, so that KVM is consistent in how it refers to access. @access can actually squeeze into a u8, but it's referenced as a "unsigned int" because sp->role.access is an unsigned int. For me at least, when I see "ukvm, vcpu, &caches, gfn, role); } -static union kvm_mmu_page_role kvm_mmu_child_role(u64 *sptep, bool direct, u32 access) +static union kvm_mmu_page_role kvm_mmu_child_role(u64 *sptep, bool direct, + unsigned int access) { struct kvm_mmu_page *parent_sp = sptep_to_sp(sptep); union kvm_mmu_page_role role; @@ -2242,7 +2243,7 @@ static union kvm_mmu_page_role kvm_mmu_child_role(u64 *sptep, bool direct, u32 a static struct kvm_mmu_page *kvm_mmu_get_child_sp(struct kvm_vcpu *vcpu, u64 *sptep, gfn_t gfn, - bool direct, u32 access) + bool direct, unsigned int access) { union kvm_mmu_page_role role; > +{ > + union kvm_mmu_page_role role; > + > + role = kvm_mmu_child_role(sptep, direct, access); > + return kvm_mmu_get_page(vcpu, gfn, role); > +} > + _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm