From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A09C43334 for ; Fri, 17 Jun 2022 15:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383040AbiFQP47 (ORCPT ); Fri, 17 Jun 2022 11:56:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234143AbiFQP46 (ORCPT ); Fri, 17 Jun 2022 11:56:58 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B9902F006 for ; Fri, 17 Jun 2022 08:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1og0G+jMuH4LpomwNdV+Rmme0bj4/1cUhjZZACY/B+U=; b=AbcDdyS+eoHqmJnCQ3xm3r+OXR X+3ZJGQAychhV9rmwM3BecocG/MfYvwywj5HDCnl+o206Q/QgNMA4X2wC5VsvcMzYXrklfpHsCInD JhUsbODDUBUORf46pLdCMDOsjoSa8jqL4+AAF4bJUzIadZTkd5IGWOlnYIO+ywZWshfw8x60BDYQ5 x3Yp18tEzVUsMHoOZD0rCSEt0N647eGXxZFB2yXuLFsM/ViNtvrDCRWfwu9n0dTtFyYiwZmMeeGWJ +Xc5/m1HWAmtfDNwxfB9JEaCF3/sSrGAtYxG9CGxQMrAUffyMVcP1vpTsp4mfMHlGjctt/mqNKVjz dL/mPlxQ==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2EL0-008jGE-4Q; Fri, 17 Jun 2022 15:56:46 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 014CF9816B5; Fri, 17 Jun 2022 17:56:43 +0200 (CEST) Date: Fri, 17 Jun 2022 17:56:43 +0200 From: Peter Zijlstra To: Eric Dumazet Cc: Waiman Long , Shakeel Butt , Eric Dumazet , Linus Torvalds , linux-kernel , Ingo Molnar , Boqun Feng , Will Deacon , Roman Penyaev Subject: Re: [PATCH] locking/rwlocks: do not starve writers Message-ID: References: <20220617091039.2257083-1-eric.dumazet@gmail.com> <2dd754f9-3a79-ed17-e423-6b411c3afb69@redhat.com> <2730b855-8f99-5a9e-707e-697d3bd9811d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2022 at 05:24:58PM +0200, Eric Dumazet wrote: > If only tasklist_lock is problematic and needs the unfair variant, > then changing a few read_lock() for tasklist_lock will be less > invasive than ~1000 read_lock() elsewhere.... This is unknown. tasklist_lock was the obvious one, there might be more. Lockdep should be able to tell you.