From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA053C43334 for ; Thu, 30 Jun 2022 03:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230138AbiF3Dy5 (ORCPT ); Wed, 29 Jun 2022 23:54:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbiF3Dy4 (ORCPT ); Wed, 29 Jun 2022 23:54:56 -0400 Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7095C19C0D for ; Wed, 29 Jun 2022 20:54:55 -0700 (PDT) Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-f2a4c51c45so24161263fac.9 for ; Wed, 29 Jun 2022 20:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5OWFEvvnhWbk5JUNHWESexfCKhPu41TnYPW0LjUtHpU=; b=pSsWDCAXql821vGLsIMyJgV0Pos3oBe0HeeKnRxTpl73Klu0EhWoM7Bxw6TV9XuMWk +8B7GcNu7hFRCdWVpcEZiJ94XFXRWchn7gt0794aJtPtxgVedoebvlKTu2byHKqHkBAD lH1KUTGy/UAe0clm2oCRmYiZ2BbZXC36X6piwT9n4YHLW/XeutzYAwYyMPFxS1CkHBil fYt0jqXjKYmo0HoWfoCqbZmgCw6KElamOJ+JCJ/qjw6akyrASip4f/yUpQPYg6gB3P4p 3CAdiZfX8fcknSy7GVasRGsudhVFa7r3lxWQ8E76/8Ej997x660FAjSUBMqCeovZT4pR uvMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5OWFEvvnhWbk5JUNHWESexfCKhPu41TnYPW0LjUtHpU=; b=S2UpfGao2rLzt4mMvlFPNG/Jj7RKVtc7L6QBwrelvWJ6KeCz3VSL3J7vaaGGaE6ofx kzoKXd+aoGld/e8sdWVLgdP6L5WPTAFoJCMEIUNeds8maPNN1WKVE6a+lCfHBT3byVJf I7cyV0c7uFGX2UIUCa0mNfeaYlp1Ls0fT2MBtfwvu4BdnKdLrpp9YgDHn0b5O2mt3mbd RkyLL3pL50aXcXnQG7o/3Kvpa+mS/g2L9e8D7v8X+ev+dIqjv/u3askixEroUwEtAMRy QKleq1ytjEJY7QdrNZ+Z7g03bcZQlBhopXGUu4t1TCarkGCp7SR1za2Y2+UsyvO5q4Bh XSBA== X-Gm-Message-State: AJIora9fJ10J3xrHt00l3Z8WcTuQbwu32xOyPYqy1kiA2fsp6CUTIksP iOgpPYicJH6+qGK6tQlbVfLnSdDQ9hCQRg== X-Google-Smtp-Source: AGRyM1uy7iCrWBTCWRBIvFIB7IlrUkZ+YNjXeLqJ/7yEta29DPxlz4F1dZj3TgnN/TGG2nqk7YCDGw== X-Received: by 2002:a05:6870:6314:b0:10b:9595:62db with SMTP id s20-20020a056870631400b0010b959562dbmr2456208oao.128.1656561294787; Wed, 29 Jun 2022 20:54:54 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a2-20020a05680804c200b0032e3cca8561sm9662636oie.21.2022.06.29.20.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 20:54:54 -0700 (PDT) Date: Wed, 29 Jun 2022 22:54:52 -0500 From: Bjorn Andersson To: Pavel Machek Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] arm64: dts: qcom: sdm845: Enable user LEDs on DB845c Message-ID: References: <20220505022706.1692554-1-bjorn.andersson@linaro.org> <20220505022706.1692554-3-bjorn.andersson@linaro.org> <20220530070608.GB1363@bug> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220530070608.GB1363@bug> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 30 May 02:06 CDT 2022, Pavel Machek wrote: > Hi! > > > The DB845c has 4 "user LEDs", the last one is already supported as it's > > just wired to a gpio. Now that the LPG binding is in place we can wire > > up the other 3 LEDs as well. > > > > +&pmi8998_lpg { > > + status = "okay"; > > + > > + qcom,power-source = <1>; > > + > > + led@3 { > > + reg = <3>; > > + color = ; > > + function = LED_FUNCTION_HEARTBEAT; > > + function-enumerator = <3>; > > + > > + linux,default-trigger = "heartbeat"; > > + default-state = "on"; > > + }; > > + > > + led@4 { > > + reg = <4>; > > + color = ; > > + function = LED_FUNCTION_INDICATOR; > > + function-enumerator = <2>; > > + }; > > + > > + led@5 { > > + reg = <5>; > > + color = ; > > + function = LED_FUNCTION_INDICATOR; > > + function-enumerator = <1>; > > + }; > > Do the LEDs have some kind of markings? Marking them as "indicator" is not too useful. > Unfortunately no, there is just 4 green LEDs tightly packed together (3 driven by the lpg, 1 by a gpio), with no indications of which is which. Regards, Bjorn