From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2255FC43334 for ; Thu, 30 Jun 2022 07:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbiF3Hys (ORCPT ); Thu, 30 Jun 2022 03:54:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231920AbiF3Hyr (ORCPT ); Thu, 30 Jun 2022 03:54:47 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 155633ED26 for ; Thu, 30 Jun 2022 00:54:46 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id h14-20020a1ccc0e000000b0039eff745c53so1096940wmb.5 for ; Thu, 30 Jun 2022 00:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CCykJYUXKv51rZ8nTMW18vjqVnPZBcTRE0urrPA7hH4=; b=Z3YQlrsYDNeBCjZRgzx9MKmS0d+MIjGEWt+UBH1uzDnDvllumP4ONc+5d2XS9hu4a8 1g1WWWcMRnXTjpSnpEU1dhS2gvsOkfAdcz1G2mkSUzUY3fTbAswgt83sm3cwfEMiZ57t vvcWk2wc6G0iaW1tjYMUtuc3EZHs7WPXa6u6tm6VJYOvqEQNCmXggkcUwSM1Btwmda2o cEX4TkVzHSkGtmy/4k9x6PjofkRoSeD/rUbY9J6WrAT7y66c+5GvbIzUmj9TRbyXaB1/ 43H07TvNeTX2IUgvbjxa9Rysv4aDDL60oNgfpjHap+0g2DNozvyq748EZRLwPx4HaUyX gahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CCykJYUXKv51rZ8nTMW18vjqVnPZBcTRE0urrPA7hH4=; b=dsmrWVP6mMNmJh2+5AaPDn63vO3UjEBIyYhc/yBEZh9DlDYOKWb7DPdW9T9jxY/G1c QAvphbySGK6azZBOVrBd6S0YsuFxGkw8SUveU63WP1GsyUnHxjCt++HFy1Ii0qBLRKRO PDJKVXpuBKhY02UcmzPYXofwGJlnTWcbQTXQgWxyDV0477V66ga+CqV29LHhjArw2OM+ 2GvmcOKYxx9Xd2M5Dy+WPVQebeqV31LYQwkXc50DDS6BCSBQI07+p1H0Rmtw79RTcCdC x0lUBZqkcsUjPM+Q/gfRBjl1aHlGt/tSRAXBnUkXIwBejG6+RS/dMvttTfxe6w5HFyOk YbrA== X-Gm-Message-State: AJIora8QVIBsKOfYLF+jH1lrafr2AoP/ATGPh/k14rWJJghyWeYOjhzp 56ICxYrldGy/wd10g7c5gQhIKA== X-Google-Smtp-Source: AGRyM1tBnnpxwzXTNYYIrONKbhI1E0t5nzd18tCkH1azo2MF2q31f4j7BJc+CfboYCD9eU+M66/zYQ== X-Received: by 2002:a7b:cd85:0:b0:3a0:4c45:16c1 with SMTP id y5-20020a7bcd85000000b003a04c4516c1mr10046046wmj.125.1656575684605; Thu, 30 Jun 2022 00:54:44 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b0039c54bb28f2sm6092291wmq.36.2022.06.30.00.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:54:44 -0700 (PDT) Date: Thu, 30 Jun 2022 08:54:41 +0100 From: Lee Jones To: Colin Foster Cc: Vladimir Oltean , Andy Shevchenko , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , "UNGLinuxDriver@microchip.com" , Linus Walleij , Wolfram Sang , Terry Bowman , Alexandre Belloni , Arnd Bergmann Subject: Re: [PATCH v11 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource Message-ID: References: <20220628160809.marto7t6k24lneau@skbuf> <20220628172518.GA855398@euler> <20220628184659.sel4kfvrm2z6rwx6@skbuf> <20220628185638.dpm2w2rfc3xls7xd@skbuf> <20220628195654.GE855398@euler> <20220629175305.4pugpbmf5ezeemx3@skbuf> <20220629203905.GA932353@euler> <20220629230805.klgcklovkkunn5cm@skbuf> <20220629235435.GA992734@euler> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220629235435.GA992734@euler> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 29 Jun 2022, Colin Foster wrote: > On Wed, Jun 29, 2022 at 11:08:05PM +0000, Vladimir Oltean wrote: > > On Wed, Jun 29, 2022 at 01:39:05PM -0700, Colin Foster wrote: > > > I liked the idea of the MFD being "code complete" so if future regmaps > > > were needed for the felix dsa driver came about, it wouldn't require > > > changes to the "parent." But I think that was a bad goal - especially > > > since MFD requires all the resources anyway. > > > > > > Also at the time, I was trying a hybrid "create it if it doesn't exist, > > > return it if was already created" approach. I backed that out after an > > > RFC. > > > > > > Focusing only on the non-felix drivers: it seems trivial for the parent > > > to create _all_ the possible child regmaps, register them to the parent > > > via by way of regmap_attach_dev(). > > > > > > At that point, changing things like drivers/pinctrl/pinctrl-ocelot.c to > > > initalize like (untested, and apologies for indentation): > > > > > > regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > > > if (IS_ERR(regs)) { > > > map = dev_get_regmap(dev->parent, name); > > > } else { > > > map = devm_regmap_init_mmio(dev, regs, config); > > > } > > > > Again, those dev_err(dev, "invalid resource\n"); prints you were > > complaining about earlier are self-inflicted IMO, and caused exactly by > > this pattern. I get why you prefer to call larger building blocks if > > possible, but in this case, devm_platform_get_and_ioremap_resource() > > calls exactly 2 sub-functions: platform_get_resource() and > > devm_ioremap_resource(). The IS_ERR() that you check for is caused by > > devm_ioremap_resource() being passed a NULL pointer, and same goes for > > the print. Just call them individually, and put your dev_get_regmap() > > hook in case platform_get_resource() returns NULL, rather than passing > > NULL to devm_ioremap_resource() and waiting for that to fail. > > I see that now. Hoping this next version removes a lot of this > unnecessary complexity. > > > > > > In that case, "name" would either be hard-coded to match what is in > > > drivers/mfd/ocelot-core.c. The other option is to fall back to > > > platform_get_resource(pdev, IORESOURCE_REG, 0), and pass in > > > resource->name. I'll be able to deal with that when I try it. (hopefully > > > this evening) > > > > I'm not exactly clear on what you'd do with the REG resource once you > > get it. Assuming you'd get access to the "reg = <0x71070034 0x6c>;" > > from the device tree, what next, who's going to set up the SPI regmap > > for you? > > The REG resource would only get the resource name, while the MFD core > driver would set up the regmaps. > > e.g. drivers/mfd/ocelot-core.c has (annotated): > static const struct resource vsc7512_sgpio_resources[] = { > DEFINE_RES_REG_NAMED(start, size, "gcb_gpio") }; > > Now, the drivers/pinctrl/pinctrl-ocelot.c expects resource 0 to be the > gpio resource, and gets the resource by index. > > So for this there seem to be two options: > Option 1: > drivers/pinctrl/pinctrl-ocelot.c: > res = platform_get_resource(pdev, IORESOURCE_REG, 0); > map = dev_get_regmap(dev->parent, res->name); > > > OR Option 2: > include/linux/mfd/ocelot.h has something like: > #define GCB_GPIO_REGMAP_NAME "gcb_gpio" > > and drivers/pinctrl/pinctrl-ocelot.c skips get_resource and jumps to: > map = dev_get_regmap(dev->parent, GCB_GPIO_REGMAP_NAME); > > (With error checking, macro reuse, etc.) > > > I like option 1, since it then makes ocelot-pinctrl.c have no reliance > on include/linux/mfd/ocelot.h. But in both cases, all the regmaps are > set up in advance during the start of ocelot_core_init, just before > devm_mfd_add_devices is called. > > > I should be able to test this all tonight. Thank you Vladimir for stepping in to clarify previous points. Well done both of you for this collaborative effort. Great to see! -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B419DCCA481 for ; Thu, 30 Jun 2022 07:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gUejRHIxNqcr2Iyo5v+hfhPee6wzbWvGhSyeLi263Qc=; b=30e5zyznr5XTC5 Sgs6SLnyutsZWSaPXZAHDBWuCeMz17SrPRfbMle4HOpiCCcLqZtq+Q/m5+RLSjt3s06nkbG388JMK e32vi7CxmXpwTioEDk22tLp8h/SF/MpxBGJoPMWFD9GrGB9cuvrnOyw819KlHQn+PVUwJECX24VTF 29mlR1dnBNqwdGfdflqMXUK0Mnpd20Izx9Om11zHjVzdt6B00ObmOIx6kbKuOxtXlNi3KRdnYX0yP LE+GA7wWYMzYwPmWwro4ECUMpBVgapGwTUuf+CTigcxsXhINC2v4UCPy4HNoc2Q8TibT0eYvAqrmy ZbzSmGI9RUMFFtxJZcFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6p0h-00Fr5l-Oo; Thu, 30 Jun 2022 07:54:47 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6p0f-00Fqxq-5Q for linux-arm-kernel@lists.infradead.org; Thu, 30 Jun 2022 07:54:46 +0000 Received: by mail-wm1-x329.google.com with SMTP id o16-20020a05600c379000b003a02eaea815so2183400wmr.0 for ; Thu, 30 Jun 2022 00:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CCykJYUXKv51rZ8nTMW18vjqVnPZBcTRE0urrPA7hH4=; b=Z3YQlrsYDNeBCjZRgzx9MKmS0d+MIjGEWt+UBH1uzDnDvllumP4ONc+5d2XS9hu4a8 1g1WWWcMRnXTjpSnpEU1dhS2gvsOkfAdcz1G2mkSUzUY3fTbAswgt83sm3cwfEMiZ57t vvcWk2wc6G0iaW1tjYMUtuc3EZHs7WPXa6u6tm6VJYOvqEQNCmXggkcUwSM1Btwmda2o cEX4TkVzHSkGtmy/4k9x6PjofkRoSeD/rUbY9J6WrAT7y66c+5GvbIzUmj9TRbyXaB1/ 43H07TvNeTX2IUgvbjxa9Rysv4aDDL60oNgfpjHap+0g2DNozvyq748EZRLwPx4HaUyX gahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CCykJYUXKv51rZ8nTMW18vjqVnPZBcTRE0urrPA7hH4=; b=Je6CniOD13pdMU2HQOY87LHX4rx7uaY35fmd8AZxLXmG3MXwZU967qbTx19u0KEVQj kgo+InqGYwuaP0zE77rq0QnBhLqH75uFCaSYHVNM1tmcYNQdIoe2ZLv6PVHSELGJos1u zT9Ksd3OzD/hq5n1jEW83EUeolR+pkmjqf1DZLi/joPBQForlop9db9KYUr3IBuDT/+6 kqX23IKIsQTDdExvraAyCi8skNqtttoM0+adXkZ0Ek507020fpJRFraYOTfH/Di1ZZSR M2Y4q4WsWstz3K5K1C6Sm6EkDcLTJ7QnIMfsqMHSBdxgBIJPqOgixCtXFRdix9Io0XN9 e3TA== X-Gm-Message-State: AJIora8DB0QwfuIw5s+9DNP03LBrhwYyX8fv4C5YR6oHv/jwB/aUQROm gKRfipfdoT/DDk3H4ReSF0Tykw== X-Google-Smtp-Source: AGRyM1tBnnpxwzXTNYYIrONKbhI1E0t5nzd18tCkH1azo2MF2q31f4j7BJc+CfboYCD9eU+M66/zYQ== X-Received: by 2002:a7b:cd85:0:b0:3a0:4c45:16c1 with SMTP id y5-20020a7bcd85000000b003a04c4516c1mr10046046wmj.125.1656575684605; Thu, 30 Jun 2022 00:54:44 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b0039c54bb28f2sm6092291wmq.36.2022.06.30.00.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:54:44 -0700 (PDT) Date: Thu, 30 Jun 2022 08:54:41 +0100 From: Lee Jones To: Colin Foster Cc: Vladimir Oltean , Andy Shevchenko , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , "UNGLinuxDriver@microchip.com" , Linus Walleij , Wolfram Sang , Terry Bowman , Alexandre Belloni , Arnd Bergmann Subject: Re: [PATCH v11 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource Message-ID: References: <20220628160809.marto7t6k24lneau@skbuf> <20220628172518.GA855398@euler> <20220628184659.sel4kfvrm2z6rwx6@skbuf> <20220628185638.dpm2w2rfc3xls7xd@skbuf> <20220628195654.GE855398@euler> <20220629175305.4pugpbmf5ezeemx3@skbuf> <20220629203905.GA932353@euler> <20220629230805.klgcklovkkunn5cm@skbuf> <20220629235435.GA992734@euler> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220629235435.GA992734@euler> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220630_005445_300660_CABDBFF0 X-CRM114-Status: GOOD ( 43.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBKdW4gMjAyMiwgQ29saW4gRm9zdGVyIHdyb3RlOgoKPiBPbiBXZWQsIEp1biAy OSwgMjAyMiBhdCAxMTowODowNVBNICswMDAwLCBWbGFkaW1pciBPbHRlYW4gd3JvdGU6Cj4gPiBP biBXZWQsIEp1biAyOSwgMjAyMiBhdCAwMTozOTowNVBNIC0wNzAwLCBDb2xpbiBGb3N0ZXIgd3Jv dGU6Cj4gPiA+IEkgbGlrZWQgdGhlIGlkZWEgb2YgdGhlIE1GRCBiZWluZyAiY29kZSBjb21wbGV0 ZSIgc28gaWYgZnV0dXJlIHJlZ21hcHMKPiA+ID4gd2VyZSBuZWVkZWQgZm9yIHRoZSBmZWxpeCBk c2EgZHJpdmVyIGNhbWUgYWJvdXQsIGl0IHdvdWxkbid0IHJlcXVpcmUKPiA+ID4gY2hhbmdlcyB0 byB0aGUgInBhcmVudC4iIEJ1dCBJIHRoaW5rIHRoYXQgd2FzIGEgYmFkIGdvYWwgLSBlc3BlY2lh bGx5Cj4gPiA+IHNpbmNlIE1GRCByZXF1aXJlcyBhbGwgdGhlIHJlc291cmNlcyBhbnl3YXkuCj4g PiA+IAo+ID4gPiBBbHNvIGF0IHRoZSB0aW1lLCBJIHdhcyB0cnlpbmcgYSBoeWJyaWQgImNyZWF0 ZSBpdCBpZiBpdCBkb2Vzbid0IGV4aXN0LAo+ID4gPiByZXR1cm4gaXQgaWYgd2FzIGFscmVhZHkg Y3JlYXRlZCIgYXBwcm9hY2guIEkgYmFja2VkIHRoYXQgb3V0IGFmdGVyIGFuCj4gPiA+IFJGQy4K PiA+ID4gCj4gPiA+IEZvY3VzaW5nIG9ubHkgb24gdGhlIG5vbi1mZWxpeCBkcml2ZXJzOiBpdCBz ZWVtcyB0cml2aWFsIGZvciB0aGUgcGFyZW50Cj4gPiA+IHRvIGNyZWF0ZSBfYWxsXyB0aGUgcG9z c2libGUgY2hpbGQgcmVnbWFwcywgcmVnaXN0ZXIgdGhlbSB0byB0aGUgcGFyZW50Cj4gPiA+IHZp YSBieSB3YXkgb2YgcmVnbWFwX2F0dGFjaF9kZXYoKS4KPiA+ID4gCj4gPiA+IEF0IHRoYXQgcG9p bnQsIGNoYW5naW5nIHRoaW5ncyBsaWtlIGRyaXZlcnMvcGluY3RybC9waW5jdHJsLW9jZWxvdC5j IHRvCj4gPiA+IGluaXRhbGl6ZSBsaWtlICh1bnRlc3RlZCwgYW5kIGFwb2xvZ2llcyBmb3IgaW5k ZW50YXRpb24pOgo+ID4gPiAKPiA+ID4gcmVncyA9IGRldm1fcGxhdGZvcm1fZ2V0X2FuZF9pb3Jl bWFwX3Jlc291cmNlKHBkZXYsIDAsICZyZXMpOwo+ID4gPiBpZiAoSVNfRVJSKHJlZ3MpKSB7Cj4g PiA+ICAgICBtYXAgPSBkZXZfZ2V0X3JlZ21hcChkZXYtPnBhcmVudCwgbmFtZSk7Cj4gPiA+IH0g ZWxzZSB7Cj4gPiA+ICAgICBtYXAgPSBkZXZtX3JlZ21hcF9pbml0X21taW8oZGV2LCByZWdzLCBj b25maWcpOwo+ID4gPiB9Cj4gPiAKPiA+IEFnYWluLCB0aG9zZSBkZXZfZXJyKGRldiwgImludmFs aWQgcmVzb3VyY2VcbiIpOyBwcmludHMgeW91IHdlcmUKPiA+IGNvbXBsYWluaW5nIGFib3V0IGVh cmxpZXIgYXJlIHNlbGYtaW5mbGljdGVkIElNTywgYW5kIGNhdXNlZCBleGFjdGx5IGJ5Cj4gPiB0 aGlzIHBhdHRlcm4uIEkgZ2V0IHdoeSB5b3UgcHJlZmVyIHRvIGNhbGwgbGFyZ2VyIGJ1aWxkaW5n IGJsb2NrcyBpZgo+ID4gcG9zc2libGUsIGJ1dCBpbiB0aGlzIGNhc2UsIGRldm1fcGxhdGZvcm1f Z2V0X2FuZF9pb3JlbWFwX3Jlc291cmNlKCkKPiA+IGNhbGxzIGV4YWN0bHkgMiBzdWItZnVuY3Rp b25zOiBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UoKSBhbmQKPiA+IGRldm1faW9yZW1hcF9yZXNvdXJj ZSgpLiBUaGUgSVNfRVJSKCkgdGhhdCB5b3UgY2hlY2sgZm9yIGlzIGNhdXNlZCBieQo+ID4gZGV2 bV9pb3JlbWFwX3Jlc291cmNlKCkgYmVpbmcgcGFzc2VkIGEgTlVMTCBwb2ludGVyLCBhbmQgc2Ft ZSBnb2VzIGZvcgo+ID4gdGhlIHByaW50LiBKdXN0IGNhbGwgdGhlbSBpbmRpdmlkdWFsbHksIGFu ZCBwdXQgeW91ciBkZXZfZ2V0X3JlZ21hcCgpCj4gPiBob29rIGluIGNhc2UgcGxhdGZvcm1fZ2V0 X3Jlc291cmNlKCkgcmV0dXJucyBOVUxMLCByYXRoZXIgdGhhbiBwYXNzaW5nCj4gPiBOVUxMIHRv IGRldm1faW9yZW1hcF9yZXNvdXJjZSgpIGFuZCB3YWl0aW5nIGZvciB0aGF0IHRvIGZhaWwuCj4g Cj4gSSBzZWUgdGhhdCBub3cuIEhvcGluZyB0aGlzIG5leHQgdmVyc2lvbiByZW1vdmVzIGEgbG90 IG9mIHRoaXMKPiB1bm5lY2Vzc2FyeSBjb21wbGV4aXR5Lgo+IAo+ID4gCj4gPiA+IEluIHRoYXQg Y2FzZSwgIm5hbWUiIHdvdWxkIGVpdGhlciBiZSBoYXJkLWNvZGVkIHRvIG1hdGNoIHdoYXQgaXMg aW4KPiA+ID4gZHJpdmVycy9tZmQvb2NlbG90LWNvcmUuYy4gVGhlIG90aGVyIG9wdGlvbiBpcyB0 byBmYWxsIGJhY2sgdG8KPiA+ID4gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VS Q0VfUkVHLCAwKSwgYW5kIHBhc3MgaW4KPiA+ID4gcmVzb3VyY2UtPm5hbWUuIEknbGwgYmUgYWJs ZSB0byBkZWFsIHdpdGggdGhhdCB3aGVuIEkgdHJ5IGl0LiAoaG9wZWZ1bGx5Cj4gPiA+IHRoaXMg ZXZlbmluZykKPiA+IAo+ID4gSSdtIG5vdCBleGFjdGx5IGNsZWFyIG9uIHdoYXQgeW91J2QgZG8g d2l0aCB0aGUgUkVHIHJlc291cmNlIG9uY2UgeW91Cj4gPiBnZXQgaXQuIEFzc3VtaW5nIHlvdSdk IGdldCBhY2Nlc3MgdG8gdGhlICJyZWcgPSA8MHg3MTA3MDAzNCAweDZjPjsiCj4gPiBmcm9tIHRo ZSBkZXZpY2UgdHJlZSwgd2hhdCBuZXh0LCB3aG8ncyBnb2luZyB0byBzZXQgdXAgdGhlIFNQSSBy ZWdtYXAKPiA+IGZvciB5b3U/Cj4gCj4gVGhlIFJFRyByZXNvdXJjZSB3b3VsZCBvbmx5IGdldCB0 aGUgcmVzb3VyY2UgbmFtZSwgd2hpbGUgdGhlIE1GRCBjb3JlCj4gZHJpdmVyIHdvdWxkIHNldCB1 cCB0aGUgcmVnbWFwcy4KPiAKPiBlLmcuIGRyaXZlcnMvbWZkL29jZWxvdC1jb3JlLmMgaGFzIChh bm5vdGF0ZWQpOgo+IHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmVzb3VyY2UgdnNjNzUxMl9zZ3Bpb19y ZXNvdXJjZXNbXSA9IHsKPiAgICAgREVGSU5FX1JFU19SRUdfTkFNRUQoc3RhcnQsIHNpemUsICJn Y2JfZ3BpbyIpIH07Cj4gCj4gTm93LCB0aGUgZHJpdmVycy9waW5jdHJsL3BpbmN0cmwtb2NlbG90 LmMgZXhwZWN0cyByZXNvdXJjZSAwIHRvIGJlIHRoZQo+IGdwaW8gcmVzb3VyY2UsIGFuZCBnZXRz IHRoZSByZXNvdXJjZSBieSBpbmRleC4KPiAKPiBTbyBmb3IgdGhpcyB0aGVyZSBzZWVtIHRvIGJl IHR3byBvcHRpb25zOgo+IE9wdGlvbiAxOgo+IGRyaXZlcnMvcGluY3RybC9waW5jdHJsLW9jZWxv dC5jOgo+IHJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX1JFRywg MCk7Cj4gbWFwID0gZGV2X2dldF9yZWdtYXAoZGV2LT5wYXJlbnQsIHJlcy0+bmFtZSk7Cj4gCj4g Cj4gT1IgT3B0aW9uIDI6Cj4gaW5jbHVkZS9saW51eC9tZmQvb2NlbG90LmggaGFzIHNvbWV0aGlu ZyBsaWtlOgo+ICNkZWZpbmUgR0NCX0dQSU9fUkVHTUFQX05BTUUgImdjYl9ncGlvIgo+IAo+IGFu ZCBkcml2ZXJzL3BpbmN0cmwvcGluY3RybC1vY2Vsb3QuYyBza2lwcyBnZXRfcmVzb3VyY2UgYW5k IGp1bXBzIHRvOgo+IG1hcCA9IGRldl9nZXRfcmVnbWFwKGRldi0+cGFyZW50LCBHQ0JfR1BJT19S RUdNQVBfTkFNRSk7Cj4gCj4gKFdpdGggZXJyb3IgY2hlY2tpbmcsIG1hY3JvIHJldXNlLCBldGMu KQo+IAo+IAo+IEkgbGlrZSBvcHRpb24gMSwgc2luY2UgaXQgdGhlbiBtYWtlcyBvY2Vsb3QtcGlu Y3RybC5jIGhhdmUgbm8gcmVsaWFuY2UKPiBvbiBpbmNsdWRlL2xpbnV4L21mZC9vY2Vsb3QuaC4g QnV0IGluIGJvdGggY2FzZXMsIGFsbCB0aGUgcmVnbWFwcyBhcmUKPiBzZXQgdXAgaW4gYWR2YW5j ZSBkdXJpbmcgdGhlIHN0YXJ0IG9mIG9jZWxvdF9jb3JlX2luaXQsIGp1c3QgYmVmb3JlCj4gZGV2 bV9tZmRfYWRkX2RldmljZXMgaXMgY2FsbGVkLgo+IAo+IAo+IEkgc2hvdWxkIGJlIGFibGUgdG8g dGVzdCB0aGlzIGFsbCB0b25pZ2h0LgoKVGhhbmsgeW91IFZsYWRpbWlyIGZvciBzdGVwcGluZyBp biB0byBjbGFyaWZ5IHByZXZpb3VzIHBvaW50cy4KCldlbGwgZG9uZSBib3RoIG9mIHlvdSBmb3Ig dGhpcyBjb2xsYWJvcmF0aXZlIGVmZm9ydC4gIEdyZWF0IHRvIHNlZSEKCi0tIApMZWUgSm9uZXMg W+adjueQvOaWr10KUHJpbmNpcGFsIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2Vz CkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cg TGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==