From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38119C433EF for ; Thu, 30 Jun 2022 14:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GYm1oQAVVQzyIX/egC6i9nsoqOj4aSdTV3G9NPww+ek=; b=1ufcHsC1uNS9Z6 RNslz59aadMj3Wd+e9BS+ezfSFZKUwTXyEfPlhwwt/ysOha1DvHQvasAoOKOl3/LIstsvNwtgc/k7 P+sRoFpwwsLapFa1pIj1KHXHZHlgk1IiAGZXzn3bokrecLX7+/uyiwc+stCfr2mBQsQAh2FKgY9oK m9jSxfvqBjJh8IN4GXZnRU4OyZQj/ycV7piPITL9D6x/w30X86QmZHPxp8D7RJsxOaRgIh7bovzem yq5Nn5JOQ2WU3niQFI9uevAhtO3BM37Z7c45Yaytq1T8CH8KFto4lhvC4wwX1lSJZ75agaP3FJghd Tx8YxNN+1YaIOqal5q+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6v7j-00053x-Hg; Thu, 30 Jun 2022 14:26:27 +0000 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6v7g-00052s-OV for linux-arm-kernel@lists.infradead.org; Thu, 30 Jun 2022 14:26:26 +0000 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1048b8a38bbso25967020fac.12 for ; Thu, 30 Jun 2022 07:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wsN5IUSis3Z9MkPYvhHUE1vLfPsFtgly3iXAQhTJWNs=; b=K87adrRImCtI+NFBDR3YsxzkNDDTMpvENdbkPaLP+nxxuS72mCCtGz/XQCfE+A78sH 9JQbOp6wGbR1VYqR206soj2MfK2ZhIyEliPCHJhP76JTM1PrmW/9n2myfUJmpk6b8gCZ GFymIXtYfm1ZUHYDTZho75chrqwc1rFc/+C/XUUuq9cpqCkGxQSwJOr2bJZOUGHdGd0l hPAvA3P2/ZgjNt9bb1PoWoBuFRaBBbyO2MSOXpoVlCAZj+Ui+zsyoIDtpzY99S94hyCp Bi7BAW5nQIpY+cgrB5YQriVP6UQGfqYjO83iW9GRXJtlXVoUNfdE38p7z41NenMPDg4z QROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wsN5IUSis3Z9MkPYvhHUE1vLfPsFtgly3iXAQhTJWNs=; b=2Vq3GDBhoJ5DD4uV/B3to0wAmSlMle8AAWOBsl7EpfxZtQsD5aKnJQ7CFDxLXSOnMb 3dM1uC3SN1zXshl5AChd6HbzRZAHvDOfvNTwkL04+OVSZyABDPZ7JNove80Pm+b8b9l7 oZFVeYkvLCp15pn2eOGe486z1JimS2jHKd1wqqsD7vkkb3D9WQnENLqXO7W0AECFBCST fK7z82dNUHaVT2NILMuaVttVL831pn3DFjSyguF/+nej5Jwf7XpSuIecZOo8nU4zDlel oZGJscpdmhKj19b8SoFeN1UmPyGeOfawN3zUG0AsNL1Al2cTv/RX6q2wBkmVR0Kxkhrj yvog== X-Gm-Message-State: AJIora/C2X472V8tIXnUCFDKdQ5GuX+GknqUL8F6I/VpgluOqt3ODr1y NyUnD/O/HiEg+tBsFmntT2jJpw== X-Google-Smtp-Source: AGRyM1v2y5Xuo0LcBAt3msFqvHWw/E5JzfujPBz3bluqhmVvGK2L29ZVowaTFD6z/Y4p2A4LrnNO2A== X-Received: by 2002:a05:6870:b381:b0:fe:2004:b3b5 with SMTP id w1-20020a056870b38100b000fe2004b3b5mr5824807oap.63.1656599181559; Thu, 30 Jun 2022 07:26:21 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e12-20020a056870d10c00b0010490c6b552sm13054066oac.35.2022.06.30.07.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 07:26:20 -0700 (PDT) Date: Thu, 30 Jun 2022 09:26:19 -0500 From: Bjorn Andersson To: Rajendra Nayak Cc: Krzysztof Kozlowski , Andy Gross , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring Subject: Re: [PATCH v5 1/4] dt-bindings: interconnect: qcom,msm8998-cpu-bwmon: add BWMON device Message-ID: References: <20220629075250.17610-1-krzysztof.kozlowski@linaro.org> <20220629075250.17610-2-krzysztof.kozlowski@linaro.org> <7d1fe567-6dd7-a6e0-08bf-225e8d515931@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7d1fe567-6dd7-a6e0-08bf-225e8d515931@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220630_072624_853584_0329C461 X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 29 Jun 06:21 CDT 2022, Rajendra Nayak wrote: > > > This BWMON device sits between > > CPU and Last Level Cache Controller. > > []... > > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - qcom,sdm845-cpu-bwmon > > should this be qcom,sdm845-llcc-bwmon instead since it actually > tells us the llcc bw values? > That way perhaps the other one between llcc and DDR can be > qcom,sdm845-ddr-bwmon. > My understanding is that this bwmon instance measures the data throughput on the CPU subsystem-ports and that the bwmon5 instance measures the traffic from the memnoc towards LLCC and DDR. Which matches the downstream naming of bwmon4 == cpu, bwmon5 == llcc. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97CFC43334 for ; Thu, 30 Jun 2022 14:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237196AbiF3Og0 (ORCPT ); Thu, 30 Jun 2022 10:36:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237158AbiF3Of7 (ORCPT ); Thu, 30 Jun 2022 10:35:59 -0400 Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 499B13BA45 for ; Thu, 30 Jun 2022 07:26:22 -0700 (PDT) Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-101ec2d6087so26029664fac.3 for ; Thu, 30 Jun 2022 07:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wsN5IUSis3Z9MkPYvhHUE1vLfPsFtgly3iXAQhTJWNs=; b=K87adrRImCtI+NFBDR3YsxzkNDDTMpvENdbkPaLP+nxxuS72mCCtGz/XQCfE+A78sH 9JQbOp6wGbR1VYqR206soj2MfK2ZhIyEliPCHJhP76JTM1PrmW/9n2myfUJmpk6b8gCZ GFymIXtYfm1ZUHYDTZho75chrqwc1rFc/+C/XUUuq9cpqCkGxQSwJOr2bJZOUGHdGd0l hPAvA3P2/ZgjNt9bb1PoWoBuFRaBBbyO2MSOXpoVlCAZj+Ui+zsyoIDtpzY99S94hyCp Bi7BAW5nQIpY+cgrB5YQriVP6UQGfqYjO83iW9GRXJtlXVoUNfdE38p7z41NenMPDg4z QROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wsN5IUSis3Z9MkPYvhHUE1vLfPsFtgly3iXAQhTJWNs=; b=4rhaU5S9FbKwo1Q/0O1xNCs/5P8FVfBv5aBLgtAAGruSolBeJ2Y+6WdejZDTIxtQ2K +xQHglYeAjHANf66Oi9bWedx7DggAbk5LrplmFdaLh1uR8z2tMtu4G5Q0OKNlCE7T5vX kYEe6fSkk+4UMU0q8it/Df6+5CB/QygoH+LSHvpF2ksZwmtbG5Z4buObOPJzrmEGNsZf bWFuxIiHkeBG4fLo7TazPhphT+e7GmBQ2PLbNlfOSJTVE0bIdj52UPNrSTD+zd2Kt+s7 2/FQPd1UKSFEc0gRdgU+unXwDnBP3Ce+aMhWCvA3W8bxyWbhJwTs7HsKXZg/BFuXEVsL zmpQ== X-Gm-Message-State: AJIora8R6fB5dgKy3l9TlgcePUaQNuBB67W0bNtKr2rVOG2+oKG0/1Kp CdAVC/jSnHVbs2WhoKbVyV9J1Q== X-Google-Smtp-Source: AGRyM1v2y5Xuo0LcBAt3msFqvHWw/E5JzfujPBz3bluqhmVvGK2L29ZVowaTFD6z/Y4p2A4LrnNO2A== X-Received: by 2002:a05:6870:b381:b0:fe:2004:b3b5 with SMTP id w1-20020a056870b38100b000fe2004b3b5mr5824807oap.63.1656599181559; Thu, 30 Jun 2022 07:26:21 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e12-20020a056870d10c00b0010490c6b552sm13054066oac.35.2022.06.30.07.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 07:26:20 -0700 (PDT) Date: Thu, 30 Jun 2022 09:26:19 -0500 From: Bjorn Andersson To: Rajendra Nayak Cc: Krzysztof Kozlowski , Andy Gross , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring Subject: Re: [PATCH v5 1/4] dt-bindings: interconnect: qcom,msm8998-cpu-bwmon: add BWMON device Message-ID: References: <20220629075250.17610-1-krzysztof.kozlowski@linaro.org> <20220629075250.17610-2-krzysztof.kozlowski@linaro.org> <7d1fe567-6dd7-a6e0-08bf-225e8d515931@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d1fe567-6dd7-a6e0-08bf-225e8d515931@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 29 Jun 06:21 CDT 2022, Rajendra Nayak wrote: > > > This BWMON device sits between > > CPU and Last Level Cache Controller. > > []... > > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - qcom,sdm845-cpu-bwmon > > should this be qcom,sdm845-llcc-bwmon instead since it actually > tells us the llcc bw values? > That way perhaps the other one between llcc and DDR can be > qcom,sdm845-ddr-bwmon. > My understanding is that this bwmon instance measures the data throughput on the CPU subsystem-ports and that the bwmon5 instance measures the traffic from the memnoc towards LLCC and DDR. Which matches the downstream naming of bwmon4 == cpu, bwmon5 == llcc. Regards, Bjorn