From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FDACCA482 for ; Thu, 30 Jun 2022 21:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237486AbiF3V1p (ORCPT ); Thu, 30 Jun 2022 17:27:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237383AbiF3V1k (ORCPT ); Thu, 30 Jun 2022 17:27:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8F060443D3 for ; Thu, 30 Jun 2022 14:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656624457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wd1ki83p3SXylkpu3EgQoI69vBxY8no6C/MZWnJcErg=; b=SBqGYRC/qEreAurIQg4SdLx+nRYR3BkDyB2hmchlNnzr0LZRWXmR/oEdiuMMhJ1Ev24o34 TkHUKt3pD8ZpY11qsrlivmUk4zdUWgSR4kVzsQIuulRiJRBE5/mbfxsiaIgcJJfdHlPc86 Y/rh17jr4usYDXmUAxUVdHxWC6sKwMo= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-7-DhXTZubDMU6LgoffY8e9cA-1; Thu, 30 Jun 2022 17:27:34 -0400 X-MC-Unique: DhXTZubDMU6LgoffY8e9cA-1 Received: by mail-io1-f71.google.com with SMTP id f1-20020a056602070100b00674f8035487so189962iox.17 for ; Thu, 30 Jun 2022 14:27:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Wd1ki83p3SXylkpu3EgQoI69vBxY8no6C/MZWnJcErg=; b=heiEEoXSKwAwDHrSTYNGelnEuIJxR3aQdtHVtI8akJp9idmE8C6MhGHDuYbgn0qrMe 3+Cp8mIeATe1pql6tErpd2GEZ+9yIO/r57PrLUrGi57zLWqRXHWCIGvVXfv7cnRo86Sg TNnEBuLddow7ovgXlGmmKxjpPQCe+3M243AM005ZqSDgO7Hi2//SSMT4/eJm0CKivXjY Kg9DVGVtBl05BRPu00AeOOIVVVz6AK1QAgJ2t9Im7i6jqgfCyvPtQtRTyFqJ6/YisfsW jiLvWy0cSaIMZ71RuYFSJ/z/eSNvrHLkF1psPron+11RrfcO5SR4H6qgSmzNPHeOhRyO YutQ== X-Gm-Message-State: AJIora9SX8SIoc0UlVm97R7mxzCPOWayrF5VhLk0WbOtF3Ybs1pW6crA RacI8AKDJvMgfSP62QcjcL84EmCWj3SuMV1f1t+IGvvXK9ix8TWfytOdbKB1om5u5kfP1tMwb/P zf2QYD36EgLE5PPCH5KVXmUyB X-Received: by 2002:a6b:fb05:0:b0:657:655e:a287 with SMTP id h5-20020a6bfb05000000b00657655ea287mr5835539iog.211.1656624453803; Thu, 30 Jun 2022 14:27:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t78+bU25q9esv1lcWaU4zBR2o8PbPeqMIreeppu9DzAo0eFqpPx7c+rMK82ivDZlWfZZexEQ== X-Received: by 2002:a6b:fb05:0:b0:657:655e:a287 with SMTP id h5-20020a6bfb05000000b00657655ea287mr5835526iog.211.1656624453577; Thu, 30 Jun 2022 14:27:33 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id e98-20020a02866b000000b00331598832besm9005563jai.25.2022.06.30.14.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 14:27:32 -0700 (PDT) Date: Thu, 30 Jun 2022 17:27:30 -0400 From: Peter Xu To: John Hubbard Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: References: <20220622213656.81546-2-peterx@redhat.com> <16c181d3-09ef-ace4-c910-0a13fc245e48@nvidia.com> <177284f9-416d-c142-a826-e9a497751fca@nvidia.com> <17f9eae0-01bb-4793-201e-16ee267c07f2@nvidia.com> <0183984a-c95f-c92e-629e-775071b5cd23@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0183984a-c95f-c92e-629e-775071b5cd23@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2022 at 12:01:53PM -0700, John Hubbard wrote: > On 6/30/22 06:49, Peter Xu wrote: > > Looks good to me, I'd tune a bit to make it less ambiguous on a few places: > > > > /* > > * FAULT_FLAG_INTERRUPTIBLE is opt-in. GUP callers must set > > * FOLL_INTERRUPTIBLE to enable FAULT_FLAG_INTERRUPTIBLE. > > * That's because some callers may not be prepared to > > * handle early exits caused by non-fatal signals. > > */ > > > > Would that be okay to you? > > > > Yes, looks good. With that change, please feel free to add: > > Reviewed-by: John Hubbard Will do, thanks! -- Peter Xu