From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEF9C43334 for ; Mon, 20 Jun 2022 05:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238315AbiFTFzw (ORCPT ); Mon, 20 Jun 2022 01:55:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbiFTFzv (ORCPT ); Mon, 20 Jun 2022 01:55:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A43DDE85 for ; Sun, 19 Jun 2022 22:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OK5Lmq26Sjt+WwRVBGAaabVhvu5RcuOZ2N2C2m7lIww=; b=Uq4BRyYARS/afjWOVHN6grwCpy m72lpKaCKoybAL51mCxsT1Kp3sDmm2CoSesqrUbFzv5NytHehq9cXl6f0ynNXSDxsJnHcch1m2Ebe 8dl/9X+0BnJSw5qRQBuXbEJ/hzJhNoMQDZN/DNW+1gjtkdwvwJxF6PSK5PYaiOhDAaJghBxCQM2cB cT09Ft064qBSblGoTeN9WIpbyB+OxY5UAzIJJl9+rCXJwKFqn8iT9hiorm219NhN3FsLtu5WD+un+ 4apUZcWQF1vo6UHX15U4qWqDLXRvaKnewqob+F8GlNmW87uwzfFvHOb/cv7mShHm1JEpwkEvg+zI1 W96EPvoQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3ANw-00GM3L-9x; Mon, 20 Jun 2022 05:55:40 +0000 Date: Sun, 19 Jun 2022 22:55:40 -0700 From: Christoph Hellwig To: Anshuman Khandual Cc: kernel test robot , linux-mm@kvack.org, kbuild-all@lists.01.org, hch@infradead.org, Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility Message-ID: References: <20220616040924.1022607-2-anshuman.khandual@arm.com> <202206162004.ak9KTfMD-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022 at 10:15:31AM +0530, Anshuman Khandual wrote: > +extern pgprot_t protection_map[16]; externs in .c files are never a good idea. I'd rather add a helper function toadd pgprot_encrypted to protection_map to pgprot.c. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8137498607429737332==" MIME-Version: 1.0 From: Christoph Hellwig To: kbuild-all@lists.01.org Subject: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility Date: Sun, 19 Jun 2022 22:55:40 -0700 Message-ID: In-Reply-To: List-Id: --===============8137498607429737332== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 20, 2022 at 10:15:31AM +0530, Anshuman Khandual wrote: > +extern pgprot_t protection_map[16]; externs in .c files are never a good idea. I'd rather add a helper function toadd pgprot_encrypted to protection_map to pgprot.c. --===============8137498607429737332==--