All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	linux-kernel@vger.kernel.org, Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc
Date: Mon, 20 Jun 2022 13:44:31 +0300	[thread overview]
Message-ID: <YrBPjzOaAjqSZBqD@smile.fi.intel.com> (raw)
In-Reply-To: <ff5ac808-fde9-57ee-7d47-a4999428210e@redhat.com>

On Mon, Jun 20, 2022 at 12:00:35PM +0200, Hans de Goede wrote:
> On 6/20/22 11:42, Andy Shevchenko wrote:
> > On Mon, Jun 20, 2022 at 10:51:33AM +0200, Hans de Goede wrote:

...

> >> Maybe do a follow up renaming CONFIG_INTEL_SOC_PMIC to
> >> CONFIG_INTEL_SOC_PMIC_CRC and also change the module name
> >> from intel-soc-pmic to intel-soc-pmic-crc ?
> > 
> > I thought about that, but decided to leave it for later since it will take a
> > lot of subsystems and better to be considered out of the scope of this series.
> > 
> > Do you agree?
> 
> Sure we can do this later. Note that there are not that much dependencies
> on INTEL_SOC_PMIC though. The ones which I could find are:
> 
> drivers/usb/typec/tcpm/Kconfig: config TYPEC_WCOVE
> -which is wrong regardless of the rename and should just be dropped
>  in a separate/unrelated patch. can you submit a patch for this ?

Sure...

Done!

> drivers/gpio/Kconfig: config GPIO_CRYSTAL_COVE
> drivers/pwm/Kconfig: config PWM_CRC
> drivers/acpi/pmic/Kconfig: config BYTCRC_PMIC_OPREGION &&
>                            config CHTCRC_PMIC_OPREGION
> 
> So not that much, but still 3 subystems, so yeah probably best
> to do that cleanup later,

Yup, let's do it later with Type-C fix in mind, that will save us
doing unneeded churn.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2022-06-20 10:44 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 18:25 [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc Andy Shevchenko
2022-06-16 18:25 ` [PATCH v1 2/9] mfd: intel_soc_pmic: Move non-Intel Makefile entries to their own group Andy Shevchenko
2022-06-27 13:23   ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 3/9] mfd: intel_soc_pmic_crc: Use devm_regmap_add_irq_chip() Andy Shevchenko
2022-06-27 13:24   ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 4/9] mfd: intel_soc_pmic_crc: Convert to use i2c_get/set_clientdata() Andy Shevchenko
2022-06-27 13:26   ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 5/9] mfd: intel_soc_pmic_crc: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc Andy Shevchenko
2022-06-27 13:26   ` Lee Jones
2022-06-27 13:39     ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 6/9] mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery Andy Shevchenko
2022-06-27 13:27   ` Lee Jones
2022-06-27 13:39     ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 7/9] mfd: intel_soc_pmic_crc: Convert driver to use ->probe_new() Andy Shevchenko
2022-06-27 13:43   ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 8/9] mfd: intel_soc_pmic_crc: Replace intel_soc_pmic with crystal_cove Andy Shevchenko
2022-06-27 13:45   ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 9/9] mfd: intel_soc_pmic_crc: Update the copyright year Andy Shevchenko
2022-06-27 13:46   ` Lee Jones
2022-06-28  9:48     ` Andy Shevchenko
2022-06-20  8:51 ` [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc Hans de Goede
2022-06-20  9:42   ` Andy Shevchenko
2022-06-20 10:00     ` Hans de Goede
2022-06-20 10:44       ` Andy Shevchenko [this message]
2022-06-20  9:04 ` Hans de Goede
2022-06-20  9:42   ` Andy Shevchenko
2022-06-28 23:06   ` Andy Shevchenko
2022-06-29 13:18     ` Hans de Goede
2022-06-29 13:19       ` Hans de Goede
2022-06-29 16:03         ` Andy Shevchenko
2022-06-27 13:08 ` Lee Jones
2022-06-28  9:50   ` Andy Shevchenko
2022-06-29 14:35     ` Lee Jones
2022-06-29 15:41       ` Andy Shevchenko
2022-06-30  8:01         ` Lee Jones
2022-06-30  8:07           ` Andy Shevchenko
2022-06-30  8:36             ` Hans de Goede
2022-06-30  8:45               ` Lee Jones
2022-07-15 19:54                 ` Andy Shevchenko
2022-07-18  8:12                   ` Lee Jones
2022-07-18  8:12                     ` Lee Jones
2022-07-18 12:19                       ` Andy Shevchenko
2022-07-18 15:17                         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrBPjzOaAjqSZBqD@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.