All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v2] s390/kvm: avoid hypfs error message
Date: Mon, 20 Jun 2022 13:31:59 +0200	[thread overview]
Message-ID: <YrBarz+NVJmS+bBb@tuxmaker.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20220620094534.18967-1-jgross@suse.com>

On Mon, Jun 20, 2022 at 11:45:34AM +0200, Juergen Gross wrote:
> When booting under KVM the following error messages are issued:
> 
> hypfs.7f5705: The hardware system does not support hypfs
> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
> 
> Demote the severity of first message from "error" to "info" and issue
> the second message only in other error cases.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Applied, thanks!

> ---
> V2:
> - don't bail out if KVM, but avoid error messages instead (Christian
>   Borntraeger)
> ---
>  arch/s390/hypfs/hypfs_diag.c | 2 +-
>  arch/s390/hypfs/inode.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/hypfs/hypfs_diag.c b/arch/s390/hypfs/hypfs_diag.c
> index f0bc4dc3e9bf..6511d15ace45 100644
> --- a/arch/s390/hypfs/hypfs_diag.c
> +++ b/arch/s390/hypfs/hypfs_diag.c
> @@ -437,7 +437,7 @@ __init int hypfs_diag_init(void)
>  	int rc;
>  
>  	if (diag204_probe()) {
> -		pr_err("The hardware system does not support hypfs\n");
> +		pr_info("The hardware system does not support hypfs\n");
>  		return -ENODATA;
>  	}
>  
> diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
> index 5c97f48cea91..ee919bfc8186 100644
> --- a/arch/s390/hypfs/inode.c
> +++ b/arch/s390/hypfs/inode.c
> @@ -496,9 +496,9 @@ static int __init hypfs_init(void)
>  	hypfs_vm_exit();
>  fail_hypfs_diag_exit:
>  	hypfs_diag_exit();
> +	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
>  fail_dbfs_exit:
>  	hypfs_dbfs_exit();
> -	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
>  	return rc;
>  }
>  device_initcall(hypfs_init)
> -- 
> 2.35.3
> 

  parent reply	other threads:[~2022-06-20 11:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  9:45 [PATCH v2] s390/kvm: avoid hypfs error message Juergen Gross
2022-06-20  9:47 ` Heiko Carstens
2022-06-20  9:48 ` Christian Borntraeger
2022-06-20 11:31 ` Alexander Gordeev [this message]
2022-08-11  8:14   ` Juergen Gross
2022-08-11 14:49     ` Alexander Gordeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrBarz+NVJmS+bBb@tuxmaker.boeblingen.de.ibm.com \
    --to=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.