From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0F7C43334 for ; Mon, 20 Jun 2022 15:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235644AbiFTPB3 (ORCPT ); Mon, 20 Jun 2022 11:01:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbiFTPBJ (ORCPT ); Mon, 20 Jun 2022 11:01:09 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 16B5D2A24E for ; Mon, 20 Jun 2022 07:26:45 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C925E1596; Mon, 20 Jun 2022 07:26:44 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.70.167]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63A803F534; Mon, 20 Jun 2022 07:26:41 -0700 (PDT) Date: Mon, 20 Jun 2022 15:26:37 +0100 From: Mark Rutland To: Tong Tiangen Cc: James Morse , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Robin Murphy , Dave Hansen , Catalin Marinas , Will Deacon , Alexander Viro , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , x86@kernel.org, "H . Peter Anvin" , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kefeng Wang , Xie XiuQi , Guohanjun Subject: Re: [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO Message-ID: References: <20220528065056.1034168-1-tongtiangen@huawei.com> <20220528065056.1034168-3-tongtiangen@huawei.com> <4371a7c9-8766-9fee-2558-e6f43f06ad19@huawei.com> <0da734f3-5743-3df3-3f90-d92e5bd585ce@huawei.com> <684f0362-6e58-753d-32e1-112c6ffe6d12@huawei.com> <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022 at 10:13:41PM +0800, Tong Tiangen wrote: > > > 在 2022/6/20 17:10, Mark Rutland 写道: > > On Mon, Jun 20, 2022 at 10:59:12AM +0800, Tong Tiangen wrote: > > > 在 2022/6/18 20:40, Mark Rutland 写道: > > > The following errors are reported during compilation: > > > [...] > > > arch/arm64/lib/clear_user.S:45: Error: invalid operands (*ABS* and *UND* > > > sections) for `<<' > > > [...] > > > > As above, I'm not seeing this. > > > > This suggests that the EX_DATA_REG() macro is going wrong somehow. Assuming the > > operand types correspond to the LHS and RHS of the expression, this would mean > > the GPR number is defined, but the REG value is not, and I can't currently see > > how that can happen. > Now I can compile success, both versions 9.4.0 and 11.2.0. > > I should have made a mistake. There is no problem using your implementation. > I will send a new version these days. No problem; thanks for confirming! Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4350C43334 for ; Mon, 20 Jun 2022 14:27:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LRX6q1Xzhz3cgW for ; Tue, 21 Jun 2022 00:27:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=mark.rutland@arm.com; receiver=) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4LRX6J1sgSz3bqr for ; Tue, 21 Jun 2022 00:27:17 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C925E1596; Mon, 20 Jun 2022 07:26:44 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.70.167]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63A803F534; Mon, 20 Jun 2022 07:26:41 -0700 (PDT) Date: Mon, 20 Jun 2022 15:26:37 +0100 From: Mark Rutland To: Tong Tiangen Subject: Re: [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO Message-ID: References: <20220528065056.1034168-1-tongtiangen@huawei.com> <20220528065056.1034168-3-tongtiangen@huawei.com> <4371a7c9-8766-9fee-2558-e6f43f06ad19@huawei.com> <0da734f3-5743-3df3-3f90-d92e5bd585ce@huawei.com> <684f0362-6e58-753d-32e1-112c6ffe6d12@huawei.com> <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , Dave Hansen , linux-mm@kvack.org, Paul Mackerras , Guohanjun , Will Deacon , "H . Peter Anvin" , x86@kernel.org, Ingo Molnar , Catalin Marinas , Xie XiuQi , Borislav Petkov , Alexander Viro , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Robin Murphy , linux-kernel@vger.kernel.org, James Morse , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 20, 2022 at 10:13:41PM +0800, Tong Tiangen wrote: > > > 在 2022/6/20 17:10, Mark Rutland 写道: > > On Mon, Jun 20, 2022 at 10:59:12AM +0800, Tong Tiangen wrote: > > > 在 2022/6/18 20:40, Mark Rutland 写道: > > > The following errors are reported during compilation: > > > [...] > > > arch/arm64/lib/clear_user.S:45: Error: invalid operands (*ABS* and *UND* > > > sections) for `<<' > > > [...] > > > > As above, I'm not seeing this. > > > > This suggests that the EX_DATA_REG() macro is going wrong somehow. Assuming the > > operand types correspond to the LHS and RHS of the expression, this would mean > > the GPR number is defined, but the REG value is not, and I can't currently see > > how that can happen. > Now I can compile success, both versions 9.4.0 and 11.2.0. > > I should have made a mistake. There is no problem using your implementation. > I will send a new version these days. No problem; thanks for confirming! Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF9FFCCA479 for ; Mon, 20 Jun 2022 14:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s78MYWOFJDhETiwLUDnhN/z7UyUaGKAxF1/rScNFenM=; b=bgS/ThCljrhsHt of3Y0smCR2uYsdQUeAM75f9h6kBAHncBqdAqvC6g9wDxCno0jjvIsjdJwGNdK9GK0GDD4vjjc3lvd W70SXaBppW4McgMn2CKV1IpvtS7pchEN5u9WV7R53w8bIMQr2rmc9fHF+cPcLKAqfFFYKZtHlrcRS 9PXLAbdVBUFHmFDJTEiU+txLravU4QSqoLRMo8VqtKEXZGcP4hhaMnYAP329ItuI+HS01XxzppBcZ hhSlhmR4C3u2JCUa3llEopkUmeQgVBsl4lxZvihqHjDEeowbPwYbEApheKmmUDKc2ey8CixhZj3uL kAYCk10MN7YiKUy44PGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3IMd-001430-Ms; Mon, 20 Jun 2022 14:26:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3IMZ-00142N-VA for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2022 14:26:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C925E1596; Mon, 20 Jun 2022 07:26:44 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.70.167]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63A803F534; Mon, 20 Jun 2022 07:26:41 -0700 (PDT) Date: Mon, 20 Jun 2022 15:26:37 +0100 From: Mark Rutland To: Tong Tiangen Cc: James Morse , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Robin Murphy , Dave Hansen , Catalin Marinas , Will Deacon , Alexander Viro , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , x86@kernel.org, "H . Peter Anvin" , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kefeng Wang , Xie XiuQi , Guohanjun Subject: Re: [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO Message-ID: References: <20220528065056.1034168-1-tongtiangen@huawei.com> <20220528065056.1034168-3-tongtiangen@huawei.com> <4371a7c9-8766-9fee-2558-e6f43f06ad19@huawei.com> <0da734f3-5743-3df3-3f90-d92e5bd585ce@huawei.com> <684f0362-6e58-753d-32e1-112c6ffe6d12@huawei.com> <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_072648_086071_BB591088 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMjAsIDIwMjIgYXQgMTA6MTM6NDFQTSArMDgwMCwgVG9uZyBUaWFuZ2VuIHdy b3RlOgo+IAo+IAo+IOWcqCAyMDIyLzYvMjAgMTc6MTAsIE1hcmsgUnV0bGFuZCDlhpnpgZM6Cj4g PiBPbiBNb24sIEp1biAyMCwgMjAyMiBhdCAxMDo1OToxMkFNICswODAwLCBUb25nIFRpYW5nZW4g d3JvdGU6Cj4gPiA+IOWcqCAyMDIyLzYvMTggMjA6NDAsIE1hcmsgUnV0bGFuZCDlhpnpgZM6Cj4g PiA+IFRoZSBmb2xsb3dpbmcgZXJyb3JzIGFyZSByZXBvcnRlZCBkdXJpbmcgY29tcGlsYXRpb246 Cj4gPiA+IFsuLi5dCj4gPiA+IGFyY2gvYXJtNjQvbGliL2NsZWFyX3VzZXIuUzo0NTogRXJyb3I6 IGludmFsaWQgb3BlcmFuZHMgKCpBQlMqIGFuZCAqVU5EKgo+ID4gPiBzZWN0aW9ucykgZm9yIGA8 PCcKPiA+ID4gWy4uLl0KPiA+IAo+ID4gQXMgYWJvdmUsIEknbSBub3Qgc2VlaW5nIHRoaXMuCj4g PiAKPiA+IFRoaXMgc3VnZ2VzdHMgdGhhdCB0aGUgRVhfREFUQV9SRUcoKSBtYWNybyBpcyBnb2lu ZyB3cm9uZyBzb21laG93LiBBc3N1bWluZyB0aGUKPiA+IG9wZXJhbmQgdHlwZXMgY29ycmVzcG9u ZCB0byB0aGUgTEhTIGFuZCBSSFMgb2YgdGhlIGV4cHJlc3Npb24sIHRoaXMgd291bGQgbWVhbgo+ ID4gdGhlIEdQUiBudW1iZXIgaXMgZGVmaW5lZCwgYnV0IHRoZSBSRUcgdmFsdWUgaXMgbm90LCBh bmQgSSBjYW4ndCBjdXJyZW50bHkgc2VlCj4gPiBob3cgdGhhdCBjYW4gaGFwcGVuLgogCj4gTm93 IEkgY2FuIGNvbXBpbGUgc3VjY2VzcywgYm90aCB2ZXJzaW9ucyA5LjQuMCBhbmQgMTEuMi4wLgo+ IAo+IEkgc2hvdWxkIGhhdmUgbWFkZSBhIG1pc3Rha2UuIFRoZXJlIGlzIG5vIHByb2JsZW0gdXNp bmcgeW91ciBpbXBsZW1lbnRhdGlvbi4KPiBJIHdpbGwgc2VuZCBhIG5ldyB2ZXJzaW9uIHRoZXNl IGRheXMuCgpObyBwcm9ibGVtOyB0aGFua3MgZm9yIGNvbmZpcm1pbmchCgpNYXJrLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=