From: Muchun Song <songmuchun@bytedance.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: sj@kernel.org, akpm@linux-foundation.org,
mike.kravetz@oracle.com, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old
Date: Wed, 22 Jun 2022 11:09:16 +0800 [thread overview]
Message-ID: <YrKH3BlKA6sKdLbd@FVFYT0MHHV2J.usts.net> (raw)
In-Reply-To: <1655692482-28797-1-git-send-email-baolin.wang@linux.alibaba.com>
On Mon, Jun 20, 2022 at 10:34:42AM +0800, Baolin Wang wrote:
> The huge_ptep_set_access_flags() can not make the huge pte old according
> to the discussion [1], that means we will always mornitor the young state
> of the hugetlb though we stopped accessing the hugetlb, as a result DAMON
> will get inaccurate accessing statistics.
>
> So changing to use set_huge_pte_at() to make the huge pte old to fix this
> issue.
>
> [1] https://lore.kernel.org/all/Yqy97gXI4Nqb7dYo@arm.com/
>
> Fixes: 49f4203aae06 ("mm/damon: add access checking for hugetlb pages")
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
The changes make sense to me.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
prev parent reply other threads:[~2022-06-22 3:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 2:34 [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old Baolin Wang
2022-06-20 17:27 ` SeongJae Park
2022-06-21 8:45 ` Baolin Wang
2022-06-21 23:41 ` Mike Kravetz
2022-06-22 3:09 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrKH3BlKA6sKdLbd@FVFYT0MHHV2J.usts.net \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.