From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55AEFCCA481 for ; Wed, 22 Jun 2022 08:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348218AbiFVIrP (ORCPT ); Wed, 22 Jun 2022 04:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236729AbiFVIrP (ORCPT ); Wed, 22 Jun 2022 04:47:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48F1E396A2; Wed, 22 Jun 2022 01:47:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0DCA5B81CEE; Wed, 22 Jun 2022 08:47:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD63CC34114; Wed, 22 Jun 2022 08:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655887631; bh=9Cic3CRnN/+87wCqzwhlvsAQjVOpaTeW1l6o5THs8CI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cVkLQHWzW3Yw9TVz2dzzKzeR+QnUq7x4+bB64283XnsAVsrEODYwYX6FfUrgY6xrH nutrHVc3eirGnmejV5vkOXo90XofpO/yl0Uj3Kaqn1ip/DQJU76WjxQtCj+4DrQQ0n G81OuSPJX0C9G6bABNgG6GrkH3f+4cAjBS3l7tGWXHxKzKlo9MwjsDe2SM5YFp7Cqt iBHl/ezc/P6nuNMx312+xM2QzF9gSNAnj4aw8Lu4XIqg0PWcLad7EskZK8x4obrTXc Rm2ocVRqmeukupGMAZEPk2zTFv1VGor1JiiXNfHTEQtCc+kURThcfDNSdxo/xn56p5 F79Cz7Y6CW/4g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o3w0x-0002Su-Ct; Wed, 22 Jun 2022 10:47:07 +0200 Date: Wed, 22 Jun 2022 10:47:07 +0200 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Rob Herring , Krzysztof Kozlowski , Manivannan Sadhasivam , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] dt-bindings: arm: qcom: Document additional sc8280xp devices Message-ID: References: <20220622041224.627803-1-bjorn.andersson@linaro.org> <20220622041224.627803-2-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622041224.627803-2-bjorn.andersson@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jun 21, 2022 at 09:12:19PM -0700, Bjorn Andersson wrote: > Add the CRD (Customer Reference Design?) and the Lenovo Thinkpad X13s to Qualcomm refers to "Compute Reference Design", for example, in commit 427b249504ea ("arm64: dts: qcom: sc7280-crd: Add device tree files for CRD"). > the valid device compatibles found on the sc8280xp platform. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - Added the two missing board compatibles > > Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 5c06d1bfc046..6ec7521be19d 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -238,6 +238,8 @@ properties: > > - items: > - enum: > + - lenovo,thinkpad-x13s > + - qcom,sc8280xp-crd > - qcom,sc8280xp-qrd I believe the "qcom,sc8280xp-qrd" entry was a mistake and should have been "-crd" all along? Perhaps you should remove that entry in this patch. > - const: qcom,sc8280xp Looks good otherwise: Reviewed-by: Johan Hovold Johan