All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kate Hsuan <hpa@redhat.com>, Hans de Goede <hdegoede@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Straube <straube.linux@gmail.com>,
	"Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Pavel Skripkin <paskripkin@gmail.com>
Subject: Re: [PATCH v1] staging: r8188eu: an incorrect return value made the function always return fail
Date: Wed, 22 Jun 2022 13:25:13 +0100	[thread overview]
Message-ID: <YrMKKdvNqhydcBBY@equinox> (raw)
In-Reply-To: <5396e576-0fbe-430c-d983-a2f4b1569f09@lwfinger.net>

On Mon, Jun 20, 2022 at 09:05:17AM -0500, Larry Finger wrote:
> 
> The "for now" part is that Phillip plans to get rid of _FAIL and _SUCCESS,
> and replace the logic with a normal 1 for fail, etc.; however, this will be
> a major change that must be done carefully.
> 
> In any case NACK for this patch.
> 
> Larry
> 
> 
>

Hi all,

I would be happy to work on purging _FAIL and _SUCCESS from the driver
by all means - definitely a worthwhile goal. I know Pavel said he
might take a look too though - copying him in therefore to see if we can
coordinate an approach - happy to do as much or as little as desired.

Regards,
Phil

      reply	other threads:[~2022-06-22 12:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  8:54 [PATCH v1] staging: r8188eu: an incorrect return value made the function always return fail Kate Hsuan
2022-06-20  9:00 ` Greg Kroah-Hartman
2022-06-20  9:25   ` Kate Hsuan
2022-06-20  9:02 ` Hans de Goede
2022-06-20  9:37   ` Kate Hsuan
2022-06-20 14:05 ` Larry Finger
2022-06-22 12:25   ` Phillip Potter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrMKKdvNqhydcBBY@equinox \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=hpa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=paskripkin@gmail.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.