From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB79C43334 for ; Thu, 23 Jun 2022 21:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889CB8E0197; Thu, 23 Jun 2022 17:57:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 839708E0192; Thu, 23 Jun 2022 17:57:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 700F98E0197; Thu, 23 Jun 2022 17:57:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 611398E0192 for ; Thu, 23 Jun 2022 17:57:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 33560214C0 for ; Thu, 23 Jun 2022 21:57:53 +0000 (UTC) X-FDA: 79610863626.28.2630974 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 80D1440033 for ; Thu, 23 Jun 2022 21:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656021472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BkvYGLOkWDfB81s8q+9/xMWDFtApQhJQlGCzaUP79Ao=; b=D6zGsk3OljsynsrnbgsGop2fs8mcFtG+rBXVdHjFS4F82fyO9977HBuSuqJUCy/M6FSiI5 sksfSAKkTuEnZLgyXFitPNoboSwfjFU7gOweAf4IZZuEHo292JWDyQZ4JPR+pPyWb+62i0 YcfSsVEHdCZuKOLdtIEdQB7jBM5CLHk= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-380-I9CJ5-PyO5ab7CeDhjMgfA-1; Thu, 23 Jun 2022 17:57:50 -0400 X-MC-Unique: I9CJ5-PyO5ab7CeDhjMgfA-1 Received: by mail-io1-f69.google.com with SMTP id r9-20020a6b8f09000000b0067277113232so358608iod.18 for ; Thu, 23 Jun 2022 14:57:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BkvYGLOkWDfB81s8q+9/xMWDFtApQhJQlGCzaUP79Ao=; b=ASuNtgCMpCXGy8HD/hSgX+Aw2j8XGWudssnlQanfT4dylNemHxufXGl3OP9xDvj6gH xm4S5lT/5Jzrd/XkIbbv6WRjc4M0HSj5Anm9P1DDm6Fl7QQxYMN93bjp8xH16i7alKM7 LcZ4ysPctcsLKY5QY6EbKtqE8cPAIOMczxCj9JO7+qEl5TIRKvak3zvGUOttq/89ldci Q6NuILJLCBOC1lTdQbfaRwWCi29sB8BH769TUCpnOm/BKllphsv8qXnqSl1KqSV8SIs7 6JvRFv4i3ZsSbm29GyDLIsZ+H/WQy5rMdq4p0fmzFy3syTsPaU5pEYv8X6supZMDNFb4 wutA== X-Gm-Message-State: AJIora+0UXGvuCmh2sCzXKcmVF0LSidz4Wir1FE89OiTX2cNjnZ4RqKe 6LbWM2BpsPQ2dwVQ7rhDLgfWjzY8ciI5vsJ/xtKsoHwnpa5srG6p8gzxlmwRyYLtqrZxaH8mXEX RDbWyZ3Dy08Y= X-Received: by 2002:a05:6638:16c2:b0:332:3901:d8b7 with SMTP id g2-20020a05663816c200b003323901d8b7mr6456012jat.73.1656021469969; Thu, 23 Jun 2022 14:57:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ssvYxn7YEawoBVAxvZuHTWOxYOsycXC5lz0czeULZ6DKhbQoxAGp+GsCIJi0EQHfpSeYf3VQ== X-Received: by 2002:a05:6638:16c2:b0:332:3901:d8b7 with SMTP id g2-20020a05663816c200b003323901d8b7mr6455999jat.73.1656021469770; Thu, 23 Jun 2022 14:57:49 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id w3-20020a02b0c3000000b00339d4037e7csm259060jah.44.2022.06.23.14.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 14:57:48 -0700 (PDT) Date: Thu, 23 Jun 2022 17:57:24 -0400 From: Peter Xu To: Nadav Amit Cc: linux-mm@kvack.org, Nadav Amit , Mike Kravetz , Hugh Dickins , Andrew Morton , Axel Rasmussen , Mike Rapoport , David Hildenbrand Subject: Re: [PATCH v1 1/5] userfaultfd: introduce uffd_flags Message-ID: References: <20220622185038.71740-1-namit@vmware.com> <20220622185038.71740-2-namit@vmware.com> MIME-Version: 1.0 In-Reply-To: <20220622185038.71740-2-namit@vmware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656021472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BkvYGLOkWDfB81s8q+9/xMWDFtApQhJQlGCzaUP79Ao=; b=Y9O/BRFlKyV0OMfIUy9Pgxz3Ds12avI7uCEyzXXKVeEIDQdVKm1PMenomr5KTb/Z8NGQ+J O4UsLeBnKbGCDJSeh531OxsVAqGsiwHg//U/mIsurDf4vMV3jbJO4zXTftFMVzq38Yflvg jGx6oHnKjC/yhUcOt1+avM33fXyIQD4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D6zGsk3O; spf=none (imf27.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656021472; a=rsa-sha256; cv=none; b=jg3wMtVlL5pmc1PnSXJfzshEpcEPKAVgSrkqmqTttG7V92GneAPs6wQtvb7wC+06BHfXd+ pj9gE5ORL4HMIlH9ebzp75qEGg6kg8EKBwwfnkNzEH48XOx3eJVsjSL82RLwX/6/i1rzyp +gbYIEh6osdsGl3uoAJXGEqiN3BfQMU= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D6zGsk3O; spf=none (imf27.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: mpni1ke6uyet85m9qx4sawpqpdik3ezr X-Rspamd-Queue-Id: 80D1440033 X-HE-Tag: 1656021472-606676 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022 at 11:50:34AM -0700, Nadav Amit wrote: > @@ -1891,7 +1902,7 @@ static int userfaultfd_continue(struct userfaultfd_ctx *ctx, unsigned long arg) > if (mmget_not_zero(ctx->mm)) { > ret = mcopy_continue(ctx->mm, uffdio_continue.range.start, > uffdio_continue.range.len, > - &ctx->mmap_changing); > + &ctx->mmap_changing, 0); Shall we consistently use either 0 or UFFD_FLAGS_NONE? I'd go for 0 directly since that's clearer on having "nothing" as flag. > mmput(ctx->mm); > } else { > return -ESRCH; [...] > ssize_t mfill_zeropage(struct mm_struct *dst_mm, unsigned long start, > - unsigned long len, atomic_t *mmap_changing) > + unsigned long len, atomic_t *mmap_changing, > + uffd_flags_t uffd_flags) > { > return __mcopy_atomic(dst_mm, start, 0, len, MCOPY_ATOMIC_ZEROPAGE, > mmap_changing, 0); I think you agreed on passing the uffd_flags into __mcopy_atomic() (and also below). Is it forgotten or plan changed? Thanks, > } > > ssize_t mcopy_continue(struct mm_struct *dst_mm, unsigned long start, > - unsigned long len, atomic_t *mmap_changing) > + unsigned long len, atomic_t *mmap_changing, > + uffd_flags_t uffd_flags) > { > return __mcopy_atomic(dst_mm, start, 0, len, MCOPY_ATOMIC_CONTINUE, > mmap_changing, 0); > } -- Peter Xu