From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FF83CCA473 for ; Fri, 24 Jun 2022 14:36:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EFE010EA8B; Fri, 24 Jun 2022 14:36:54 +0000 (UTC) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id B444D10EA8B for ; Fri, 24 Jun 2022 14:36:53 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 058F86000F; Fri, 24 Jun 2022 14:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656081411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xDw6yLjQXYdImD1b38J6a4KT0sSwWeEKKVw++nHyiiw=; b=GBxJLAsyGFOR7YXJ3b4olBaDJSFns7lV4HmQmwrj3DjgMCKbU2icOOKzmjc+EMul1fe9jA +0If9CrUQeij0YepDQtCI7n4sW9FwarvheMa8DB0lTTyyGVTGNSFEdBkPp+5tTgidpI4Eh tzQm5LqkArdPvo+055PB17JYqLEOWfE27u2f/Ljv1i5t1Xy9hgwVuv9bRrFDj5Gsy+C2jT u1BHUrNEb+oI9BPrxMiuNUF+2Dt2kXh4O2IRZLT2c4/kIdckKcENhLcmNlVwERawDZLi7B XGz96yohFeR1z9dg6h29VIotoeGdSJFbt5jj5KESfvkxHuGXtmDtiHpPKbHz9w== Date: Fri, 24 Jun 2022 16:36:50 +0200 From: Paul Kocialkowski To: Yang Yingliang Subject: Re: [PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init() Message-ID: References: <20220614112112.1537319-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xxTdvUN19r+Gzqln" Content-Disposition: inline In-Reply-To: <20220614112112.1537319-1-yangyingliang@huawei.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --xxTdvUN19r+Gzqln Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Yang, On Tue 14 Jun 22, 19:21, Yang Yingliang wrote: > The of_node_put() need be called in error path in logicvc_layers_init(). >=20 > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller= ") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thanks for the fix! Acked-by: Paul Kocialkowski Cheers, Paul > --- > drivers/gpu/drm/logicvc/logicvc_layer.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/lo= gicvc/logicvc_layer.c > index bae1c7f99569..00a37563a6dc 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c > @@ -610,8 +610,11 @@ int logicvc_layers_init(struct logicvc_drm *logicvc) > } > =20 > ret =3D logicvc_layer_init(logicvc, layer_node, index); > - if (ret) > + if (ret) { > + of_node_put(layer_node); > + of_node_put(layers_node); > goto error; > + } > =20 > of_node_put(layer_node); > } > --=20 > 2.25.1 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --xxTdvUN19r+Gzqln Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK1zAIACgkQ3cLmz3+f v9FN7Qf+LIL1J4SHKzIrLJHuIEUfhHXkXKC8tqdNPVLJP7DFRbJyiHzqRLF0KzDd 7/X2s5prFv14Fd0/uSUB2IVz1hIdwR1cSJ5BqXC2qAuFvNqO00OGho6uOqDCUYKn Zos0vutZM/2ha2cV3JunHcooZk1Quw+qrUw6Al8aFFg088CZsVngKj3hI80QkID4 RPGJcQ25iRBQdSI7jxtyqHV47xJ3ZnQ+kTDkrkvJ/AbCs5sxPZMgyVfM+fRPuAOD F8kV0Vt7MzRp4sunrtsoDuwnsr0Il+odbx9W9z6M/VMYuV2ZIUSGOglY74JLR0aV 3ZzGDtLtSrjL0DAMu4qT5fONgxuRTA== =7SJk -----END PGP SIGNATURE----- --xxTdvUN19r+Gzqln-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC51C43334 for ; Fri, 24 Jun 2022 14:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232901AbiFXOhw (ORCPT ); Fri, 24 Jun 2022 10:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbiFXOhC (ORCPT ); Fri, 24 Jun 2022 10:37:02 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF24A563AC for ; Fri, 24 Jun 2022 07:36:53 -0700 (PDT) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 058F86000F; Fri, 24 Jun 2022 14:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656081411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xDw6yLjQXYdImD1b38J6a4KT0sSwWeEKKVw++nHyiiw=; b=GBxJLAsyGFOR7YXJ3b4olBaDJSFns7lV4HmQmwrj3DjgMCKbU2icOOKzmjc+EMul1fe9jA +0If9CrUQeij0YepDQtCI7n4sW9FwarvheMa8DB0lTTyyGVTGNSFEdBkPp+5tTgidpI4Eh tzQm5LqkArdPvo+055PB17JYqLEOWfE27u2f/Ljv1i5t1Xy9hgwVuv9bRrFDj5Gsy+C2jT u1BHUrNEb+oI9BPrxMiuNUF+2Dt2kXh4O2IRZLT2c4/kIdckKcENhLcmNlVwERawDZLi7B XGz96yohFeR1z9dg6h29VIotoeGdSJFbt5jj5KESfvkxHuGXtmDtiHpPKbHz9w== Date: Fri, 24 Jun 2022 16:36:50 +0200 From: Paul Kocialkowski To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel@ffwll.ch, mripard@kernel.org Subject: Re: [PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init() Message-ID: References: <20220614112112.1537319-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xxTdvUN19r+Gzqln" Content-Disposition: inline In-Reply-To: <20220614112112.1537319-1-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xxTdvUN19r+Gzqln Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Yang, On Tue 14 Jun 22, 19:21, Yang Yingliang wrote: > The of_node_put() need be called in error path in logicvc_layers_init(). >=20 > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller= ") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thanks for the fix! Acked-by: Paul Kocialkowski Cheers, Paul > --- > drivers/gpu/drm/logicvc/logicvc_layer.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/lo= gicvc/logicvc_layer.c > index bae1c7f99569..00a37563a6dc 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c > @@ -610,8 +610,11 @@ int logicvc_layers_init(struct logicvc_drm *logicvc) > } > =20 > ret =3D logicvc_layer_init(logicvc, layer_node, index); > - if (ret) > + if (ret) { > + of_node_put(layer_node); > + of_node_put(layers_node); > goto error; > + } > =20 > of_node_put(layer_node); > } > --=20 > 2.25.1 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --xxTdvUN19r+Gzqln Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK1zAIACgkQ3cLmz3+f v9FN7Qf+LIL1J4SHKzIrLJHuIEUfhHXkXKC8tqdNPVLJP7DFRbJyiHzqRLF0KzDd 7/X2s5prFv14Fd0/uSUB2IVz1hIdwR1cSJ5BqXC2qAuFvNqO00OGho6uOqDCUYKn Zos0vutZM/2ha2cV3JunHcooZk1Quw+qrUw6Al8aFFg088CZsVngKj3hI80QkID4 RPGJcQ25iRBQdSI7jxtyqHV47xJ3ZnQ+kTDkrkvJ/AbCs5sxPZMgyVfM+fRPuAOD F8kV0Vt7MzRp4sunrtsoDuwnsr0Il+odbx9W9z6M/VMYuV2ZIUSGOglY74JLR0aV 3ZzGDtLtSrjL0DAMu4qT5fONgxuRTA== =7SJk -----END PGP SIGNATURE----- --xxTdvUN19r+Gzqln--