Re: [PATCH v2 6/8] fs: remove no_llseek

From: Christoph Hellwig <hch@infradead.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
	Jens Axboe <axboe@kernel.dk>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] fs: remove no_llseek
Date: Sat, 25 Jun 2022 06:10:02 -0700	[thread overview]
Message-ID: <YrcJKtZQLDvRgX7P@infradead.org> (raw)
In-Reply-To: <20220625110115.39956-7-Jason@zx2c4.com>

On Sat, Jun 25, 2022 at 01:01:13PM +0200, Jason A. Donenfeld wrote:
> Now that all callers of ->llseek are going through vfs_llseek(), we
> don't gain anything by keeping no_llseek around. Nothing compares it or
> calls it.

Shouldn't this and the checks for no_llseek simply be merged into patch
2?

> +	if ((file->f_mode & FMODE_LSEEK) && file->f_op->llseek)
> +		return file->f_op->llseek(file, offset, whence);
> +	return -ESPIPE;

No function change, but in general checking for the error condition
in the branch tends to be more readable.  i.e.:

	if (!(file->f_mode & FMODE_LSEEK) || !file->f_op->llseek)
		return -ESPIPE;
	return file->f_op->llseek(file, offset, whence);