From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 071517C for ; Sat, 25 Jun 2022 14:24:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 161ABC3411C; Sat, 25 Jun 2022 14:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656167043; bh=DaVURzrOH5h1D0JiTA3enJZHN2QsAdolonR8vVq6jXs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RuOYMNCR+DLojIQVmZvrx3TkwCdcKmgJCDZB2RtzXBiBQ0Rz0brn+XJ58DCUqmnzX twXof/3PPAl7O/BEPTGcALg5FoA3kKVMRtncQA9jsXmN0U41lSCIIrpMUF6VdMQfyS 0ZjBz63gOxZzvPEjFQ3FklJOfa3J+YlRBk4/saB8= Date: Sat, 25 Jun 2022 16:24:00 +0200 From: Greg KH To: Huacai Chen Cc: Muchun Song , Feiyang Chen , Andrew Morton , Matthew Wilcox , Vlastimil Babka , Feiyang Chen , loongarch@lists.linux.dev, LKML , linux- stable Subject: Re: [External] Re: [PATCH] page-flags.h: Fix a missing header include of static_keys.h Message-ID: References: <20220625080423.2797-1-chenfeiyang@loongson.cn> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jun 25, 2022 at 10:17:36PM +0800, Huacai Chen wrote: > Hi, Greg, > > On Sat, Jun 25, 2022 at 10:07 PM Greg KH wrote: > > > > On Sat, Jun 25, 2022 at 10:00:43PM +0800, Huacai Chen wrote: > > > Hi, Muchun, > > > > > > On Sat, Jun 25, 2022 at 7:17 PM Muchun Song wrote: > > > > > > > > On Sat, Jun 25, 2022 at 5:04 PM Huacai Chen wrote: > > > > > > > > > > Hi, Muchun, > > > > > > > > > > On Sat, Jun 25, 2022 at 4:50 PM Muchun Song wrote: > > > > > > > > > > > > On Sat, Jun 25, 2022 at 4:04 PM Feiyang Chen > > > > > > wrote: > > > > > > > > > > > > > > The page-flags.h header relies on static keys since commit > > > > > > > a6b40850c442bf ("mm: hugetlb: replace hugetlb_free_vmemmap_enabled > > > > > > > with a static_key"), so make sure to include the header to avoid > > > > > > > compilation errors. > > > > > > > > > > > > > > Fixes: a6b40850c442bf ("mm: hugetlb: replace hugetlb_free_vmemmap_enabled with a static_key") > > > > > > > Cc: stable@vger.kernel.org > > > > > > > Signed-off-by: Feiyang Chen > > > > > > > --- > > > > > > > include/linux/page-flags.h | 1 + > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > > > > > > index e66f7aa3191d..147b336c7a35 100644 > > > > > > > --- a/include/linux/page-flags.h > > > > > > > +++ b/include/linux/page-flags.h > > > > > > > @@ -11,6 +11,7 @@ > > > > > > > #include > > > > > > > #ifndef __GENERATING_BOUNDS_H > > > > > > > #include > > > > > > > +#include > > > > > > > > > > > > I did not include this. The change makes sense to me. But I am > > > > > > curious what configs cause the compiling error. Would you mind > > > > > > sharing the config with us? > > > > > We found this problem when we add > > > > > ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP to LoongArch. Since this isn't > > > > > > > > Good news to me. I would love to hear more archs support for HVO (HugeTLB > > > > Vmemmap Optimization). > > > > > > > > > upstream yet, we cannot give such a config now (the default config of > > > > > X86 and ARM64 is just OK). > > > > > > > > All right. In this case, the "Cc: stable@vger.kernel.org" is unnecessary. > > > Maybe make randconfig will have problems on X86/ARM64, so backporting > > > to 5.18 seems reasonable. > > > > Unless it is proven to be needed, there is no need to backport it. > OK, we will try "make randconfig". And if it isn't needed, should we > send V2 to remove Cc stable? If it isn't needed now, no need to send it at all. Only submit it when there is a patch that requires it. thanks, greg k-h