From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B8AC43334 for ; Sun, 26 Jun 2022 10:37:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234285AbiFZKhm (ORCPT ); Sun, 26 Jun 2022 06:37:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234274AbiFZKhf (ORCPT ); Sun, 26 Jun 2022 06:37:35 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C227412A81 for ; Sun, 26 Jun 2022 03:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656239853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H7HVasmdGjZh7uUQx0GtaFkNCVtXnNgnA6arKmEYZtk=; b=XVQ1BrQM0qdZUiTwi7qw8PLIRz94qa2IraU+Yntha1EOVqEYjeS3zpdyfgf2oKciMWflLb WDCCLXU5aw1pKarXGvwA7BdcEL/tDgF4qAASPuDEhN+m0JPtzBAF2aViyCidkOkg28ltJi DZrcak5gUGoGHR5FwoJ6xYDhBBaABHQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-PCA8g8ZAN6aS5k01qunvYg-1; Sun, 26 Jun 2022 06:37:29 -0400 X-MC-Unique: PCA8g8ZAN6aS5k01qunvYg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF35D381079B; Sun, 26 Jun 2022 10:37:28 +0000 (UTC) Received: from localhost (ovpn-12-101.pek2.redhat.com [10.72.12.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B09D841616B; Sun, 26 Jun 2022 10:37:27 +0000 (UTC) Date: Sun, 26 Jun 2022 18:37:24 +0800 From: Baoquan He To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-rt-users@vger.kernel.org, Eric Biederman , Arnd Bergmann , Petr Mladek , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , "Luis Claudio R. Goncalves" Subject: Re: [PATCH v2] panic, kexec: Make __crash_kexec() NMI safe Message-ID: References: <20220620111520.1039685-1-vschneid@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/24/22 at 02:37pm, Valentin Schneider wrote: > On 24/06/22 09:30, Baoquan He wrote: > > On 06/20/22 at 12:15pm, Valentin Schneider wrote: > >> @@ -94,14 +94,20 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, > >> /* > >> * Because we write directly to the reserved memory region when loading > >> * crash kernels we need a mutex here to prevent multiple crash kernels > >> - * from attempting to load simultaneously, and to prevent a crash kernel > >> - * from loading over the top of a in use crash kernel. > >> - * > >> - * KISS: always take the mutex. > >> + * from attempting to load simultaneously. > >> */ > >> if (!mutex_trylock(&kexec_mutex)) > >> return -EBUSY; > > > > So kexec_mutex is degenerated to only avoid simultaneous loading, > > should we rename to reflect that?, e.g kexec_load_mutex. > > > > It's also serializing crash_get_memory_size() and crash_shrink_memory(); > more generally it should still be the preferred serialization mechanism as > it's a "proper" lock visible by instrumentation, the atomic variable is a > side character for the NMI case. You are right. I only checked the code comment in this place. Then this patch looks good to me, thx. Acked-by: Baoquan He From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F5F7C433EF for ; Sun, 26 Jun 2022 10:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h7WhHrhZexY0AizSBlNvCDWyQdZEVg8fDanBCSmzhSQ=; b=llLy6KgzywQ412 OXsA0bZGtqrJWyr5SG91aUgjCp0BXmRbJlZkT+2d9lQC1+segMm+ygei6bF84mqZi7B6+bH9zPBBW y8SX/qK4wAdAEYo4Yo7pOrSz6rPXsFEZJdQ4GFOzk/RxUx50JNC4sTouGI/GRhAcqZeEzLbM1bKkc gpg8rpKEJugAy/QvFpAA9QqNy8rJHwXFCqezeex36RPiv+Wg0UBOFelPxCzOG9BxAJMtIW/eRxKC3 oy+E/wi9SQQ3DFis6QWfb++hOsZsfCJSGO7uVUszB6DCCn2wx01tiSrvVaOXH9u6FaRrweEIRIS4q dHVsVeNy3AUjLnLkTZQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Pe7-00BDJf-6f; Sun, 26 Jun 2022 10:37:39 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Pe4-00BDFC-KM for kexec@lists.infradead.org; Sun, 26 Jun 2022 10:37:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656239853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H7HVasmdGjZh7uUQx0GtaFkNCVtXnNgnA6arKmEYZtk=; b=XVQ1BrQM0qdZUiTwi7qw8PLIRz94qa2IraU+Yntha1EOVqEYjeS3zpdyfgf2oKciMWflLb WDCCLXU5aw1pKarXGvwA7BdcEL/tDgF4qAASPuDEhN+m0JPtzBAF2aViyCidkOkg28ltJi DZrcak5gUGoGHR5FwoJ6xYDhBBaABHQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-PCA8g8ZAN6aS5k01qunvYg-1; Sun, 26 Jun 2022 06:37:29 -0400 X-MC-Unique: PCA8g8ZAN6aS5k01qunvYg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF35D381079B; Sun, 26 Jun 2022 10:37:28 +0000 (UTC) Received: from localhost (ovpn-12-101.pek2.redhat.com [10.72.12.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B09D841616B; Sun, 26 Jun 2022 10:37:27 +0000 (UTC) Date: Sun, 26 Jun 2022 18:37:24 +0800 From: Baoquan He To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-rt-users@vger.kernel.org, Eric Biederman , Arnd Bergmann , Petr Mladek , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , "Luis Claudio R. Goncalves" Subject: Re: [PATCH v2] panic, kexec: Make __crash_kexec() NMI safe Message-ID: References: <20220620111520.1039685-1-vschneid@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_033736_793833_305D64BB X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 06/24/22 at 02:37pm, Valentin Schneider wrote: > On 24/06/22 09:30, Baoquan He wrote: > > On 06/20/22 at 12:15pm, Valentin Schneider wrote: > >> @@ -94,14 +94,20 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, > >> /* > >> * Because we write directly to the reserved memory region when loading > >> * crash kernels we need a mutex here to prevent multiple crash kernels > >> - * from attempting to load simultaneously, and to prevent a crash kernel > >> - * from loading over the top of a in use crash kernel. > >> - * > >> - * KISS: always take the mutex. > >> + * from attempting to load simultaneously. > >> */ > >> if (!mutex_trylock(&kexec_mutex)) > >> return -EBUSY; > > > > So kexec_mutex is degenerated to only avoid simultaneous loading, > > should we rename to reflect that?, e.g kexec_load_mutex. > > > > It's also serializing crash_get_memory_size() and crash_shrink_memory(); > more generally it should still be the preferred serialization mechanism as > it's a "proper" lock visible by instrumentation, the atomic variable is a > side character for the NMI case. You are right. I only checked the code comment in this place. Then this patch looks good to me, thx. Acked-by: Baoquan He _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec