From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F8ADC43334 for ; Sun, 26 Jun 2022 23:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbiFZXM6 (ORCPT ); Sun, 26 Jun 2022 19:12:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiFZXM5 (ORCPT ); Sun, 26 Jun 2022 19:12:57 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB38BDDD for ; Sun, 26 Jun 2022 16:12:56 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CDA047C; Mon, 27 Jun 2022 01:12:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656285174; bh=Hv5AjOEyR78pg0Y+z/Kx5UCz2H4mLTAiPmz1ewvHciw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lk5djvyrmcYPdbymW9GNpVrm5D77Tz2Oi7y5UfwaA3dJf0PyjkSRW68rwXAC4BxXA /7WXgjAUdqNBvAuyuok2Osk9UjIR236QNn75wCwAJs6LBkdLuTA/WODmOX2+P1Gcx3 6jgTKZL95ssxPe7Ajkmy4+/gE7SL/E4hit48M9G8= Date: Mon, 27 Jun 2022 02:12:36 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Harsha Manjula Mallikarjun , kieran@ksquared.org.uk, kieran@ksquared.org.uk, "linux-renesas-soc@vger.kernel.org" , Friedrich Eugen , Rajendraprasad Karammel Jayakumar , Nguyen Trong Vinh Subject: Re: RCAR CMM : features and improvements Message-ID: References: <165607346815.1149771.3928519467340826398@Monstersaurus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <165607346815.1149771.3928519467340826398@Monstersaurus> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello, On Fri, Jun 24, 2022 at 01:24:28PM +0100, Kieran Bingham wrote: > Quoting Harsha Manjula Mallikarjun (MS/ECF3-XC) (2022-06-24 10:18:14) > > Hi Kieran, Hi Laurent, > > > > We are planning to put some efforts to improve and add, on top of the > > RCAR CMM patches[1] and upstream them. Following are the > > add-ons/improvements planned. If there are some activities with > > respect RCAR CMM, are ongoing already in upstream, we are happy to be > > involved in it and can spare efforts. > > > > 1. Double buffering support for CLU, LUT tables. > > > 2. Add worker thread in rcar_cmm to apply the table settings. To apply > > the CLU settings time taken is around ~7ms. This looks a bit high and > > more importantly it just blocks the compositor. > > > 3. With the patches[1] I see that CLU settings are written to > > registers but, the display does not show any change. Also, I see a > > short freeze on the display. This needs to be resolved. > > > > Also we have some patches for weston drm-backend which can set the > > 3DLUT, but they could not be up-streamed because drm object properties > > "CUBIC_LUT" and "CUBIC_LUT_SIZE" are not the standard ones yet. > > Reading [2], I think one of the blockers to getting [1] merged was the > lack of such an implementation to userspace. So I think if you were able > to share/post that - it would help unblock the upstreaming. Even if the patches can't be upstreamed in Weston yet, posting them as RFC to show how the new DRM properties are used would be extremely helpful to get the kernel side merged. > Your results above warrant further investigation though, as indeed 7ms > to set some registers sounds quite high, even if it is a large table, > and even more so if they are not taking effect. > > > [1]: https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=404647 > [2]: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20201221015730.28333-4-laurent.pinchart+renesas@ideasonboard.com/ -- Regards, Laurent Pinchart