From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E9BC43334 for ; Sun, 26 Jun 2022 23:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbiFZXcp (ORCPT ); Sun, 26 Jun 2022 19:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbiFZXco (ORCPT ); Sun, 26 Jun 2022 19:32:44 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB3672BEC; Sun, 26 Jun 2022 16:32:43 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EF44C47C; Mon, 27 Jun 2022 01:32:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656286362; bh=mf04BO1qSQaOvy22fBoJ2iokU5ZzrFY1ylZMqc/12T8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P2FEhP4ItuGMiJEABMqL16fngg9viF0DD6QgcFqW/3QV+UUqxwzWsW4QpANr8HcU2 QEwyMIp24n9o1Lw7Y/Vp9oygBRp8rTuDfpw/+QgELpEgglf71mneUoMc5e6qCBGKSB iGZxWRLqYQugxnBXRbJp86B4yS3P4bk6V/CK2jS4= Date: Mon, 27 Jun 2022 02:32:24 +0300 From: Laurent Pinchart To: Jiang Jian Cc: mchehab@kernel.org, hyun.kwon@xilinx.com, michal.simek@xilinx.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: xilinx: drop unexpected word 'with' in comments Message-ID: References: <20220623122948.54839-1-jiangjian@cdjrlc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220623122948.54839-1-jiangjian@cdjrlc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiang, Thank you for the patch. On Thu, Jun 23, 2022 at 08:29:48PM +0800, Jiang Jian wrote: > there is an unexpected word 'with' in the comments that need to be dropped > > file - drivers/media/platform/xilinx/xilinx-vip.h > line -31 > > * Pad IDs. IP cores with with multiple inputs or outputs should define > > changed to: > > * Pad IDs. IP cores with multiple inputs or outputs should define The first line of the commit message is enough, the rest duplicates the content of the patch. No need to resubmit, I'll fix this when applying. Reviewed-by: Laurent Pinchart > Signed-off-by: Jiang Jian > --- > drivers/media/platform/xilinx/xilinx-vip.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/xilinx/xilinx-vip.h b/drivers/media/platform/xilinx/xilinx-vip.h > index d0b0e0600952..1c8dd59067fe 100644 > --- a/drivers/media/platform/xilinx/xilinx-vip.h > +++ b/drivers/media/platform/xilinx/xilinx-vip.h > @@ -28,7 +28,7 @@ struct clk; > #define XVIP_MAX_HEIGHT 7680 > > /* > - * Pad IDs. IP cores with with multiple inputs or outputs should define > + * Pad IDs. IP cores with multiple inputs or outputs should define > * their own values. > */ > #define XVIP_PAD_SINK 0 -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27145C43334 for ; Sun, 26 Jun 2022 23:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AR1sb0PM4Cp72wOluvQLovbNqY5CUc/oANvFiMAZDbo=; b=zyY8RYxMYnePew rCcjleWh+WL2MzfXElDrvpAjA6t+OTa3mIl3foTIM+KZ+jbKDXDX0yKNduvQ9b7RnUBs2AyWkWSR4 opNpDS6QcFD5IdQfc9AzuRjiC7J1aPvWJp10EWrPwT6twpNwrkmqm3HUqPU2GAKMUfzUtxOh4FOIu xn3vbTk4Caiqby7HJ7tOpY40qUR7gFIOM9b+e/3+PkfAIZ81TcARDH7cOwRHt29SssQQdNP3wxUyt 9jTkknMs+vNXWwMIQt/jKPmqjF2Ovlq44f6b5flIJ0TQ73FXofqGSFUXGY432Y+d7r1TJNVtYz52x GBrNg6RbZd8Nz1uBQ2Gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5bkO-00E6Fc-2G; Sun, 26 Jun 2022 23:32:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5bkL-00E6Cc-JW for linux-arm-kernel@lists.infradead.org; Sun, 26 Jun 2022 23:32:54 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EF44C47C; Mon, 27 Jun 2022 01:32:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656286362; bh=mf04BO1qSQaOvy22fBoJ2iokU5ZzrFY1ylZMqc/12T8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P2FEhP4ItuGMiJEABMqL16fngg9viF0DD6QgcFqW/3QV+UUqxwzWsW4QpANr8HcU2 QEwyMIp24n9o1Lw7Y/Vp9oygBRp8rTuDfpw/+QgELpEgglf71mneUoMc5e6qCBGKSB iGZxWRLqYQugxnBXRbJp86B4yS3P4bk6V/CK2jS4= Date: Mon, 27 Jun 2022 02:32:24 +0300 From: Laurent Pinchart To: Jiang Jian Cc: mchehab@kernel.org, hyun.kwon@xilinx.com, michal.simek@xilinx.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: xilinx: drop unexpected word 'with' in comments Message-ID: References: <20220623122948.54839-1-jiangjian@cdjrlc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220623122948.54839-1-jiangjian@cdjrlc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_163253_820531_F5BBEF66 X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jiang, Thank you for the patch. On Thu, Jun 23, 2022 at 08:29:48PM +0800, Jiang Jian wrote: > there is an unexpected word 'with' in the comments that need to be dropped > > file - drivers/media/platform/xilinx/xilinx-vip.h > line -31 > > * Pad IDs. IP cores with with multiple inputs or outputs should define > > changed to: > > * Pad IDs. IP cores with multiple inputs or outputs should define The first line of the commit message is enough, the rest duplicates the content of the patch. No need to resubmit, I'll fix this when applying. Reviewed-by: Laurent Pinchart > Signed-off-by: Jiang Jian > --- > drivers/media/platform/xilinx/xilinx-vip.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/xilinx/xilinx-vip.h b/drivers/media/platform/xilinx/xilinx-vip.h > index d0b0e0600952..1c8dd59067fe 100644 > --- a/drivers/media/platform/xilinx/xilinx-vip.h > +++ b/drivers/media/platform/xilinx/xilinx-vip.h > @@ -28,7 +28,7 @@ struct clk; > #define XVIP_MAX_HEIGHT 7680 > > /* > - * Pad IDs. IP cores with with multiple inputs or outputs should define > + * Pad IDs. IP cores with multiple inputs or outputs should define > * their own values. > */ > #define XVIP_PAD_SINK 0 -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel