From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB32CCA473 for ; Mon, 27 Jun 2022 09:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233518AbiF0JIk (ORCPT ); Mon, 27 Jun 2022 05:08:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233481AbiF0JIh (ORCPT ); Mon, 27 Jun 2022 05:08:37 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBEC3B58 for ; Mon, 27 Jun 2022 02:08:35 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id cw10so17754532ejb.3 for ; Mon, 27 Jun 2022 02:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=k1e7Wwe1AjCbXe7sromgO+mILN6P9Y2vdSpGp2oCkCk=; b=b8qCSWEOKka9s84N0wcEJ/GTZwusewGy5IsaK2F9Q4UFzB6+y+8ozRjXh89hAvLlMU K12dt4t2k478igf5w1imCsx/nqsNQMxOs1sQIJ30nQnGe+id+s6HkddlqiCTvSHJSysA 9g99nL0Wk1M/DhvRrpm4pO91F74cEKsE6GmoE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=k1e7Wwe1AjCbXe7sromgO+mILN6P9Y2vdSpGp2oCkCk=; b=nt8MoRvYvOMZXH4s9ouvPN4NYOOPCvip8mqYQYyqYQ8a0vOLLyNVAYkCG2uCNk3XQg ihH+ZKFd/015iGmHkNi33RGRTKNZ37UE0iRbA6w2zvBdLVCWwdGksfzIfYgTWhn2pHjE +wgnCAvQ1ZpmVNmh0V/r4GXgtct3XneXy679AkuK3JBW3n6RA8bJ4TeOEuktL4av9zx2 IRSZdocxX+gst6V5YLG5zaxNdjdnd02MzXgpsnzdCDPp6SzfqxJmQm/lFAL5BNjyI+vF PZX/peOMHTNCt1wkEoIUNFBygDS8DMPdNHXcf59+dEznCsqh52u2UEr4Mt1kFC7nXY4X 3bAw== X-Gm-Message-State: AJIora+5u5Y7U5KfiDyLM1UzCQHm2iNOJhdU/BT/RzO9yl04s+90ntOq BM61xDRICP9un1be7H86HOJlNA== X-Google-Smtp-Source: AGRyM1vFhPN1meHKKImI2keGZpwl6qEWNsZwQgQPLYnEouybFA2jLTjk/b7ksAjiA+H1CLyv+UeX1w== X-Received: by 2002:a17:907:7811:b0:6ef:a896:b407 with SMTP id la17-20020a170907781100b006efa896b407mr11583984ejc.645.1656320914396; Mon, 27 Jun 2022 02:08:34 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b7-20020a50e787000000b0042ab4e20543sm7225848edn.48.2022.06.27.02.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 02:08:33 -0700 (PDT) Date: Mon, 27 Jun 2022 11:08:32 +0200 From: Daniel Vetter To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, Jens Axboe , linux-fsdevel@vger.kernel.org, Sumit Semwal , dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag Message-ID: Mail-Followup-To: "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, Jens Axboe , linux-fsdevel@vger.kernel.org, Sumit Semwal , dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= References: <20220625110115.39956-1-Jason@zx2c4.com> <20220625110115.39956-8-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220625110115.39956-8-Jason@zx2c4.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > This is already set by anon_inode_getfile(), since dma_buf_fops has > non-NULL ->llseek, so we don't need to set it here too. > > Suggested-by: Al Viro > Cc: Sumit Semwal > Cc: Christian König > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jason A. Donenfeld I'm assuming this is part of a vfs cleanup and lands through that tree? For that: Acked-by: Daniel Vetter > --- > drivers/dma-buf/dma-buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 32f55640890c..3f08e0b960ec 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > goto err_dmabuf; > } > > - file->f_mode |= FMODE_LSEEK; > dmabuf->file = file; > > mutex_init(&dmabuf->lock); > -- > 2.35.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40BFBCCA473 for ; Mon, 27 Jun 2022 09:08:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6789111A3E0; Mon, 27 Jun 2022 09:08:37 +0000 (UTC) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2F4D11A3DA for ; Mon, 27 Jun 2022 09:08:35 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id ay16so17740445ejb.6 for ; Mon, 27 Jun 2022 02:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=k1e7Wwe1AjCbXe7sromgO+mILN6P9Y2vdSpGp2oCkCk=; b=b8qCSWEOKka9s84N0wcEJ/GTZwusewGy5IsaK2F9Q4UFzB6+y+8ozRjXh89hAvLlMU K12dt4t2k478igf5w1imCsx/nqsNQMxOs1sQIJ30nQnGe+id+s6HkddlqiCTvSHJSysA 9g99nL0Wk1M/DhvRrpm4pO91F74cEKsE6GmoE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=k1e7Wwe1AjCbXe7sromgO+mILN6P9Y2vdSpGp2oCkCk=; b=N32gAp1rxyd1NJS/KNgNVripwuWVI2J+KjbUM3UCC+c+rAtlZrlRhvs55tQFyrP8Cx IfYE/+QyRDgsjXOwryMd69Tt8DmtipVid4QuyISf6rT8dXc+zb76k0bMrZW96TAqjEOd FxMLx72d0AMHW+hOvK36Zp0xsCgzg+3R45LRGSKKBTixhyjqr2flN51wUalUsI1xrtfE P/S6QjWR6pwjr/aUnIlSRukvGfawNefUSGwJ4kinAfW24E8v5z8K9/wW5UKf4cO9Mmwj FyZONP0x2RMN+GtFdMJjYZzJ6jhIlNiD4guvwF8Z4L0pAF/44ByKdIAuGsuS5BLYu7QJ Je1A== X-Gm-Message-State: AJIora83Pfqjnah3kSrb3msC4bEbUcG4NI9P4ZGm5u/UlLOfRlN7cobF vTTTqRh2l5HENwkJEN6ceDjVPQ== X-Google-Smtp-Source: AGRyM1vFhPN1meHKKImI2keGZpwl6qEWNsZwQgQPLYnEouybFA2jLTjk/b7ksAjiA+H1CLyv+UeX1w== X-Received: by 2002:a17:907:7811:b0:6ef:a896:b407 with SMTP id la17-20020a170907781100b006efa896b407mr11583984ejc.645.1656320914396; Mon, 27 Jun 2022 02:08:34 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b7-20020a50e787000000b0042ab4e20543sm7225848edn.48.2022.06.27.02.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 02:08:33 -0700 (PDT) Date: Mon, 27 Jun 2022 11:08:32 +0200 From: Daniel Vetter To: "Jason A. Donenfeld" Subject: Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag Message-ID: Mail-Followup-To: "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, Jens Axboe , linux-fsdevel@vger.kernel.org, Sumit Semwal , dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= References: <20220625110115.39956-1-Jason@zx2c4.com> <20220625110115.39956-8-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220625110115.39956-8-Jason@zx2c4.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Sumit Semwal Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > This is already set by anon_inode_getfile(), since dma_buf_fops has > non-NULL ->llseek, so we don't need to set it here too. > > Suggested-by: Al Viro > Cc: Sumit Semwal > Cc: Christian König > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jason A. Donenfeld I'm assuming this is part of a vfs cleanup and lands through that tree? For that: Acked-by: Daniel Vetter > --- > drivers/dma-buf/dma-buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 32f55640890c..3f08e0b960ec 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > goto err_dmabuf; > } > > - file->f_mode |= FMODE_LSEEK; > dmabuf->file = file; > > mutex_init(&dmabuf->lock); > -- > 2.35.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch