All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xin Ji <xji@analogixsemi.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	bliang@analogixsemi.com, qwen@analogixsemi.com,
	jli@analogixsemi.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411 support
Date: Tue, 28 Jun 2022 08:19:16 +0200	[thread overview]
Message-ID: <YrqdZE7IfKYZHkCu@kroah.com> (raw)
In-Reply-To: <20220628044843.2257885-3-xji@analogixsemi.com>

On Tue, Jun 28, 2022 at 12:48:42PM +0800, Xin Ji wrote:
> Add driver for analogix ANX7411 USB Type-C DRP port controller.
> 
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> V11 -> V12 : Fix Greg Kroah-Hartman's comment

Which comment?  This is very vague, it's almost like "made changes".

We need specifics here, otherwise it's impossible to review.  Would you
want to see this as a changelog statement for something you spent time
in reviewing?

Also, your changelog itself needs more text, as to what type of device
this is and more information about it if possible.

thanks,

greg k-h

  reply	other threads:[~2022-06-28  6:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28  4:48 [PATCH v12 1/3] usb: typec: tcpci: move tcpci.h to include/linux/usb/ Xin Ji
2022-06-28  4:48 ` Xin Ji
2022-06-28  4:48 ` [PATCH v12 2/3] dt-bindings: usb: Add analogix anx7411 PD binding Xin Ji
2022-06-29 10:12   ` Krzysztof Kozlowski
2022-07-05  2:53     ` Xin Ji
2022-06-28  4:48 ` [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411 support Xin Ji
2022-06-28  6:19   ` Greg Kroah-Hartman [this message]
2022-06-28  6:26   ` Greg Kroah-Hartman
2022-07-05  2:55     ` Xin Ji
2022-06-28 10:48   ` Heikki Krogerus
2022-07-05  2:57     ` Xin Ji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrqdZE7IfKYZHkCu@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bliang@analogixsemi.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jli@analogixsemi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=qwen@analogixsemi.com \
    --cc=xji@analogixsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.