From: Klaus Jensen <its@irrelevant.dk>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
kbusch@kernel.org, qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/nvme: fix example serial in documentation
Date: Tue, 28 Jun 2022 14:31:26 +0200 [thread overview]
Message-ID: <Yrr0nrBdh6Qz4c/E@apples> (raw)
In-Reply-To: <YrrzcdBRJ2pe2bcb@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
On Jun 28 13:26, Daniel P. Berrangé wrote:
> On Mon, Jun 27, 2022 at 02:39:57PM +0200, Niklas Cassel via wrote:
> > The serial prop on the controller is actually describing the nvme
> > subsystem serial, which has to be identical for all controllers within
> > the same nvme subsystem.
>
> Given this description...
>
> >
> > -device nvme-subsys,id=nvme-subsys-0,nqn=subsys0
>
> ...I'm wondering why 'serial' isn't a property of this device..
>
> > - -device nvme,serial=a,subsys=nvme-subsys-0
> > - -device nvme,serial=b,subsys=nvme-subsys-0
> > + -device nvme,serial=deadbeef,subsys=nvme-subsys-0
> > + -device nvme,serial=deadbeef,subsys=nvme-subsys-0
>
> ..rather than requiring it to be redundantly set to the same value here ?
>
-device nvme can be used without a subsystem device, and in that case
the serial must be set. However, you are right that we could not require
it if set on the subsystem device.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-06-28 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 12:39 [PATCH] hw/nvme: fix example serial in documentation Niklas Cassel via
2022-06-27 17:11 ` Klaus Jensen
2022-06-28 12:26 ` Daniel P. Berrangé
2022-06-28 12:31 ` Klaus Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrr0nrBdh6Qz4c/E@apples \
--to=its@irrelevant.dk \
--cc=berrange@redhat.com \
--cc=kbusch@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.