From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E88A611A2B8 for ; Tue, 28 Jun 2022 17:18:52 +0000 (UTC) Date: Tue, 28 Jun 2022 19:18:48 +0200 From: Kamil Konieczny To: igt-dev@lists.freedesktop.org Message-ID: References: <20220626180750.23747-1-sai.gowtham.ch@intel.com> <20220626180750.23747-2-sai.gowtham.ch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220626180750.23747-2-sai.gowtham.ch@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Gowtham Ch Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Sai, On 2022-06-26 at 23:37:49 +0530, sai.gowtham.ch@intel.com wrote: > From: Sai Gowtham Ch > > Added test description for test and to all the subtests that are > available. > > Cc: Kamil Konieczny > Signed-off-by: Sai Gowtham Ch > --- > tests/i915/gem_softpin.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c > index b851c90e..ce62a584 100644 > --- a/tests/i915/gem_softpin.c > +++ b/tests/i915/gem_softpin.c > @@ -32,6 +32,10 @@ > #include "igt_rand.h" > #include "intel_allocator.h" > > +IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs" > + " scenarios and couple of eviction tests which copy buffers" > + " between CPU and GPU."); > + > #define EXEC_OBJECT_PINNED (1<<4) > #define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3) > > @@ -1248,6 +1252,7 @@ igt_main > ctx = intel_ctx_create_all_physical(fd); > } > > + igt_describe("Check that invalid inputs are handled correctly."); > igt_subtest("invalid") > test_invalid(fd); > > @@ -1258,30 +1263,44 @@ igt_main > igt_require(gem_uses_full_ppgtt(fd)); > } > > + igt_describe("Check full placement control under full-ppGTT."); > igt_subtest("zero") > test_zero(fd); > > + igt_describe("Check the last 32b page is excluded."); > igt_subtest("32b-excludes-last-page") > test_32b_last_page(fd); > > + igt_describe("Check the total occupancy by using pad-to-size to fill" > + " the entire GTT."); > igt_subtest("full") > test_full(fd); > > + igt_describe("Check that we can place objects at start/end of the GTT" > + " using the allocator."); > igt_subtest("allocator-basic") > test_allocator_basic(fd, false); > > + igt_describe("Check that if we can reserve a space for an object" > + " starting from a given offset."); > igt_subtest("allocator-basic-reserve") > test_allocator_basic(fd, true); > > + igt_describe("Check that we can combine manual placement with automatic" > + " GTT placement."); > igt_subtest("allocator-nopin") > test_allocator_nopin(fd, false); > > + igt_describe("Check that we can combine manual placement with automatic" > + " GTT placement and reserves/unreserves space for objects."); > igt_subtest("allocator-nopin-reserve") > test_allocator_nopin(fd, true); > > + igt_describe("Check if multiple processes can use alloctor."); > igt_subtest("allocator-fork") > test_allocator_fork(fd); > > + igt_describe("Exercise eviction with softpinning."); > test_each_engine("allocator-evict", fd, ctx, e) > test_allocator_evict(fd, ctx, e->flags, 20); > > @@ -1294,28 +1313,45 @@ igt_main > igt_subtest("safe-alignment") > safe_alignment(fd); > > + igt_describe("Check softpinning of a gem buffer object."); > igt_subtest("softpin") > test_softpin(fd); > + > + igt_describe("Check all the possible pages aligned overlaps."); > igt_subtest("overlap") > test_overlap(fd); > + > + igt_describe("Check that if the user demands the vma be swapped."); ----------------------------------------------------------- ^ s/vma be/vma will be/ > igt_subtest("reverse") > test_reverse(fd); > > + igt_describe("Check that no relocs support works."); -------------------------------- ^--^ Hmm, please make it noreloc here (sorry if I wrote otherwise before). > igt_subtest("noreloc") > test_noreloc(fd, NOSLEEP, 0); > + > + igt_describe("Check no relocs support with interruptible."); --------------------------- ^--^ Same here. > igt_subtest("noreloc-interruptible") > test_noreloc(fd, NOSLEEP, INTERRUPTIBLE); > + > + igt_describe("Check norelocs survives after suspend to RAM/resume cycle."); s/norelocs/noreloc/ > igt_subtest("noreloc-S3") > test_noreloc(fd, SUSPEND, 0); > + > + igt_describe("Check norelocs survives after suspend to disk/resume cycle."); s/norelocs/noreloc/ > igt_subtest("noreloc-S4") > test_noreloc(fd, HIBERNATE, 0); > > for (int signal = 0; signal <= 1; signal++) { > + igt_describe("Stress test which checks softpin with busy batch."); Please use ift_describe_f() here with optional " with interrupts", also change the beginning to something like: "Check eviction with active bo%s." > igt_subtest_f("evict-active%s", signal ? "-interruptible" : "") > test_evict_active(fd, signal); > + > + igt_describe("check that Snooping test by forcibly injecting signals works."); Same here, maybe something like "Check eviction against snooping%s." > igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "") > test_evict_snoop(fd, signal); > } > + > + igt_describe("Checks behaviour of softpin with hung batch."); ---------------------------- ^ s/behaviour/eviction/ s/softpin/softpinned bo/ > igt_subtest("evict-hang") > test_evict_hang(fd); > > -- > 2.35.1 >