From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F04C43334 for ; Tue, 28 Jun 2022 20:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232363AbiF1UQJ (ORCPT ); Tue, 28 Jun 2022 16:16:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbiF1UPf (ORCPT ); Tue, 28 Jun 2022 16:15:35 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F7DF248E3; Tue, 28 Jun 2022 13:11:47 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id i18so24222433lfu.8; Tue, 28 Jun 2022 13:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yP7z++hmLdln35/PWmu6kJvToesBwvqVRLcqwtfTqHw=; b=Wf4kJNvUbmGXAp0NKucvsRru3Al5eajFw/oZCCKXVRRSqAQeeg8pU5Ege0VPhodaH7 IEvU3zGwXrbw+cRkIIQcjHHVhS8kZoOxWWZkL3cJEM0QeyptAEr7JYrzzIseoD7tWwNx GwEWmjo8AA9qQAOthsc9dxhRBtotQ5CWSpAy4Z5KA4HJNAOLWvmdl/DBy+mLSpTuwguG nXhqsIWc0WAhnJEKWESan3ugOFaug8LyIgmFKNvWHvMWfvOG2TncTre7680CDJF/DzZs wADgKv0PoqodHkVCeWuh9jF85+a3yot3LdR+4xBpltsfJhTaVVjqHbtImVNB8Digj3+w J20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yP7z++hmLdln35/PWmu6kJvToesBwvqVRLcqwtfTqHw=; b=4UVV9UFKDlF281gjmd9p4yoI8Tgz3SjoOxvsm78sh0ofi12zH1cF9eJulF430d8ceE j6lVukb4OcJPfcS4hcVD78Mw6u4c5sPjnWF6+RHhZPPTGvjeSUx+7g2jle5cjfp5shKO miyvt9psuiAJlimzgggbwnedjdHDjuTxqS4kEOT8cY1X4s2yG8hoJZV8cpQfnoLNZ1Et xbbffavW+U4wFTca2kYftT6XxfYKslaKUZ6iG+QIrKD2Pn8o6BxtgdkzJGAxDUrxXmms snbMPvesBFK8JlEOjWIO9ZTIvqoi0pcEDUssGoexvAHzPGX+v99nvDfw+Lqwi6Rg0qKM LWAA== X-Gm-Message-State: AJIora+ImrJOuZOdNMyM3r1lG0l1B/eYd7nEJx3/PkbwXBpmd23YAw2a kb0JCGbhTv9VimHZXUC4nFY= X-Google-Smtp-Source: AGRyM1s/SxLBCRJqtNijzYQhHtgDDNIM9SkW0fxBYF0tjMUjSiLBy70E08Gxvmb304uwHefJmXgTew== X-Received: by 2002:a05:6512:128f:b0:480:fd23:6647 with SMTP id u15-20020a056512128f00b00480fd236647mr13566368lfs.136.1656447105293; Tue, 28 Jun 2022 13:11:45 -0700 (PDT) Received: from pc638 ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id v8-20020a05651203a800b0047f9fa2925csm2315627lfp.234.2022.06.28.13.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 13:11:44 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 28 Jun 2022 22:11:37 +0200 To: "Alex Xu (Hello71)" Cc: paulmck@kernel.org, alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org, Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Christian Brauner , christian.koenig@amd.com, Greg Kroah-Hartman , Hridya Valsaraju , "Jason A. Donenfeld" , Joel Fernandes , linux-kernel@vger.kernel.org, Martijn Coenen , rcu@vger.kernel.org, Suren Baghdasaryan , Todd Kjos , Theodore Ts'o , uladzislau.rezki@sony.com, urezki@gmail.com, wireguard@lists.zx2c4.com, Xinhui.Pan@amd.com Subject: Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend) Message-ID: References: <1656357116.rhe0mufk6a.none.ref@localhost> <1656357116.rhe0mufk6a.none@localhost> <20220627204139.GL1790663@paulmck-ThinkPad-P17-Gen-1> <1656379893.q9yb069erk.none@localhost> <20220628041252.GV1790663@paulmck-ThinkPad-P17-Gen-1> <1656421946.ic03168yc3.none@localhost> <20220628185437.GA1790663@paulmck-ThinkPad-P17-Gen-1> <1656443915.mdjoauhqe0.none@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1656443915.mdjoauhqe0.none@localhost> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Excerpts from Paul E. McKenney's message of June 28, 2022 2:54 pm: > > All you need to do to get the previous behavior is to add something like > > this to your defconfig file: > > > > CONFIG_RCU_EXP_CPU_STALL_TIMEOUT=21000 > > > > Any reason why this will not work for you? > > As far as I know, I do not require any particular RCU debugging features > intended for developers; as an individual user and distro maintainer, I > would like to select the option corresponding to "emit errors for > unexpected conditions which should be reported upstream", not "emit > debugging information for development purposes". > Sorry but we need to apply some assumption, i.e. to me the CONFIG_ANDROID indicates that a kernel runs on the Android wise device. When you enable this option on you specific box it is supposed that some Android related code are activated also on your device which may lead to some side effect. > > Therefore, I think 0 is a suitable setting for me and most ordinary > (not tightly controlled) distributions. My concern is that other users > and distro maintainers will also have confusion about what value to set > and whether the warnings are important, since the help text does not say > anything about Android, and "make oldconfig" does not indicate that the > default value is different for Android. > diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug index 9b64e55d4f61..ced0d1f7c675 100644 --- a/kernel/rcu/Kconfig.debug +++ b/kernel/rcu/Kconfig.debug @@ -94,7 +94,8 @@ config RCU_EXP_CPU_STALL_TIMEOUT If the RCU grace period persists, additional CPU stall warnings are printed at more widely spaced intervals. A value of zero says to use the RCU_CPU_STALL_TIMEOUT value converted from - seconds to milliseconds. + seconds to milliseconds. If CONFIG_ANDROID is set for non-Android + platform and you unsure, set the RCU_EXP_CPU_STALL_TIMEOUT to zero. config RCU_TRACE bool "Enable tracing for RCU" Will it work for you? -- Uladzislau Rezki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5900C433EF for ; Tue, 28 Jun 2022 20:52:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6250D10EA1F; Tue, 28 Jun 2022 20:52:53 +0000 (UTC) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E11D10FDF7 for ; Tue, 28 Jun 2022 20:11:47 +0000 (UTC) Received: by mail-lf1-x129.google.com with SMTP id j21so24279478lfe.1 for ; Tue, 28 Jun 2022 13:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yP7z++hmLdln35/PWmu6kJvToesBwvqVRLcqwtfTqHw=; b=Wf4kJNvUbmGXAp0NKucvsRru3Al5eajFw/oZCCKXVRRSqAQeeg8pU5Ege0VPhodaH7 IEvU3zGwXrbw+cRkIIQcjHHVhS8kZoOxWWZkL3cJEM0QeyptAEr7JYrzzIseoD7tWwNx GwEWmjo8AA9qQAOthsc9dxhRBtotQ5CWSpAy4Z5KA4HJNAOLWvmdl/DBy+mLSpTuwguG nXhqsIWc0WAhnJEKWESan3ugOFaug8LyIgmFKNvWHvMWfvOG2TncTre7680CDJF/DzZs wADgKv0PoqodHkVCeWuh9jF85+a3yot3LdR+4xBpltsfJhTaVVjqHbtImVNB8Digj3+w J20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yP7z++hmLdln35/PWmu6kJvToesBwvqVRLcqwtfTqHw=; b=lhLxAtfGGXc2Tf+ufSeQSQSnRZh0ByVOaQjz3tCKEOx9cKfN8VOnlBs9GTjooTIVm4 9hHehbBo/xB42YiuGTLe6moaSeUWNMuxOfbxDRANyRizcJP0t4aZhGzfKjD/gyi02Joj ECdNDL9SjbwUR/08QVJcV1EfHdFtAcULcvxGmLrxGhXXF3fNQNWWZ9OfQZRJVSG8aAqJ Cuw02tuWFazlsu58kuCoSkGrQpktdyCiF4NjEOoaQjOfa7lXmthgUlVFw7yN9AYLe7nT 1ucRRrzs26rros8AUcVkGDx1JdrRYeDMqVi6RcbTOSpSwWMTiYzR7j48Aav4J+6kWAgm MQUg== X-Gm-Message-State: AJIora90XyXOKi+kFpKJMjLsHIcwz4g7ZWl5cNFYCUbqjWvzVRakQ8R6 QC8oCZrCA0h9RbmTuf7tyZQ= X-Google-Smtp-Source: AGRyM1s/SxLBCRJqtNijzYQhHtgDDNIM9SkW0fxBYF0tjMUjSiLBy70E08Gxvmb304uwHefJmXgTew== X-Received: by 2002:a05:6512:128f:b0:480:fd23:6647 with SMTP id u15-20020a056512128f00b00480fd236647mr13566368lfs.136.1656447105293; Tue, 28 Jun 2022 13:11:45 -0700 (PDT) Received: from pc638 ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id v8-20020a05651203a800b0047f9fa2925csm2315627lfp.234.2022.06.28.13.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 13:11:44 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 28 Jun 2022 22:11:37 +0200 To: "Alex Xu (Hello71)" Subject: Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend) Message-ID: References: <1656357116.rhe0mufk6a.none.ref@localhost> <1656357116.rhe0mufk6a.none@localhost> <20220627204139.GL1790663@paulmck-ThinkPad-P17-Gen-1> <1656379893.q9yb069erk.none@localhost> <20220628041252.GV1790663@paulmck-ThinkPad-P17-Gen-1> <1656421946.ic03168yc3.none@localhost> <20220628185437.GA1790663@paulmck-ThinkPad-P17-Gen-1> <1656443915.mdjoauhqe0.none@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1656443915.mdjoauhqe0.none@localhost> X-Mailman-Approved-At: Tue, 28 Jun 2022 20:52:52 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wireguard@lists.zx2c4.com, "Jason A. Donenfeld" , Joel Fernandes , paulmck@kernel.org, Greg Kroah-Hartman , Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Suren Baghdasaryan , rcu@vger.kernel.org, Hridya Valsaraju , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , urezki@gmail.com, Theodore Ts'o , alexander.deucher@amd.com, Todd Kjos , uladzislau.rezki@sony.com, Martijn Coenen , christian.koenig@amd.com, Christian Brauner Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" > Excerpts from Paul E. McKenney's message of June 28, 2022 2:54 pm: > > All you need to do to get the previous behavior is to add something like > > this to your defconfig file: > > > > CONFIG_RCU_EXP_CPU_STALL_TIMEOUT=21000 > > > > Any reason why this will not work for you? > > As far as I know, I do not require any particular RCU debugging features > intended for developers; as an individual user and distro maintainer, I > would like to select the option corresponding to "emit errors for > unexpected conditions which should be reported upstream", not "emit > debugging information for development purposes". > Sorry but we need to apply some assumption, i.e. to me the CONFIG_ANDROID indicates that a kernel runs on the Android wise device. When you enable this option on you specific box it is supposed that some Android related code are activated also on your device which may lead to some side effect. > > Therefore, I think 0 is a suitable setting for me and most ordinary > (not tightly controlled) distributions. My concern is that other users > and distro maintainers will also have confusion about what value to set > and whether the warnings are important, since the help text does not say > anything about Android, and "make oldconfig" does not indicate that the > default value is different for Android. > diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug index 9b64e55d4f61..ced0d1f7c675 100644 --- a/kernel/rcu/Kconfig.debug +++ b/kernel/rcu/Kconfig.debug @@ -94,7 +94,8 @@ config RCU_EXP_CPU_STALL_TIMEOUT If the RCU grace period persists, additional CPU stall warnings are printed at more widely spaced intervals. A value of zero says to use the RCU_CPU_STALL_TIMEOUT value converted from - seconds to milliseconds. + seconds to milliseconds. If CONFIG_ANDROID is set for non-Android + platform and you unsure, set the RCU_EXP_CPU_STALL_TIMEOUT to zero. config RCU_TRACE bool "Enable tracing for RCU" Will it work for you? -- Uladzislau Rezki