All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Andrii Nakryiko <andrii@kernel.org>,
	bpf@vger.kernel.org, ast@kernel.org, kernel-team@fb.com,
	Magnus Karlsson <magnus.karlsson@gmail.com>
Subject: Re: [PATCH v2 bpf-next 01/15] libbpf: move xsk.{c,h} into selftests/bpf
Date: Wed, 29 Jun 2022 11:55:23 +0200	[thread overview]
Message-ID: <Yrwhi2VWtxF+QJk6@boxer> (raw)
In-Reply-To: <014b5bf0-61b5-3510-0468-515c762247e1@iogearbox.net>

On Wed, Jun 29, 2022 at 11:53:12AM +0200, Daniel Borkmann wrote:
> Hey Maciej,
> 
> On 6/29/22 11:41 AM, Maciej Fijalkowski wrote:
> > On Mon, Jun 27, 2022 at 02:15:13PM -0700, Andrii Nakryiko wrote:
> > > Remove deprecated xsk APIs from libbpf. But given we have selftests
> > > relying on this, move those files (with minimal adjustments to make them
> > > compilable) under selftests/bpf.
> > > 
> > > We also remove all the removed APIs from libbpf.map, while overall
> > > keeping version inheritance chain, as most APIs are backwards
> > > compatible so there is no need to reassign them as LIBBPF_1.0.0 versions.
> > 
> > Hey Andrii,
> > 
> > First of all, great that you are moving this over to selftests where we
> > can use this as the base for our upcoming control path tests. However,
> > during some of our selftests work we have found a bug in the xsk part of
> > libbpf that you're moving here. What is the way forward to fixing this
> > from your perspective? Should we wait once this set lands so that we would
> > fix this in the xsk.c file in selftests/bpf? Or would you pick the bugfix
> > before doing the move?
> 
> Just to answer this question, fwiw, the set has been applied yesterday to bpf-next
> tree [0], so from an upstream PoV, please send a relative fix for xsk.c file in
> selftests/bpf/.

Hey Daniel,

oops missed that somehow. Thanks for fast response!

> 
> Thanks,
> Daniel
> 
>   [0] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=f36600634282a519e1b0abea609acdc8731515d7

  reply	other threads:[~2022-06-29  9:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27 21:15 [PATCH v2 bpf-next 00/15] libbpf: remove deprecated APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 01/15] libbpf: move xsk.{c,h} into selftests/bpf Andrii Nakryiko
2022-06-29  9:41   ` Maciej Fijalkowski
2022-06-29  9:53     ` Daniel Borkmann
2022-06-29  9:55       ` Maciej Fijalkowski [this message]
2022-06-27 21:15 ` [PATCH v2 bpf-next 02/15] libbpf: remove deprecated low-level APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 03/15] libbpf: remove deprecated XDP APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 04/15] libbpf: remove deprecated probing APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 05/15] libbpf: remove deprecated BTF APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 06/15] libbpf: clean up perfbuf APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 07/15] libbpf: remove prog_info_linear APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 08/15] libbpf: remove most other deprecated high-level APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 09/15] libbpf: remove multi-instance and custom private data APIs Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 10/15] libbpf: cleanup LIBBPF_DEPRECATED_SINCE supporting macros for v0.x Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 11/15] libbpf: remove internal multi-instance prog support Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 12/15] libbpf: clean up SEC() handling Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 13/15] selftests/bpf: remove last tests with legacy BPF map definitions Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 14/15] libbpf: enforce strict libbpf 1.0 behaviors Andrii Nakryiko
2022-06-27 21:15 ` [PATCH v2 bpf-next 15/15] libbpf: fix up few libbpf.map problems Andrii Nakryiko
2022-06-28 20:20 ` [PATCH v2 bpf-next 00/15] libbpf: remove deprecated APIs patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrwhi2VWtxF+QJk6@boxer \
    --to=maciej.fijalkowski@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=magnus.karlsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.