All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: wuchi <wuchi.zero@gmail.com>
Cc: maorg@nvidia.com, hch@lst.de, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/scatterlist: use matched parameter type when call __sg_free_table
Date: Wed, 29 Jun 2022 20:43:35 +0800	[thread overview]
Message-ID: <YrxI9+ytGZdXlRZ7@T590> (raw)
In-Reply-To: <20220629030241.84559-1-wuchi.zero@gmail.com>

On Wed, Jun 29, 2022 at 11:02:41AM +0800, wuchi wrote:
> commit <4635873c561a> (scsi: lib/sg_pool.c: improve APIs for
> allocating sg pool) had change @(bool)skip_first_chunk of
> __sg_free_table to @(unsigned int)nents_first_chunk, so use unsigend
> int type instead of bool type (false -> 0) when call the function in
> sg_free_append_table and sg_free_table.
> 
> Signed-off-by: wuchi <wuchi.zero@gmail.com>
> ---
>  lib/scatterlist.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/scatterlist.c b/lib/scatterlist.c
> index d5e82e4a57ad..c8c3d675845c 100644
> --- a/lib/scatterlist.c
> +++ b/lib/scatterlist.c
> @@ -240,7 +240,7 @@ EXPORT_SYMBOL(__sg_free_table);
>   **/
>  void sg_free_append_table(struct sg_append_table *table)
>  {
> -	__sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
> +	__sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
>  			table->total_nents);
>  }
>  EXPORT_SYMBOL(sg_free_append_table);
> @@ -253,7 +253,7 @@ EXPORT_SYMBOL(sg_free_append_table);
>   **/
>  void sg_free_table(struct sg_table *table)
>  {
> -	__sg_free_table(table, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
> +	__sg_free_table(table, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
>  			table->orig_nents);
>  }
>  EXPORT_SYMBOL(sg_free_table);

Reviewed-by: Ming Lei <ming.lei@redhat.com>


Thanks,
Ming


      reply	other threads:[~2022-06-29 12:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29  3:02 [PATCH] lib/scatterlist: use matched parameter type when call __sg_free_table wuchi
2022-06-29 12:43 ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrxI9+ytGZdXlRZ7@T590 \
    --to=ming.lei@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maorg@nvidia.com \
    --cc=wuchi.zero@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.