From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A86C433EF for ; Wed, 29 Jun 2022 17:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231484AbiF2RYe (ORCPT ); Wed, 29 Jun 2022 13:24:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbiF2RYd (ORCPT ); Wed, 29 Jun 2022 13:24:33 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 25E253BFBB for ; Wed, 29 Jun 2022 10:24:32 -0700 (PDT) Date: Wed, 29 Jun 2022 19:24:28 +0200 From: Pablo Neira Ayuso To: Oleksandr Natalenko Cc: netfilter-devel@vger.kernel.org, Florian Westphal , Loganaden Velvindron Subject: Re: [PATCH] src: proto: support DF, LE, VA for DSCP Message-ID: References: <20220620185807.968658-1-oleksandr@natalenko.name> <4976225.sBZ64R0qgq@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4976225.sBZ64R0qgq@natalenko.name> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Jun 28, 2022 at 08:29:42PM +0200, Oleksandr Natalenko wrote: > Hello. > > Thank you for your response. Please find my comments inline. > > On pondělí 27. června 2022 19:31:27 CEST Pablo Neira Ayuso wrote: > > On Mon, Jun 20, 2022 at 08:58:07PM +0200, Oleksandr Natalenko wrote: > > > Add a couple of aliases for well-known DSCP values. > > > > > > As per RFC 4594, add "df" as an alias of "cs0" with 0x00 value. > > > > > > As per RFC 5865, add "va" for VOICE-ADMIT with 0x2c value. > > > > Quickly browsing, I don't find "va" nor 0x2c in this RFC above? Could > > you refer to page? > > As per my understanding it's page 11 ("2.3. Recommendations on implementation of an Admitted Telephony Service Class") here: > > Name Space Reference > --------- ------- --------- > VOICE-ADMIT 101100 [RFC5865] > > Am I wrong? Ok, hence the 'va'. > > > As per RFC 8622, add "le" for Lower-Effort with 0x01 value. > > > > This RFC refers to replacing CS1 by LE > > > > o This update to RFC 4594 removes the following entry from its > > Figure 4: > > > > |---------------+------+-------------------+---------+--------+----| > > | Low-Priority | CS1 | Not applicable | RFC3662 | Rate | Yes| > > | Data | | | | | | > > ------------------------------------------------------------------ > > > > and replaces it with the following entry: > > > > |---------------+------+-------------------+----------+--------+----| > > | Low-Priority | LE | Not applicable | RFC 8622 | Rate | Yes| > > | Data | | | | | | > > ------------------------------------------------------------------- > > > > > > static const struct symbol_table dscp_type_tbl = { > > .base = BASE_HEXADECIMAL, > > .symbols = { > > [...] > > SYMBOL("cs1", 0x08), > > [...] > > SYMBOL("le", 0x01), > > I think we shouldn't remove existing symbol, should we? Please let > me know if I missed any suggested action item for myself here. Not removing. I mean, if I understood correctly, the RFC says LE == cs1 ? But the values are different. > > > tc-cake(8) in diffserv8 mode would benefit from having "le" alias since > > > it corresponds to "Tin 0". > > > > Aliasing is fine, let's just clarify this first. > > I mean, "le" would be an alias to "0x01", not to "cs1". > > BTW, the reason I included Loganaden Velvindron in Cc is that "le" > was already added in the past, but got quickly reverted as it broke > some tests. Shall "le" interfere with "less-equal", or what could be > the issue with it? If the name is not acceptable, "lephb" or similar > can be used instead. Oh right, this is an issue for the parser, the 'le' keyword is an alias of '<='. What does 'lephb' stands for BTW? Note that these aliases will be lost when listing back the ruleset from the kernel, so it is only working as an input.