From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17D06C43334 for ; Tue, 12 Jul 2022 12:17:51 +0000 (UTC) Received: from localhost ([::1]:42524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBEpq-0006Fv-6l for qemu-devel@archiver.kernel.org; Tue, 12 Jul 2022 08:17:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBEn9-0004bI-7U for qemu-devel@nongnu.org; Tue, 12 Jul 2022 08:15:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:21476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBEn4-0003Mp-Ef for qemu-devel@nongnu.org; Tue, 12 Jul 2022 08:15:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657628097; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flwAzFdYWqnnUich5XWSRXpFLBLbFQ6QrfzliaHES2Y=; b=VHdVxsKdK8TxAhwSB33PjzU2/muNw1ATYg7xwb9yoKs70Ng6ihFASPTYVACAxAunP728lZ DH90MBe0U2llyUWGiVgtXk2iCMdp+QRksG+RZqc0w1AXMFdztS7uatTJ2G2Z7578CSOosH mp0Erumvqgc0GRjO2n7os7T2kDIAI20= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-sMvS6xXQMxevs3gChnLGGA-1; Tue, 12 Jul 2022 08:14:56 -0400 X-MC-Unique: sMvS6xXQMxevs3gChnLGGA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58DCF85A581; Tue, 12 Jul 2022 12:14:56 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54CD5492C3B; Tue, 12 Jul 2022 12:14:55 +0000 (UTC) Date: Tue, 12 Jul 2022 13:14:52 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Hanna Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Kevin Wolf , Paolo Bonzini Subject: Re: [PATCH 2/3] vl: Conditionally register PID file unlink notifier Message-ID: References: <20220609122701.17172-1-hreitz@redhat.com> <20220609122701.17172-3-hreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220609122701.17172-3-hreitz@redhat.com> User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 09, 2022 at 02:27:00PM +0200, Hanna Reitz wrote: > Currently, the exit notifier for unlinking the PID file is registered > unconditionally. Limit it to only when we actually do create a PID > file. > > Signed-off-by: Hanna Reitz > --- > softmmu/vl.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|