From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 034D1C433EF for ; Tue, 12 Jul 2022 12:26:48 +0000 (UTC) Received: from localhost ([::1]:53652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBEyV-0005nU-SJ for qemu-devel@archiver.kernel.org; Tue, 12 Jul 2022 08:26:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBEve-0003YH-0w for qemu-devel@nongnu.org; Tue, 12 Jul 2022 08:23:50 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:41679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBEvc-0004vH-Fs for qemu-devel@nongnu.org; Tue, 12 Jul 2022 08:23:49 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id AF0355C00BD; Tue, 12 Jul 2022 08:23:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 12 Jul 2022 08:23:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1657628626; x=1657715026; bh=MU uC2zBzYMps/tzwu4iwfnYm++J/e1AQbIGC3c6ZA4o=; b=3NyhsDLoVuVby6v+kz j4RvKtND/hF3kCOvQvN5f5t2gM0CHRiw5dZs4sR8waFG5j2p9tvO+Vv2PLgj168J EMmdQP7an3Jt+OkWKybch69fePsMD1ALxFg5Y1QyyjM8Cr9FlMt4UQf88iUnk6DD 6zuQYO/XVqaX+QRCBjLbzbScjS41mCrEMGpfQGZU3iMNmBVaCdIO7zuorrMpsxxg 1aQIfQVB0iP/5+AWZ+YhzlYGco2V8A9JMOQPzuBuvp8EbNNaE2MrGuIQPAaK3zLc bRpgdrOq9Qt13R4asfUWi/GKqUIRI6XBs0Zr4GbZzge9DtfL+Q5BSq/JRU1tkuz5 Ic7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657628626; x=1657715026; bh=MUuC2zBzYMps/tzwu4iwfnYm++J/ e1AQbIGC3c6ZA4o=; b=nQYR8/l+2ob5yYpwbzKCEojv96aUhvwBecxXp4G0xyhV hL57CINmab+CjdOE3BiS6Axho/EkrkGNU6YdHqrK85Wzo/mNqzb24OMmmK/vV/Lw TXdOU/yNLAF+MOrXXO+GtBdKwkB5ue8iAVggbdGhgIoZ58YcBigh5leDj9jqEhij fsTUWWrGY8GdxDUKIj/ZTN4uiNJ4LR+ds5/d3vIejCRk3zRqG7Pn5FSUw04NXMlp bT1ONbIWHgux0XacYbjz88QwT4L6VRq6CnTXJWEvxlMa6bnIiIM7wlstWR+aUXQn LnZvHpFCbRG++dMwppFJN6MmpQqMfQeRVIptqiI22w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejhedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjefgjeefffdvuefhieefhffggfeuleehudekveejvedtuddugeeigeetffff jeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih htshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Jul 2022 08:23:45 -0400 (EDT) Date: Tue, 12 Jul 2022 14:23:43 +0200 From: Klaus Jensen To: Jinhao Fan Cc: qemu-devel@nongnu.org, Keith Busch Subject: Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates Message-ID: References: <20220705142403.101539-1-fanjinhao21s@ict.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wmC0QJPm5SC595b6" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --wmC0QJPm5SC595b6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jul 9 11:06, Jinhao Fan wrote: > at 10:24 PM, Jinhao Fan wrote: >=20 > > @@ -5793,6 +5891,7 @@ static uint16_t nvme_dbbuf_config(NvmeCtrl *n, co= nst NvmeRequest *req) > > uint64_t dbs_addr =3D le64_to_cpu(req->cmd.dptr.prp1); > > uint64_t eis_addr =3D le64_to_cpu(req->cmd.dptr.prp2); > > int i; > > + int ret; > >=20 >=20 > I just noticed this ret is unused. Could you help remove this line when > applying the patch? Yes, I noticed it and hot-fixed it ;) --wmC0QJPm5SC595b6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmLNZ84ACgkQTeGvMW1P Demw1Af/TecT37vluSRgdVStSrekmkZrhlxeMRnZLkxFGq8Y4Byi9sQbWhhvwEG3 gtKq049yK0OrrvbJCDF8svUmXDOxuoD4aMvVVC+URPPR33r79RjaBinhSnPb+UoF FLOEA3yo5r1GrxBCekKFLJl97xCLf/SoE/KDMoMO6BH3KKUQvb2qSKYRxoAGvcLe lBfw7PtdLNsETnJcbTgas/Ckh4jqVUBLYdzBl4HHKgaqsE/xKvCOKF45Ngvcxxs+ AVd40Fc/BzB6P/SFY5eiGBffl+3wtsh4e8hqyew4p/tWG7uaicWDFE5mrqyves/0 XxhC1SEhh2xNL7l+EUFjSWLnO5sNmw== =qe1w -----END PGP SIGNATURE----- --wmC0QJPm5SC595b6--