From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22523CCA479 for ; Wed, 13 Jul 2022 08:04:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbiGMIEb (ORCPT ); Wed, 13 Jul 2022 04:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234817AbiGMIE3 (ORCPT ); Wed, 13 Jul 2022 04:04:29 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E03E0E1901 for ; Wed, 13 Jul 2022 01:04:27 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id a5so14327952wrx.12 for ; Wed, 13 Jul 2022 01:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=yaBi5+j2aB+gOEpu/CS6a4crTXK1oluI+G7cSMbxelM=; b=MduZJ4LcUwia674sobuaUywFu/y9XJbPCqF8UXjn0wnRaCT+QZ3XOGx+YAje4xxfsx x9gPEEwK6l26zgKylqiCX6kg+6Qcrx6/7WQ/ytwHvcda4vtybERuZ4s70YTn/BNqLy24 5MeZn8161zhdqCh3Gug8o1zPTpESCgZp9pNlebMEHS9aj8RGpd5fMetXcNCgQ8tnZWl2 oITFcoQoNbdZcmx8uMXLq2HS15pvFWibAtvysAkVPH+IejhAt1//CsNF6qnytW3Sp+Yo iZrLyWZCZeToIHPCPlOTz9lFBuwhiDKL4zdw/LqWzu1dOoE8C4t19oUDKrZTd7BZsh3v b4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=yaBi5+j2aB+gOEpu/CS6a4crTXK1oluI+G7cSMbxelM=; b=jhOueXuUdL/XWAONp46yUbAX/R/9nnQKVZogpIRWkQF3vK4g3myt7BbzRX7xh9RssY Ikiunm36e4ENE6cCFTtvHE2GgSHCBQV4g/MpfPXOTxPxaiDdIyEegAleghh6mtUkps7c xts8le2mNKBxd+h9pdI9oW+ebTe94EYVJgqXn2HXCSWcuXGVKlEitAsCwN3n3hVM7LGK s8s5cMC38v3ZhTSe56C6PfoIOwdvfsZKkJ3Ru2MnsONJSQJr2X4hC2mqUmakHDrA0Gaf W5AJXVKflVBuRyWY0Wxf7CS3WJrkm9CMWn1iG3Q14PJkKiAepdJMhuC8nY5qirZsWNa8 ZJyA== X-Gm-Message-State: AJIora9JdCSsWwoxOTCVfqf7yUp7YaUTKzucXDM25JCCHAgWvopbaOr4 hG+TFbZ+UwTjZtzYz9fKCZ/+AA== X-Google-Smtp-Source: AGRyM1sox2gwD2oOUs0Po8YP6r0hOoKvkq7xKaXz/jSSA3VY7uq2zQIZPBxBD2yVdN4jLfilFwtkQw== X-Received: by 2002:a5d:4890:0:b0:21d:9bf3:89b5 with SMTP id g16-20020a5d4890000000b0021d9bf389b5mr1887795wrq.153.1657699465867; Wed, 13 Jul 2022 01:04:25 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id l29-20020a05600c1d1d00b0039749b01ea7sm1616879wms.32.2022.07.13.01.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 01:04:25 -0700 (PDT) Date: Wed, 13 Jul 2022 09:04:22 +0100 From: Lee Jones To: ChiaEn Wu Cc: Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , ChiYuan Huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Subject: Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-8-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, 13 Jul 2022, ChiaEn Wu wrote: > Hi Lee, > > Thanks for your reply. > > Lee Jones 於 2022年7月12日 週二 晚上11:29寫道： > > > > On Thu, 23 Jun 2022, ChiaEn Wu wrote: > > > > > From: ChiYuan Huang > > > > > > Add Mediatek MT6370 MFD support. > > > > No such thing as "MFD support". > > > > And you're not getting away with submitting a 370 line patch with a 5 > > word change log either. :) > > > > Please at least tell us what the device is and what it's used for. > > I sincerely apologize. > We will add more descriptions of the MT6370 feature in the v5 patch. > > > > > > Signed-off-by: ChiYuan Huang > > > --- > > > > > > v3 > > > - Refine Kconfig help text > > > - Refine error message of unknown vendor ID in > > > mt6370_check_vendor_info() > > > - Refine return value handling of mt6370_regmap_read() > > > - Refine all probe error by using dev_err_probe() > > > - Refine "bank_idx" and "bank_addr" in mt6370_regmap_read() and > > > mt6370_regmap_write() > > > - Add "#define VENID*" and drop the comments in > > > mt6370_check_vendor_info() > > > - Drop "MFD" in MODULE_DESCRIPTION() > > > --- > > > drivers/mfd/Kconfig | 13 ++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/mt6370.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 372 insertions(+) > > > create mode 100644 drivers/mfd/mt6370.c [...] > > > +static int mt6370_probe(struct i2c_client *i2c) > > > +{ > > > + struct mt6370_info *info; > > > + struct i2c_client *usbc_i2c; > > > + int ret; > > > + > > > + info = devm_kzalloc(&i2c->dev, sizeof(*info), GFP_KERNEL); > > > + if (!info) > > > + return -ENOMEM; > > > + > > > + info->dev = &i2c->dev; > > > + > > > + usbc_i2c = devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, > > > + MT6370_USBC_I2CADDR); > > > + if (IS_ERR(usbc_i2c)) > > > + return dev_err_probe(&i2c->dev, PTR_ERR(usbc_i2c), > > > + "Failed to register USBC I2C client\n"); > > > + > > > + /* Assign I2C client for PMU and TypeC */ > > > + info->i2c[MT6370_PMU_I2C] = i2c; > > > + info->i2c[MT6370_USBC_I2C] = usbc_i2c; > > > + > > > + info->regmap = devm_regmap_init(&i2c->dev, &mt6370_regmap_bus, info, > > > + &mt6370_regmap_config); > > > > Apart from in mt6370_check_vendor_info() where is this actually used? > > Well... from my understanding, we use this MFD driver to make other > drivers of MT6370 (e.g. charger, ADC, led...) use the same regmap > settings. > Thus, this regmap is not only used in mt6370_check_vendor_info(). Well for that to happen you need to store the data somewhere for the child devices to fetch from. I don't see that happening in this patch? What did I miss? -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16105C43334 for ; Wed, 13 Jul 2022 08:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KYnb9spGlpbWFiv3OkudjYYNayYhMDXCyWTi4i1jmzI=; b=jstf8qhGC2DfBp QLN3fWdxhB9QhcA2S2V/mvfOT8O9rUCa7Vb60T5mMxfjqmVKAKdNVZ2Xan2waW/C8y9wlD9Q3Zn8F WjliYeswQb7j2f3xxHxCa3p8aYcEIlwEQEs5p6jUa5L+5ZzS8/1796KJ6dcH8y8hHazZxlyX6RcT4 K8+kt+eZSP4VvG6yb9vj6RMEqi2+EZ9pGSSa+/FUoPcHSXm9+cuIggZAEHwfik87Jg4tnR5b41nDz ImFESpxeib/yzyhEgayoff1ip71F2rO9Ss3DfrpZlZRj3Y+wsXHi+I60vzZTzY8prY79o7wdWfhEa 1+C4nUF4C+JFPNH507YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBXMJ-001U2c-FJ; Wed, 13 Jul 2022 08:04:35 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBXMC-001Txg-FA for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 08:04:32 +0000 Received: by mail-wr1-x42b.google.com with SMTP id z12so14336637wrq.7 for ; Wed, 13 Jul 2022 01:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=yaBi5+j2aB+gOEpu/CS6a4crTXK1oluI+G7cSMbxelM=; b=MduZJ4LcUwia674sobuaUywFu/y9XJbPCqF8UXjn0wnRaCT+QZ3XOGx+YAje4xxfsx x9gPEEwK6l26zgKylqiCX6kg+6Qcrx6/7WQ/ytwHvcda4vtybERuZ4s70YTn/BNqLy24 5MeZn8161zhdqCh3Gug8o1zPTpESCgZp9pNlebMEHS9aj8RGpd5fMetXcNCgQ8tnZWl2 oITFcoQoNbdZcmx8uMXLq2HS15pvFWibAtvysAkVPH+IejhAt1//CsNF6qnytW3Sp+Yo iZrLyWZCZeToIHPCPlOTz9lFBuwhiDKL4zdw/LqWzu1dOoE8C4t19oUDKrZTd7BZsh3v b4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=yaBi5+j2aB+gOEpu/CS6a4crTXK1oluI+G7cSMbxelM=; b=4B8xG3IjxI8AotQlgPR+hMjt24jD5TLG0g05XmWWTLYtDE5cl/ABXhaUfctUC7xFGV 3WZtbBz4iOrXlVqnYKkTsKBfK0DHTs/kUcEQPnpy7xzhbd8YjMfN3xkecVuVFv85ET76 UIJX4qNyZXLBVOgK8DNtnMe6zIPFwLgV+a/o7yu6aEf2c/VRYkE9uYCmcAE8Gb1QJCa0 1yRs3LI+w28vGsxZpsHvWPNkcpLWMfcnpX+eZc7gNULwchGzQz44dmFk9rdcXN2KkXIm X28RPqXynVZwrGPRd67cC3Ez4Loe1MzWklKac1MI86ZCgwPMOmD2oGUhK6ESLaTqGzzx 09Kw== X-Gm-Message-State: AJIora8VGsTuyU15WCifvmqJzIwIhaE0Vvu9O067X3tWubfrRM/eReNE SgzjSqGeAvsl4B3ibP+kgpXI3Q== X-Google-Smtp-Source: AGRyM1sox2gwD2oOUs0Po8YP6r0hOoKvkq7xKaXz/jSSA3VY7uq2zQIZPBxBD2yVdN4jLfilFwtkQw== X-Received: by 2002:a5d:4890:0:b0:21d:9bf3:89b5 with SMTP id g16-20020a5d4890000000b0021d9bf389b5mr1887795wrq.153.1657699465867; Wed, 13 Jul 2022 01:04:25 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id l29-20020a05600c1d1d00b0039749b01ea7sm1616879wms.32.2022.07.13.01.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 01:04:25 -0700 (PDT) Date: Wed, 13 Jul 2022 09:04:22 +0100 From: Lee Jones To: ChiaEn Wu Cc: Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , ChiYuan Huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Subject: Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-8-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220713_010428_552563_60D9F544 X-CRM114-Status: GOOD ( 33.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMyBKdWwgMjAyMiwgQ2hpYUVuIFd1IHdyb3RlOgoKPiBIaSBMZWUsCj4gCj4gVGhh bmtzIGZvciB5b3VyIHJlcGx5Lgo+IAo+IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ IOaWvCAyMDIy5bm0N+aciDEy5pelIOmAseS6jCDmmZrkuIoxMToyOeWvq+mBk++8mgo+ID4KPiA+ IE9uIFRodSwgMjMgSnVuIDIwMjIsIENoaWFFbiBXdSB3cm90ZToKPiA+Cj4gPiA+IEZyb206IENo aVl1YW4gSHVhbmcgPGN5X2h1YW5nQHJpY2h0ZWsuY29tPgo+ID4gPgo+ID4gPiBBZGQgTWVkaWF0 ZWsgTVQ2MzcwIE1GRCBzdXBwb3J0Lgo+ID4KPiA+IE5vIHN1Y2ggdGhpbmcgYXMgIk1GRCBzdXBw b3J0Ii4KPiA+Cj4gPiBBbmQgeW91J3JlIG5vdCBnZXR0aW5nIGF3YXkgd2l0aCBzdWJtaXR0aW5n IGEgMzcwIGxpbmUgcGF0Y2ggd2l0aCBhIDUKPiA+IHdvcmQgY2hhbmdlIGxvZyBlaXRoZXIuIDop Cj4gPgo+ID4gUGxlYXNlIGF0IGxlYXN0IHRlbGwgdXMgd2hhdCB0aGUgZGV2aWNlIGlzIGFuZCB3 aGF0IGl0J3MgdXNlZCBmb3IuCj4gCj4gSSBzaW5jZXJlbHkgYXBvbG9naXplLgo+IFdlIHdpbGwg YWRkIG1vcmUgZGVzY3JpcHRpb25zIG9mIHRoZSBNVDYzNzAgZmVhdHVyZSBpbiB0aGUgdjUgcGF0 Y2guCj4gCj4gPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDaGlZdWFuIEh1YW5nIDxjeV9odWFuZ0By aWNodGVrLmNvbT4KPiA+ID4gLS0tCj4gPiA+Cj4gPiA+IHYzCj4gPiA+IC0gUmVmaW5lIEtjb25m aWcgaGVscCB0ZXh0Cj4gPiA+IC0gUmVmaW5lIGVycm9yIG1lc3NhZ2Ugb2YgdW5rbm93biB2ZW5k b3IgSUQgaW4KPiA+ID4gICBtdDYzNzBfY2hlY2tfdmVuZG9yX2luZm8oKQo+ID4gPiAtIFJlZmlu ZSByZXR1cm4gdmFsdWUgaGFuZGxpbmcgb2YgbXQ2MzcwX3JlZ21hcF9yZWFkKCkKPiA+ID4gLSBS ZWZpbmUgYWxsIHByb2JlIGVycm9yIGJ5IHVzaW5nIGRldl9lcnJfcHJvYmUoKQo+ID4gPiAtIFJl ZmluZSAiYmFua19pZHgiIGFuZCAiYmFua19hZGRyIiBpbiBtdDYzNzBfcmVnbWFwX3JlYWQoKSBh bmQKPiA+ID4gICBtdDYzNzBfcmVnbWFwX3dyaXRlKCkKPiA+ID4gLSBBZGQgIiNkZWZpbmUgVkVO SUQqIiBhbmQgZHJvcCB0aGUgY29tbWVudHMgaW4KPiA+ID4gICBtdDYzNzBfY2hlY2tfdmVuZG9y X2luZm8oKQo+ID4gPiAtIERyb3AgIk1GRCIgaW4gTU9EVUxFX0RFU0NSSVBUSU9OKCkKPiA+ID4g LS0tCj4gPiA+ICBkcml2ZXJzL21mZC9LY29uZmlnICB8ICAxMyArKwo+ID4gPiAgZHJpdmVycy9t ZmQvTWFrZWZpbGUgfCAgIDEgKwo+ID4gPiAgZHJpdmVycy9tZmQvbXQ2MzcwLmMgfCAzNTggKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ICAz IGZpbGVzIGNoYW5nZWQsIDM3MiBpbnNlcnRpb25zKCspCj4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2 NDQgZHJpdmVycy9tZmQvbXQ2MzcwLmMKClsuLi5dCgo+ID4gPiArc3RhdGljIGludCBtdDYzNzBf cHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmkyYykKPiA+ID4gK3sKPiA+ID4gKyAgICAgc3RydWN0 IG10NjM3MF9pbmZvICppbmZvOwo+ID4gPiArICAgICBzdHJ1Y3QgaTJjX2NsaWVudCAqdXNiY19p MmM7Cj4gPiA+ICsgICAgIGludCByZXQ7Cj4gPiA+ICsKPiA+ID4gKyAgICAgaW5mbyA9IGRldm1f a3phbGxvYygmaTJjLT5kZXYsIHNpemVvZigqaW5mbyksIEdGUF9LRVJORUwpOwo+ID4gPiArICAg ICBpZiAoIWluZm8pCj4gPiA+ICsgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4gPiA+ICsK PiA+ID4gKyAgICAgaW5mby0+ZGV2ID0gJmkyYy0+ZGV2Owo+ID4gPiArCj4gPiA+ICsgICAgIHVz YmNfaTJjID0gZGV2bV9pMmNfbmV3X2R1bW15X2RldmljZSgmaTJjLT5kZXYsIGkyYy0+YWRhcHRl ciwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1UNjM3 MF9VU0JDX0kyQ0FERFIpOwo+ID4gPiArICAgICBpZiAoSVNfRVJSKHVzYmNfaTJjKSkKPiA+ID4g KyAgICAgICAgICAgICByZXR1cm4gZGV2X2Vycl9wcm9iZSgmaTJjLT5kZXYsIFBUUl9FUlIodXNi Y19pMmMpLAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJGYWlsZWQg dG8gcmVnaXN0ZXIgVVNCQyBJMkMgY2xpZW50XG4iKTsKPiA+ID4gKwo+ID4gPiArICAgICAvKiBB c3NpZ24gSTJDIGNsaWVudCBmb3IgUE1VIGFuZCBUeXBlQyAqLwo+ID4gPiArICAgICBpbmZvLT5p MmNbTVQ2MzcwX1BNVV9JMkNdID0gaTJjOwo+ID4gPiArICAgICBpbmZvLT5pMmNbTVQ2MzcwX1VT QkNfSTJDXSA9IHVzYmNfaTJjOwo+ID4gPiArCj4gPiA+ICsgICAgIGluZm8tPnJlZ21hcCA9IGRl dm1fcmVnbWFwX2luaXQoJmkyYy0+ZGV2LCAmbXQ2MzcwX3JlZ21hcF9idXMsIGluZm8sCj4gPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJm10NjM3MF9yZWdtYXBfY29u ZmlnKTsKPiA+Cj4gPiBBcGFydCBmcm9tIGluIG10NjM3MF9jaGVja192ZW5kb3JfaW5mbygpIHdo ZXJlIGlzIHRoaXMgYWN0dWFsbHkgdXNlZD8KPiAKPiBXZWxsLi4uIGZyb20gbXkgdW5kZXJzdGFu ZGluZywgd2UgdXNlIHRoaXMgTUZEIGRyaXZlciB0byBtYWtlIG90aGVyCj4gZHJpdmVycyBvZiBN VDYzNzAgKGUuZy4gY2hhcmdlciwgQURDLCBsZWQuLi4pIHVzZSB0aGUgc2FtZSByZWdtYXAKPiBz ZXR0aW5ncy4KPiBUaHVzLCB0aGlzIHJlZ21hcCBpcyBub3Qgb25seSB1c2VkIGluIG10NjM3MF9j aGVja192ZW5kb3JfaW5mbygpLgoKV2VsbCBmb3IgdGhhdCB0byBoYXBwZW4geW91IG5lZWQgdG8g c3RvcmUgdGhlIGRhdGEgc29tZXdoZXJlIGZvciB0aGUKY2hpbGQgZGV2aWNlcyB0byBmZXRjaCBm cm9tLiAgSSBkb24ndCBzZWUgdGhhdCBoYXBwZW5pbmcgaW4gdGhpcwpwYXRjaD8gIFdoYXQgZGlk IEkgbWlzcz8KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KUHJpbmNpcGFsIFRlY2huaWNhbCBM ZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3 YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9n CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE5EBC433EF for ; Wed, 13 Jul 2022 08:04:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A0F493695; Wed, 13 Jul 2022 08:04:29 +0000 (UTC) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AB2212A032 for ; Wed, 13 Jul 2022 08:04:27 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id o4so14356421wrh.3 for ; Wed, 13 Jul 2022 01:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=yaBi5+j2aB+gOEpu/CS6a4crTXK1oluI+G7cSMbxelM=; b=MduZJ4LcUwia674sobuaUywFu/y9XJbPCqF8UXjn0wnRaCT+QZ3XOGx+YAje4xxfsx x9gPEEwK6l26zgKylqiCX6kg+6Qcrx6/7WQ/ytwHvcda4vtybERuZ4s70YTn/BNqLy24 5MeZn8161zhdqCh3Gug8o1zPTpESCgZp9pNlebMEHS9aj8RGpd5fMetXcNCgQ8tnZWl2 oITFcoQoNbdZcmx8uMXLq2HS15pvFWibAtvysAkVPH+IejhAt1//CsNF6qnytW3Sp+Yo iZrLyWZCZeToIHPCPlOTz9lFBuwhiDKL4zdw/LqWzu1dOoE8C4t19oUDKrZTd7BZsh3v b4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=yaBi5+j2aB+gOEpu/CS6a4crTXK1oluI+G7cSMbxelM=; b=uP5m0tt+P2xOd797Q/AgyztscAvHfVS+me/MEm9GXfQ13MMGJJQSU4lu8q87mGA6Fg Syj7KM4vrDJK3qfBaQcRILIyBvsqAEqkP90nroauCtXi1OY9w3SayGR8nkrM+/F4LBkT 6OyQK3ZHHJ3ZUPO/C9DQ8HL+IgAYv944pmBYJbAN4dUfnsREGMFYuXOoXfJBzOwnBtVN VSt9aIjwBmjvWjYN9VoxK+OYLgUy6TcNX4tcODL914W0pSWas9CbV1C9zj0rlY9sUqAC kYlhrlBlE+pdUCMqnj6SVjLzv33rh9SjuVta12wEZ+PNQm2a+1Shvnf645t/+ga2k/Lx B6hA== X-Gm-Message-State: AJIora9wtf1ydvukyDECEoubpHQsjiZQIc3Jp5D2/CIIrGUBmI/uWy1U dFlzRu9yECh92N+nyTZ4NPkyGA== X-Google-Smtp-Source: AGRyM1sox2gwD2oOUs0Po8YP6r0hOoKvkq7xKaXz/jSSA3VY7uq2zQIZPBxBD2yVdN4jLfilFwtkQw== X-Received: by 2002:a5d:4890:0:b0:21d:9bf3:89b5 with SMTP id g16-20020a5d4890000000b0021d9bf389b5mr1887795wrq.153.1657699465867; Wed, 13 Jul 2022 01:04:25 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id l29-20020a05600c1d1d00b0039749b01ea7sm1616879wms.32.2022.07.13.01.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 01:04:25 -0700 (PDT) Date: Wed, 13 Jul 2022 09:04:22 +0100 From: Lee Jones To: ChiaEn Wu Subject: Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-8-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Krzysztof Kozlowski , Alice Chen , linux-iio , dri-devel , Liam Girdwood , ChiYuan Huang , Pavel Machek , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 13 Jul 2022, ChiaEn Wu wrote: > Hi Lee, > > Thanks for your reply. > > Lee Jones 於 2022年7月12日 週二 晚上11:29寫道： > > > > On Thu, 23 Jun 2022, ChiaEn Wu wrote: > > > > > From: ChiYuan Huang > > > > > > Add Mediatek MT6370 MFD support. > > > > No such thing as "MFD support". > > > > And you're not getting away with submitting a 370 line patch with a 5 > > word change log either. :) > > > > Please at least tell us what the device is and what it's used for. > > I sincerely apologize. > We will add more descriptions of the MT6370 feature in the v5 patch. > > > > > > Signed-off-by: ChiYuan Huang > > > --- > > > > > > v3 > > > - Refine Kconfig help text > > > - Refine error message of unknown vendor ID in > > > mt6370_check_vendor_info() > > > - Refine return value handling of mt6370_regmap_read() > > > - Refine all probe error by using dev_err_probe() > > > - Refine "bank_idx" and "bank_addr" in mt6370_regmap_read() and > > > mt6370_regmap_write() > > > - Add "#define VENID*" and drop the comments in > > > mt6370_check_vendor_info() > > > - Drop "MFD" in MODULE_DESCRIPTION() > > > --- > > > drivers/mfd/Kconfig | 13 ++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/mt6370.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 372 insertions(+) > > > create mode 100644 drivers/mfd/mt6370.c [...] > > > +static int mt6370_probe(struct i2c_client *i2c) > > > +{ > > > + struct mt6370_info *info; > > > + struct i2c_client *usbc_i2c; > > > + int ret; > > > + > > > + info = devm_kzalloc(&i2c->dev, sizeof(*info), GFP_KERNEL); > > > + if (!info) > > > + return -ENOMEM; > > > + > > > + info->dev = &i2c->dev; > > > + > > > + usbc_i2c = devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, > > > + MT6370_USBC_I2CADDR); > > > + if (IS_ERR(usbc_i2c)) > > > + return dev_err_probe(&i2c->dev, PTR_ERR(usbc_i2c), > > > + "Failed to register USBC I2C client\n"); > > > + > > > + /* Assign I2C client for PMU and TypeC */ > > > + info->i2c[MT6370_PMU_I2C] = i2c; > > > + info->i2c[MT6370_USBC_I2C] = usbc_i2c; > > > + > > > + info->regmap = devm_regmap_init(&i2c->dev, &mt6370_regmap_bus, info, > > > + &mt6370_regmap_config); > > > > Apart from in mt6370_check_vendor_info() where is this actually used? > > Well... from my understanding, we use this MFD driver to make other > drivers of MT6370 (e.g. charger, ADC, led...) use the same regmap > settings. > Thus, this regmap is not only used in mt6370_check_vendor_info(). Well for that to happen you need to store the data somewhere for the child devices to fetch from. I don't see that happening in this patch? What did I miss? -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog