From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F0ECC433EF for ; Wed, 13 Jul 2022 08:44:21 +0000 (UTC) Received: from localhost ([::1]:39834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBXym-0002fm-Dw for qemu-devel@archiver.kernel.org; Wed, 13 Jul 2022 04:44:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBXd8-0001qn-8N for qemu-devel@nongnu.org; Wed, 13 Jul 2022 04:21:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:45162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBXd4-0005OM-9M for qemu-devel@nongnu.org; Wed, 13 Jul 2022 04:21:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657700513; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VArjng80BmwglGCJzNqpmAm4I8kiAib0Vm7IaVRRwkE=; b=FPqCo8gYLjE/KKGSKmHLVoGWvCclD6bKaEyXrO7giUtk9Xu+VCUmgedKK+H33c8rg9i+Zs ghG+lMv4IstLIZdEIGOUb702UuKQXxHlnqo9GayVA6K8cbWrzfYWPLP9oRP3xlLfuXAB+K HAr9rT3w0hEIOqYHY07WrFS7JvwbMYM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-135-Gm55YWZcP5mKETa-L5dgaw-1; Wed, 13 Jul 2022 04:21:50 -0400 X-MC-Unique: Gm55YWZcP5mKETa-L5dgaw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9863A857CEA; Wed, 13 Jul 2022 08:21:49 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 258FEC2812B; Wed, 13 Jul 2022 08:21:47 +0000 (UTC) Date: Wed, 13 Jul 2022 09:21:45 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Eric Blake , Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth , Peter Maydell Subject: Re: [PATCH v3 3/9] tests/style: check for mixups of bool constants with int variables Message-ID: References: <20220707163720.1421716-1-berrange@redhat.com> <20220707163720.1421716-4-berrange@redhat.com> <54df7007-6b84-dfeb-950a-55f798d660e3@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54df7007-6b84-dfeb-950a-55f798d660e3@amsat.org> User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 11, 2022 at 06:24:22PM +0200, Philippe Mathieu-Daudé wrote: > On 7/7/22 18:37, Daniel P. Berrangé wrote: > > The 'true' and 'false' constants should only ever be used with the > > 'bool' type, never 'int'. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/style.yml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/tests/style.yml b/tests/style.yml > > index b4e7c6111f..704227d8e9 100644 > > --- a/tests/style.yml > > +++ b/tests/style.yml > > @@ -86,3 +86,8 @@ > > # A match added to the front of the regex. Useful when > > # 'terms' is a list of strings and a common prefix is > > # desired > > + > > +int_assign_bool: > > + files: \.c$ > > Why not check .c.inc and .h (for static inlined func)? Yes, we should. > Regardless: > Reviewed-by: Philippe Mathieu-Daudé > > > + prohibit: \.*= *(true|false)\b > > + message: use bool type for boolean values > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|