From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D268C43334 for ; Sun, 3 Jul 2022 12:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232496AbiGCMag (ORCPT ); Sun, 3 Jul 2022 08:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbiGCMae (ORCPT ); Sun, 3 Jul 2022 08:30:34 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D53F626C9; Sun, 3 Jul 2022 05:30:33 -0700 (PDT) Received: from zn.tnic (p200300ea970ff65c329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f65c:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6A89E1EC0666; Sun, 3 Jul 2022 14:30:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1656851428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wn9uQnAuwFGrab8kpHKs8SGNaKDnyC8vS2rlkoo88JI=; b=YW7aqJN9n9rpT494I3ull/tEVWXbJPHATT5u8+cLdngahgrQS4l5ZyvytD45bUrgqx8SXj qwQMZoaaqw6zESxDOrqstLy7zmOeyOshy+JL/xP/+4O9p2lRMTQMYdW04FnpdJTtTDKJEh EOgheD6zTSvVLYRZnMO8mxxdG3YsP5E= Date: Sun, 3 Jul 2022 14:30:24 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org, Smita.KoralahalliChannabasappa@amd.com Subject: Re: [PATCH 2/3] x86/MCE/APEI: Handle variable register array size Message-ID: References: <20220418174440.334336-1-yazen.ghannam@amd.com> <20220418174440.334336-3-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220418174440.334336-3-yazen.ghannam@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 18, 2022 at 05:44:39PM +0000, Yazen Ghannam wrote: > Recent AMD systems may provide an x86 Common Platform Error Record > (CPER) for errors reported in the ACPI Boot Error Record Table (BERT). > The x86 CPER may contain one or more Processor Context Information > Structures. The context structures may represent an x86 MSR range where > a starting address is given, and the data represents a contiguous set of > MSRs starting from, and including, the starting address. You're killing me with these "may" formulations. Just say it once and then drop it. I mean, we know some future hw "may" support something new - you can just as well drop the "may" thing because if it only may and it turns out it might not, you don't even have to do the work and enabling it and sending the patch. So no need to do that - the patch commit message should talk purely about functionality and not sound like some vendor doc - there are enough of those. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette