Re: [PATCH v8 05/20] job.c: add job_lock/unlock while keeping job.h intact

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Wed, Jun 29, 2022 at 10:15:23AM -0400, Emanuele Giuseppe Esposito wrote:
> With "intact" we mean that all job.h functions implicitly
> take the lock. Therefore API callers are unmodified.
> 
> This means that:
> - all static functions become _locked, and call _locked functions
> - all public functions take the lock internally, and call _locked
>   functions
> - all public functions called internally by other functions in job.c will have a
>   _locked counterpart, to avoid deadlocks (job lock already taken)
> - public functions called only from exernal files (not job.c) do not
>   have _locked() counterpart and take the lock inside
> 
> job_{lock/unlock} is independent from real_job_{lock/unlock}.
> 
> Note: at this stage, job_{lock/unlock} and job lock guard macros
> are *nop*
> 
> .Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
>  include/qemu/job.h |  73 +++++-
>  job.c              | 607 +++++++++++++++++++++++++++++++--------------
>  2 files changed, 499 insertions(+), 181 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]