From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192EEC433EF for ; Wed, 6 Jul 2022 07:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231596AbiGFHFI (ORCPT ); Wed, 6 Jul 2022 03:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231610AbiGFHEv (ORCPT ); Wed, 6 Jul 2022 03:04:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AE11222A9; Wed, 6 Jul 2022 00:04:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CF811B81AEF; Wed, 6 Jul 2022 07:04:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1095EC3411C; Wed, 6 Jul 2022 07:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657091083; bh=yFTTCN8eLFI/FFSUip2r6VUaWUpwukK1oykDBvVFoaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jvQpbiTHwHtxiL7mhpAUqPcIfklC3uMq+eSlq7Dn3j9ZoCfEt8bXAghrDvZr0IVL+ IVo2VVD6El337SyTT90L4wo/hIPFCt8NLQgPrX4IoEu6OyCSHbBsNvDzbu6ja4urNO b9ykds4BGL4/msxrju07lSQ9srOtvpaXTx1taFYM= Date: Wed, 6 Jul 2022 09:04:41 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Logan Gunthorpe , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Dan Williams , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Bjorn Helgaas Subject: Re: [PATCH v7 20/21] PCI/P2PDMA: Introduce pci_mmap_p2pmem() Message-ID: References: <20220705161240.GB13721@lst.de> <20220705164315.GB14484@lst.de> <20220705165039.GB14566@lst.de> <1bd43ef7-0403-bd25-087c-d54d5af677e4@deltatee.com> <20220706065127.GA27132@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706065127.GA27132@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jul 06, 2022 at 08:51:27AM +0200, Christoph Hellwig wrote: > On Tue, Jul 05, 2022 at 12:16:45PM -0600, Logan Gunthorpe wrote: > > The current version does it through a char device, but that requires > > creating a simple_fs and anon_inode for teardown on driver removal, plus > > a bunch of hooks through the driver that exposes it (NVMe, in this case) > > to set this all up. > > > > Christoph is suggesting a sysfs interface which could potentially avoid > > the anon_inode and all of the extra hooks. It has some significant > > benefits and maybe some small downsides, but I wouldn't describe it as > > horrid. > > Yeah, I don't think is is horrible, it fits in with the resource files > for the BARs, and solves a lot of problems. Greg, can you explain > what would be so bad about it? As you mention, you will have to pass different things down into sysfs in order for that to be possible. If it matches the resource files like we currently have today, that might not be that bad, but it still feels odd to me. Let's see an implementation and a Documentation/ABI/ entry first though. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84F27C433EF for ; Wed, 6 Jul 2022 07:04:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E4405416DC; Wed, 6 Jul 2022 07:04:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E4405416DC Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=jvQpbiTH X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IHpa_puVlECn; Wed, 6 Jul 2022 07:04:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 735DE417A8; Wed, 6 Jul 2022 07:04:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 735DE417A8 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 451DBC0077; Wed, 6 Jul 2022 07:04:50 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 11AB5C0070 for ; Wed, 6 Jul 2022 07:04:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D1E3A417A8 for ; Wed, 6 Jul 2022 07:04:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D1E3A417A8 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LC_Bu63T_u4u for ; Wed, 6 Jul 2022 07:04:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C6D48416DC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp4.osuosl.org (Postfix) with ESMTPS id C6D48416DC for ; Wed, 6 Jul 2022 07:04:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D3633B81AF2; Wed, 6 Jul 2022 07:04:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1095EC3411C; Wed, 6 Jul 2022 07:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657091083; bh=yFTTCN8eLFI/FFSUip2r6VUaWUpwukK1oykDBvVFoaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jvQpbiTHwHtxiL7mhpAUqPcIfklC3uMq+eSlq7Dn3j9ZoCfEt8bXAghrDvZr0IVL+ IVo2VVD6El337SyTT90L4wo/hIPFCt8NLQgPrX4IoEu6OyCSHbBsNvDzbu6ja4urNO b9ykds4BGL4/msxrju07lSQ9srOtvpaXTx1taFYM= Date: Wed, 6 Jul 2022 09:04:41 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Subject: Re: [PATCH v7 20/21] PCI/P2PDMA: Introduce pci_mmap_p2pmem() Message-ID: References: <20220705161240.GB13721@lst.de> <20220705164315.GB14484@lst.de> <20220705165039.GB14566@lst.de> <1bd43ef7-0403-bd25-087c-d54d5af677e4@deltatee.com> <20220706065127.GA27132@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220706065127.GA27132@lst.de> Cc: linux-pci@vger.kernel.org, Dave Hansen , linux-nvme@lists.infradead.org, Stephen Bates , linux-mm@kvack.org, Jason Ekstrand , Ira Weiny , Minturn Dave B , Martin Oliveira , Matthew Wilcox , Jason Gunthorpe , Chaitanya Kulkarni , Bjorn Helgaas , Daniel Vetter , Ralph Campbell , John Hubbard , linux-block@vger.kernel.org, Bjorn Helgaas , Dan Williams , Xiong Jianxin , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Logan Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Jul 06, 2022 at 08:51:27AM +0200, Christoph Hellwig wrote: > On Tue, Jul 05, 2022 at 12:16:45PM -0600, Logan Gunthorpe wrote: > > The current version does it through a char device, but that requires > > creating a simple_fs and anon_inode for teardown on driver removal, plus > > a bunch of hooks through the driver that exposes it (NVMe, in this case) > > to set this all up. > > > > Christoph is suggesting a sysfs interface which could potentially avoid > > the anon_inode and all of the extra hooks. It has some significant > > benefits and maybe some small downsides, but I wouldn't describe it as > > horrid. > > Yeah, I don't think is is horrible, it fits in with the resource files > for the BARs, and solves a lot of problems. Greg, can you explain > what would be so bad about it? As you mention, you will have to pass different things down into sysfs in order for that to be possible. If it matches the resource files like we currently have today, that might not be that bad, but it still feels odd to me. Let's see an implementation and a Documentation/ABI/ entry first though. thanks, greg k-h _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu