From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914A3C43334 for ; Wed, 6 Jul 2022 13:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232132AbiGFN4M (ORCPT ); Wed, 6 Jul 2022 09:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbiGFN4K (ORCPT ); Wed, 6 Jul 2022 09:56:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C33FA167EA; Wed, 6 Jul 2022 06:56:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F75761E2E; Wed, 6 Jul 2022 13:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30861C341C6; Wed, 6 Jul 2022 13:56:04 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="QO+KNfi7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1657115762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iz7TiYsQg28wABHZ/Sl8o/JBmFyo1X4h6JHxFO/2QFU=; b=QO+KNfi7bosC2YJDjjg+3/p1YBt79iQ4yagiPDOsXPXuswqtg6CW7QzzzzLHe5bYAJajqz lJ1uYpw141WbDpvaa9p1cFXyX5AAi5jWxlLdhhC1cA7kV3FkaOwez6I8Mf7z7lgI0KslPb HD4WDjK1rPD6V6STN+1QfEhFQxvzuOo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c2f90772 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 6 Jul 2022 13:56:01 +0000 (UTC) Date: Wed, 6 Jul 2022 15:55:55 +0200 From: "Jason A. Donenfeld" To: Borislav Petkov Cc: "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Alexander Gordeev , Thomas Gleixner , Greg Kroah-Hartman , Arnd Bergmann Subject: Re: [PATCH v3] random: remove CONFIG_ARCH_RANDOM Message-ID: References: <20220706003225.335768-1-Jason@zx2c4.com> <20220706105411.406259-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Borislav, On Wed, Jul 06, 2022 at 02:35:17PM +0200, Borislav Petkov wrote: > On Wed, Jul 06, 2022 at 12:54:11PM +0200, Jason A. Donenfeld wrote: > > So this commit simplifies things by removing CONFIG_ARCH_RANDOM, keeping > > No need to say "this commit" or "this patch" - just write "as if you are > giving orders to the codebase to change its behaviour." > > In this case, "So simplify things by ... " Thanks for the tip. I used to do this, and then in the last 3 weeks my style unwittingly slipped into this new thing for some reason. I've got to send a v+1 anyway for some more build breakage, so I'll fix that up. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF8CFC433EF for ; Wed, 6 Jul 2022 13:56:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LdLgg0pQlz3bxZ for ; Wed, 6 Jul 2022 23:56:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.a=rsa-sha256 header.s=20210105 header.b=QO+KNfi7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=srs0=igxa=xl=zx2c4.com=jason@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.a=rsa-sha256 header.s=20210105 header.b=QO+KNfi7; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LdLfy2smZz2xtt for ; Wed, 6 Jul 2022 23:56:10 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C71661E24; Wed, 6 Jul 2022 13:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30861C341C6; Wed, 6 Jul 2022 13:56:04 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="QO+KNfi7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1657115762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iz7TiYsQg28wABHZ/Sl8o/JBmFyo1X4h6JHxFO/2QFU=; b=QO+KNfi7bosC2YJDjjg+3/p1YBt79iQ4yagiPDOsXPXuswqtg6CW7QzzzzLHe5bYAJajqz lJ1uYpw141WbDpvaa9p1cFXyX5AAi5jWxlLdhhC1cA7kV3FkaOwez6I8Mf7z7lgI0KslPb HD4WDjK1rPD6V6STN+1QfEhFQxvzuOo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c2f90772 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 6 Jul 2022 13:56:01 +0000 (UTC) Date: Wed, 6 Jul 2022 15:55:55 +0200 From: "Jason A. Donenfeld" To: Borislav Petkov Subject: Re: [PATCH v3] random: remove CONFIG_ARCH_RANDOM Message-ID: References: <20220706003225.335768-1-Jason@zx2c4.com> <20220706105411.406259-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Arnd Bergmann , Will Deacon , Greg Kroah-Hartman , Catalin Marinas , Heiko Carstens , x86@kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Alexander Gordeev , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Borislav, On Wed, Jul 06, 2022 at 02:35:17PM +0200, Borislav Petkov wrote: > On Wed, Jul 06, 2022 at 12:54:11PM +0200, Jason A. Donenfeld wrote: > > So this commit simplifies things by removing CONFIG_ARCH_RANDOM, keeping > > No need to say "this commit" or "this patch" - just write "as if you are > giving orders to the codebase to change its behaviour." > > In this case, "So simplify things by ... " Thanks for the tip. I used to do this, and then in the last 3 weeks my style unwittingly slipped into this new thing for some reason. I've got to send a v+1 anyway for some more build breakage, so I'll fix that up. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E533C43334 for ; Wed, 6 Jul 2022 13:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4+RtU3e5nvtxqOeE5I/3Bt2GjJqTOgQI3pxr6oh60Jg=; b=mSGUNL0atLj94A pwPblPTG/6tqyccb3KheZ5blqAxAF6LXuwvOQxsnhUEqa/8qJTHpCN9Lxvyl63oiHabolJAV80UeV uYahDk6Oitv4A1BNvte9im0GoK0gMA6NJaaXEUWYM3b73O8Ix+AIfwt+gTPgmLk3jq2ySGQUBxTXv DHcyAm0ABK6UFzmbPrrEyk/mPDhhj8Li6o3ZNHAtOlHGBo2fomWZuOgCug+Gu0WtVIvZb4Q93iy65 MJq4NRV0RkJZrd2OwgOK0JQQ5iAVETbE7QhKb1+vL8NO3Aax2Xg4P+dg1DirJ6o9UvOFJYSuiEhvW 183JfLOglKBTA+H/l68g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95Vi-00ATLp-0o; Wed, 06 Jul 2022 13:56:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95Ve-00ATKW-Pd for linux-arm-kernel@lists.infradead.org; Wed, 06 Jul 2022 13:56:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C71661E24; Wed, 6 Jul 2022 13:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30861C341C6; Wed, 6 Jul 2022 13:56:04 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="QO+KNfi7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1657115762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iz7TiYsQg28wABHZ/Sl8o/JBmFyo1X4h6JHxFO/2QFU=; b=QO+KNfi7bosC2YJDjjg+3/p1YBt79iQ4yagiPDOsXPXuswqtg6CW7QzzzzLHe5bYAJajqz lJ1uYpw141WbDpvaa9p1cFXyX5AAi5jWxlLdhhC1cA7kV3FkaOwez6I8Mf7z7lgI0KslPb HD4WDjK1rPD6V6STN+1QfEhFQxvzuOo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c2f90772 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 6 Jul 2022 13:56:01 +0000 (UTC) Date: Wed, 6 Jul 2022 15:55:55 +0200 From: "Jason A. Donenfeld" To: Borislav Petkov Cc: "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Alexander Gordeev , Thomas Gleixner , Greg Kroah-Hartman , Arnd Bergmann Subject: Re: [PATCH v3] random: remove CONFIG_ARCH_RANDOM Message-ID: References: <20220706003225.335768-1-Jason@zx2c4.com> <20220706105411.406259-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_065607_105640_F3B17ED2 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Borislav, On Wed, Jul 06, 2022 at 02:35:17PM +0200, Borislav Petkov wrote: > On Wed, Jul 06, 2022 at 12:54:11PM +0200, Jason A. Donenfeld wrote: > > So this commit simplifies things by removing CONFIG_ARCH_RANDOM, keeping > > No need to say "this commit" or "this patch" - just write "as if you are > giving orders to the codebase to change its behaviour." > > In this case, "So simplify things by ... " Thanks for the tip. I used to do this, and then in the last 3 weeks my style unwittingly slipped into this new thing for some reason. I've got to send a v+1 anyway for some more build breakage, so I'll fix that up. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel