From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2 2/3] clone: propagate empty remote HEAD even with other branches
Date: Fri, 8 Jul 2022 12:08:48 -0400 [thread overview]
Message-ID: <YshWkMFy124otENI@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqedyvwr0k.fsf@gitster.g>
On Fri, Jul 08, 2022 at 08:41:47AM -0700, Junio C Hamano wrote:
> > + grep "refs/heads/mydefaultbranch" file_unborn_child/.git/HEAD &&
>
> We know they do not have mydefaultbranch2 branch, so this grep may
> be sufficient, but peeking into the implementation detail of HEAD is
> not necessary. The kosher way is way more verbose and awkward,
> though:
>
> git -C file_unborn_child symbolic-ref HEAD >actual &&
> echo refs/heads/mydefaultbranch >expect &&
> test_cmp actual expect &&
>
> I dunno.
Yeah, that occurred to me, too. I _think_ it's fine for now, even in a
reftable world, because HEAD there is always still a file.
At any rate, this was following the lead of the other tests in the file,
so my thought was to do that for now, and if we care we can convert them
all on top (maybe even with a helper).
-Peff
next prev parent reply other threads:[~2022-07-08 16:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 7:57 [PATCH 0/3] cloning unborn HEAD when other branches are present Jeff King
2022-07-06 8:00 ` [PATCH 1/3] clone: drop extra newline from warning message Jeff King
2022-07-06 8:00 ` [PATCH 2/3] clone: factor out unborn head setup into its own function Jeff King
2022-07-06 8:03 ` [PATCH 3/3] clone: propagate empty remote HEAD even with other branches Jeff King
2022-07-06 18:19 ` Junio C Hamano
2022-07-06 22:01 ` Junio C Hamano
2022-07-07 17:40 ` Jeff King
2022-07-07 18:50 ` Junio C Hamano
2022-07-07 23:54 ` [PATCH v2 0/3] cloning unborn HEAD when other branches are present Jeff King
2022-07-07 23:54 ` [PATCH v2 1/3] clone: drop extra newline from warning message Jeff King
2022-07-07 23:57 ` [PATCH v2 2/3] clone: propagate empty remote HEAD even with other branches Jeff King
2022-07-08 15:41 ` Junio C Hamano
2022-07-08 16:08 ` Jeff King [this message]
2022-07-07 23:59 ` [PATCH v2 3/3] clone: use remote branch if it matches default HEAD Jeff King
2022-07-08 16:28 ` Junio C Hamano
2022-07-08 19:30 ` Jeff King
2022-07-08 20:33 ` Junio C Hamano
2022-07-11 9:21 ` [PATCH v2 4/3] clone: move unborn head creation to update_head() Jeff King
2022-07-11 20:36 ` Junio C Hamano
2022-07-07 17:23 ` [PATCH 3/3] clone: propagate empty remote HEAD even with other branches Jeff King
2022-07-06 18:17 ` [PATCH 0/3] cloning unborn HEAD when other branches are present Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YshWkMFy124otENI@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.