From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D677CCA47B for ; Mon, 11 Jul 2022 14:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231330AbiGKOht (ORCPT ); Mon, 11 Jul 2022 10:37:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiGKOhq (ORCPT ); Mon, 11 Jul 2022 10:37:46 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CF686714B for ; Mon, 11 Jul 2022 07:37:45 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id bk26so7264761wrb.11 for ; Mon, 11 Jul 2022 07:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iJtfzfcC1AnsDV/pvGZu2fxxfQmMd6+WOUgRm2id0vA=; b=I0e3YydFgfpoaHWWDRkccW6qtvLN35SFDD/+T6Zf3YSIMWNNV3Mff+f6Xw61zVX2cs 1uWFO47xJ8qdEm8xYURWHIZELaONyqchlS9wilP7b4oGmx9pxRIAyswMWZZvBk+smMZs yt12KfMRmGjE7ITc9L9FP7FjpGG+tPFOdmowu1VcdHgpplgc5wTqflQTOes3qwN03qrq eQVm0ExSbWAc4Rs5CMLNMlspn2+A8dO/qLPCZt/mPy0Zq5OQ1y8RZVetuvUzkDzMhtXK UlvFSooupOa8nvx5j/W5rUWkIdPIT7Phoh0fet6WUybKhUPjpAePCaRIYdnqI4FifzE2 vNBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iJtfzfcC1AnsDV/pvGZu2fxxfQmMd6+WOUgRm2id0vA=; b=O7ocByOwhxTVCcXNroMzjaWlhz+utahaN9j1wRSNNTr4Q3PGx8gxlxFI+5bI+/aVLR xg6EDqdKVJCJTdh7f29RewXynDUPI8agmQzORxGjONQ9K0Vgr9yNchY5Xh4LsiRYG5kY malKw0i4bS0hN8Siaqn5Ypw9wJyN0onhdtrRg1Iz7jB6s2zrT7ciBlvHEMdP0BNZYXSR Ih0kq5Q1m7zaAjacxWrXqoE9seXSWt/Z5UIrWZr+xJDowYj2hF2hn04MS50/iLLLxs8k Mxox4lwKNYZAF94lXIArVU2G9ILKParMkaQZJkKUuHTiPh7kBmpF/vRkb69PvGz82/2Q CEyA== X-Gm-Message-State: AJIora9X9xNfaiKsrzDDj4Z7egH93FiK0XyFd1jnenUn/OtzTqUd+mfP B6Wq5boO5V+Z4DeGsGnrwJaxWg== X-Google-Smtp-Source: AGRyM1t1yyqWZwS7XrcViX/JC5qBkc6Z05thqF1oYvTfe7VDmx7hhI7m+JnQqN9Z2J8tfLCknsoQtw== X-Received: by 2002:adf:f38f:0:b0:21d:66b5:21c with SMTP id m15-20020adff38f000000b0021d66b5021cmr16896532wro.144.1657550264039; Mon, 11 Jul 2022 07:37:44 -0700 (PDT) Received: from myrica (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id k5-20020a05600c1c8500b003974cb37a94sm10468691wms.22.2022.07.11.07.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 07:37:43 -0700 (PDT) Date: Mon, 11 Jul 2022 15:37:17 +0100 From: Jean-Philippe Brucker To: Xu Kuohai Cc: bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Will Deacon , KP Singh , Mark Rutland , Catalin Marinas , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Zi Shen Lim , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Jakub Kicinski , Jesper Dangaard Brouer , Russell King , James Morse , Hou Tao , Jason Wang Subject: Re: [PATCH bpf-next v7 4/4] bpf, arm64: bpf trampoline for arm64 Message-ID: References: <20220708093032.1832755-1-xukuohai@huawei.com> <20220708093032.1832755-5-xukuohai@huawei.com> <4852eba8-9fd0-6894-934c-ab89c0c7cea9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4852eba8-9fd0-6894-934c-ab89c0c7cea9@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2022 at 10:16:00PM +0800, Xu Kuohai wrote: > >> + if (save_ret) > >> + emit(A64_STR64I(p->jited ? r0 : A64_R(0), A64_SP, retval_off), > >> + ctx); > > > > This should be only A64_R(0), not r0. r0 happens to equal A64_R(0) when > > jitted due to the way build_epilogue() builds the function at the moment, > > but we shouldn't rely on that. > > > > looks like I misunderstood something, will change it to: > > /* store return value, which is held in x0 for interpreter and in > * bpf register r0 for JIT, It's simpler than that: in both cases the return value is in x0 because the function follows the procedure call standard. You could drop the comment to avoid confusion and only do the change to A64_R(0) Thanks, Jean > > > but r0 happens to equal x0 due to the > * way build_epilogue() builds the JIT image. > */ > if (save_ret) > emit(A64_STR64I(A64_R(0), A64_SP, retval_off), ctx); > > > Apart from that, for the series > > > > Reviewed-by: Jean-Philippe Brucker > > > > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4257BC433EF for ; Mon, 11 Jul 2022 14:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iIK2Ap1lwqi2ldcYU4S8A22jCz7sD7JPlzXIRCxwuvg=; b=Kt3pPTKfbAdanc zR0tGNsekDzTn7FSYZwRAZ3lj4kmQVB1vI3gjkEt0brWGnRWknpk15X2L9sXzhrhK1bDV75wHLmDl Y+YxVd6kuoziyB+gz/h8Mdh2O9hxKMeNO9LV0TlMQnDpO0DYgpsvr3mj4LPKeubWjWEf9ViZgdqSw aEde3vDlTttYRNTYsRec9tm/hUYKxkKxwDXrcWhdeoy7NZzf1z916jHwhZVEO674BUGctK/Y/9drP HvcxEaIdq2nX0m4sst/PFBbFxHeRnYPxaKQTHVpMQiYczPZnlp5SBlG7puS9n0H8FYrIJDc1fsGa+ siog9O2cOerZ1ky+fM/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAuXm-002OgF-Uj; Mon, 11 Jul 2022 14:37:51 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAuXj-002Odk-7a for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 14:37:48 +0000 Received: by mail-wr1-x433.google.com with SMTP id q9so7284652wrd.8 for ; Mon, 11 Jul 2022 07:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iJtfzfcC1AnsDV/pvGZu2fxxfQmMd6+WOUgRm2id0vA=; b=I0e3YydFgfpoaHWWDRkccW6qtvLN35SFDD/+T6Zf3YSIMWNNV3Mff+f6Xw61zVX2cs 1uWFO47xJ8qdEm8xYURWHIZELaONyqchlS9wilP7b4oGmx9pxRIAyswMWZZvBk+smMZs yt12KfMRmGjE7ITc9L9FP7FjpGG+tPFOdmowu1VcdHgpplgc5wTqflQTOes3qwN03qrq eQVm0ExSbWAc4Rs5CMLNMlspn2+A8dO/qLPCZt/mPy0Zq5OQ1y8RZVetuvUzkDzMhtXK UlvFSooupOa8nvx5j/W5rUWkIdPIT7Phoh0fet6WUybKhUPjpAePCaRIYdnqI4FifzE2 vNBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iJtfzfcC1AnsDV/pvGZu2fxxfQmMd6+WOUgRm2id0vA=; b=kgCEGFIe2X1pDiFNkUooPyWSCYdzcbIUShGgAyfkk+t8pnJYK/CkNu+jK/yunC4dnb poyFmMPR2KU6i+KWaa74FYSn5EFY8DQoJDx0+HKBSJ4/FCY5SawaGurt67gZyYaDWeFT j8guKAuTyjwww6NFKb1cX7nzRwIjKiSJVJRHGBTk6mo8pscTHFW4HPyq9k8P6FmawGDA lPs/5SLzTHFunc3yp6qGyXqILs+6FW9/zvER4kWJN0g97Pyu6V1aJ9KMSOFYMaGtewb7 mNqUd+8xyhpAOOGaCNd38NPApd3vsp2yCjvsnYDyySKTbODzXxeOMSd+qnnwXURZ/6Ev eWMg== X-Gm-Message-State: AJIora+Nr9CQw16Q8n1TpNn5xrZnAtCIEoVqzaAcOloms1YSYvJunDvA 1HZlTQ1V94QhrHlrx+DqUL7oGw== X-Google-Smtp-Source: AGRyM1t1yyqWZwS7XrcViX/JC5qBkc6Z05thqF1oYvTfe7VDmx7hhI7m+JnQqN9Z2J8tfLCknsoQtw== X-Received: by 2002:adf:f38f:0:b0:21d:66b5:21c with SMTP id m15-20020adff38f000000b0021d66b5021cmr16896532wro.144.1657550264039; Mon, 11 Jul 2022 07:37:44 -0700 (PDT) Received: from myrica (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id k5-20020a05600c1c8500b003974cb37a94sm10468691wms.22.2022.07.11.07.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 07:37:43 -0700 (PDT) Date: Mon, 11 Jul 2022 15:37:17 +0100 From: Jean-Philippe Brucker To: Xu Kuohai Cc: bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Will Deacon , KP Singh , Mark Rutland , Catalin Marinas , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Zi Shen Lim , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Jakub Kicinski , Jesper Dangaard Brouer , Russell King , James Morse , Hou Tao , Jason Wang Subject: Re: [PATCH bpf-next v7 4/4] bpf, arm64: bpf trampoline for arm64 Message-ID: References: <20220708093032.1832755-1-xukuohai@huawei.com> <20220708093032.1832755-5-xukuohai@huawei.com> <4852eba8-9fd0-6894-934c-ab89c0c7cea9@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4852eba8-9fd0-6894-934c-ab89c0c7cea9@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_073747_291382_4FA4B76F X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 11, 2022 at 10:16:00PM +0800, Xu Kuohai wrote: > >> + if (save_ret) > >> + emit(A64_STR64I(p->jited ? r0 : A64_R(0), A64_SP, retval_off), > >> + ctx); > > > > This should be only A64_R(0), not r0. r0 happens to equal A64_R(0) when > > jitted due to the way build_epilogue() builds the function at the moment, > > but we shouldn't rely on that. > > > > looks like I misunderstood something, will change it to: > > /* store return value, which is held in x0 for interpreter and in > * bpf register r0 for JIT, It's simpler than that: in both cases the return value is in x0 because the function follows the procedure call standard. You could drop the comment to avoid confusion and only do the change to A64_R(0) Thanks, Jean > > > but r0 happens to equal x0 due to the > * way build_epilogue() builds the JIT image. > */ > if (save_ret) > emit(A64_STR64I(A64_R(0), A64_SP, retval_off), ctx); > > > Apart from that, for the series > > > > Reviewed-by: Jean-Philippe Brucker > > > > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel