From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD994C43334 for ; Sun, 24 Jul 2022 17:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbiGXR2F (ORCPT ); Sun, 24 Jul 2022 13:28:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiGXR2E (ORCPT ); Sun, 24 Jul 2022 13:28:04 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5705220D for ; Sun, 24 Jul 2022 10:28:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CBBF01FCEB; Sun, 24 Jul 2022 17:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1658683680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wzfsiw8ZlcskU2nqSWByWEzgGhFE2hdppcQ4jWRoqD8=; b=a+4df5/ccPELDA7DlIpSJ9DJ3uT4qpypn9sDPB8sYkBNRJCzRVuNo/k4Oi7glwEMIfQpSq jr7AXeapIPpwbDDnE7LFYi9CUbIqjdRzjN8xW2gQ7cspUM24w8RmnpjU20yhNQNDfFWawH dJCNGWx8ocfeTL4VIDKJ9sARl31wmtc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1658683680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wzfsiw8ZlcskU2nqSWByWEzgGhFE2hdppcQ4jWRoqD8=; b=NtHUjPQh3JpL8NQ1iohkCSQHy2AVXGmdRMPkypG+AcuVOz8oHQMTV4YanISxTkJDM7YzNE QzXu+9jrmygnEwAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B8AC013A8D; Sun, 24 Jul 2022 17:28:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fIOdLCCB3WJjWAAAMHmgww (envelope-from ); Sun, 24 Jul 2022 17:28:00 +0000 Date: Sun, 24 Jul 2022 19:27:56 +0200 From: Borislav Petkov To: Ard Biesheuvel Cc: Linus Torvalds , linux-efi , Thomas Gleixner , Thadeu Lima de Souza Cascardo , Peter Zijlstra , Josh Poimboeuf Subject: Re: [PATCH] efi/x86-mixed: leave RET unmitigated but move it into .rodata Message-ID: References: <20220722160612.2976-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Sun, Jul 24, 2022 at 10:39:45AM +0200, Ard Biesheuvel wrote: > Fair enough. I still think it is better for general hygiene to apply > these changes, but if there is no urgency, I'll leave this for now and > revisit+rebase somewhere during the next cycle. Best it would be if you do that early in the cycle so that it gets maximum testing in linux-next. Oh, and my compiler doesn't like it for whatever reason: /tmp/ccLB2vIC.s: Assembler messages: /tmp/ccLB2vIC.s: Error: invalid operands (.rodata and .text sections) for `-' when setting `.L__sym_size___efi64_thunk' make[3]: *** [scripts/Makefile.build:322: arch/x86/platform/efi/efi_thunk_64.o] Error 1 make[3]: *** Waiting for unfinished jobs.... But otherwise, I like the direction where this is going, of us not mapping as much into the EFI PGT. But I've said that already... Thx. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH GF: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman (HRB 36809, AG Nürnberg)