From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE20C43334 for ; Tue, 19 Jul 2022 03:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236001AbiGSD5h (ORCPT ); Mon, 18 Jul 2022 23:57:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235721AbiGSD5f (ORCPT ); Mon, 18 Jul 2022 23:57:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4781630545; Mon, 18 Jul 2022 20:57:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9447A614E2; Tue, 19 Jul 2022 03:57:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02326C341C6; Tue, 19 Jul 2022 03:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658203048; bh=bk7kiNkFCjTJlkPO94NstHDQP0wVKlshtC8iPTo6tTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jqvdJJi2eLu11yA7R710yNYh1SakfUeULGK+XGuSlOgmNfJwlZa2uy+nSWyHmsxjx PO8ncJNDH21V7vMtdAh321VHcf7ZNEqcTZfpACy0px0EhGACvOijHqv6ui2JexC83H NN1j3NJEPqUl3gCmQmDG4Ymk8QZlt+Sz25J6Y19OvCrI0Q+gBsjc9LiOzP/OceCXtr uEcoHIkng4gnxjIf92auTEWTmZ3bjUFN9EGtPWN9pcKkSIx1Ee4i1X2lAVREO+/dQb Q6OcGbU5d+zbshoxsXhjosqEB9rsuVTpGBeWfL9s0Ukdwgg6lNjn+KnTjbpueMvwQn DRfG4JqjEZHKA== Date: Tue, 19 Jul 2022 05:57:18 +0200 From: Wolfram Sang To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Kamal Dasu , Broadcom internal kernel review list , "open list:BROADCOM BRCMSTB I2C DRIVER" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts Message-ID: Mail-Followup-To: Wolfram Sang , Florian Fainelli , linux-kernel@vger.kernel.org, Kamal Dasu , Broadcom internal kernel review list , "open list:BROADCOM BRCMSTB I2C DRIVER" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20220706172115.224240-1-f.fainelli@gmail.com> <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gow9lImvwwFsbBJv" Content-Disposition: inline In-Reply-To: <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gow9lImvwwFsbBJv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > I was not sure if we could change the adapter name reported as one could > argue this is now ABI, but if we can, then using dev_name() is probably > better. You are the maintainer you so know the rules on what is considered > stable ABI and what is not :) Well, then even removing ":" would break the ABI :) Please use dev_name. Other drivers changed that string, too. We never gave guarantees for that one. --gow9lImvwwFsbBJv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmLWK5oACgkQFA3kzBSg KbbkwQ/+NOLKvOH/5XckE2kb+8VHFvBgNdMSJMTz3taSGcC0N4N85TReOXkWBCrk Q/R9cHH7O9LCNZmNc0RJZu0ilKh+wYqagtDG8jID4/8LTw1jqylhM2qtZS0mNEPT btHwYYEr8qRipEh2ISn5RNEDDYmdje3HHsPOJPgraRUIo9tVdwyp+yW2bsrH+7h5 r17Lk4klVFqa5Vrw4Q9KtCanNw3AHKRo515os459fIE/dHFMeTIYuFyMxA5WT7wG QtEgfDCBRGR0YSuUfbAMCt2Xe2+y0heh0P0/0BcGuSqiT3HXAg3nz9gMHa9cV7Pd vxxv4ByayzZFtpOZnZcr0etLfJPqcRS/LfDXx7lo3z6ZHprfBR+WfRBYZcGyFgga eqWxMLkavU9ez9dISA/H+SBRljX01rug67ejrfEVzs43XWFugSbSkII5Bbk5nVs6 Z0tv4y0K7jN4vTTMEqcB+gVQ+03XxeU3ORVn5mFe1a7vjN+IiUt3ezKaDSkg192v wM2QY6srSot3kq2nPjgKuO0VPHOEPHYmMei4kPLOIXUG5p00SdAVVz3othv/octp 7CseCHtVIZhClyFlh/WJ3Uas1kPLp1abZMEqmUoMUviBu0GDwsS3GQY4W5P724du BM3CfsAx2FjC0wJW5YqGcg/dDJ2zbLBs6DQmT7ikBhm+TEwzVF4= =6qHV -----END PGP SIGNATURE----- --gow9lImvwwFsbBJv-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08313C43334 for ; Tue, 19 Jul 2022 03:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zodBD7IvU1xNjlNxq8FuueyE63ISvmBIojLeKUW2f/E=; b=wlicj//oCFcj8eiXJpzt2GJfKy U3HU3tRb54mo40sdaX3SUsxgeqw+83m1RWnKSJTEm5kU7bDN9OWcYanWQmMDLmO8dJpxzh8/G9Ok0 82OnWYOHTqeBbLJcwUldIu2a9ZGW+K6yWRWgR5eam8a9bKX9ncFC9FqJVCpoD6zwxDpjLEIyjfDvy aMyIkyxwhcPp204YSyHvhPpHXO7daKTV9hQB/xqZQQXw67PP3LifRZK98Ab5vv+zamuEM0yVAMaML Yqoz3q5uM4p81rRGlDVTsomMcKqu6zviT3PlHCBPdkeJaEDLf2AwTOgbcp10ahnaC6mhRy63HupgD +3NW2peg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDeMb-004aZd-3D; Tue, 19 Jul 2022 03:57:37 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDeMX-004aYX-8J for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 03:57:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12517B817B0; Tue, 19 Jul 2022 03:57:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02326C341C6; Tue, 19 Jul 2022 03:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658203048; bh=bk7kiNkFCjTJlkPO94NstHDQP0wVKlshtC8iPTo6tTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jqvdJJi2eLu11yA7R710yNYh1SakfUeULGK+XGuSlOgmNfJwlZa2uy+nSWyHmsxjx PO8ncJNDH21V7vMtdAh321VHcf7ZNEqcTZfpACy0px0EhGACvOijHqv6ui2JexC83H NN1j3NJEPqUl3gCmQmDG4Ymk8QZlt+Sz25J6Y19OvCrI0Q+gBsjc9LiOzP/OceCXtr uEcoHIkng4gnxjIf92auTEWTmZ3bjUFN9EGtPWN9pcKkSIx1Ee4i1X2lAVREO+/dQb Q6OcGbU5d+zbshoxsXhjosqEB9rsuVTpGBeWfL9s0Ukdwgg6lNjn+KnTjbpueMvwQn DRfG4JqjEZHKA== Date: Tue, 19 Jul 2022 05:57:18 +0200 From: Wolfram Sang To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Kamal Dasu , Broadcom internal kernel review list , "open list:BROADCOM BRCMSTB I2C DRIVER" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts Message-ID: Mail-Followup-To: Wolfram Sang , Florian Fainelli , linux-kernel@vger.kernel.org, Kamal Dasu , Broadcom internal kernel review list , "open list:BROADCOM BRCMSTB I2C DRIVER" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20220706172115.224240-1-f.fainelli@gmail.com> <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com> MIME-Version: 1.0 In-Reply-To: <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_205733_490597_027FAE15 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7420532900871135727==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7420532900871135727== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gow9lImvwwFsbBJv" Content-Disposition: inline --gow9lImvwwFsbBJv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > I was not sure if we could change the adapter name reported as one could > argue this is now ABI, but if we can, then using dev_name() is probably > better. You are the maintainer you so know the rules on what is considered > stable ABI and what is not :) Well, then even removing ":" would break the ABI :) Please use dev_name. Other drivers changed that string, too. We never gave guarantees for that one. --gow9lImvwwFsbBJv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmLWK5oACgkQFA3kzBSg KbbkwQ/+NOLKvOH/5XckE2kb+8VHFvBgNdMSJMTz3taSGcC0N4N85TReOXkWBCrk Q/R9cHH7O9LCNZmNc0RJZu0ilKh+wYqagtDG8jID4/8LTw1jqylhM2qtZS0mNEPT btHwYYEr8qRipEh2ISn5RNEDDYmdje3HHsPOJPgraRUIo9tVdwyp+yW2bsrH+7h5 r17Lk4klVFqa5Vrw4Q9KtCanNw3AHKRo515os459fIE/dHFMeTIYuFyMxA5WT7wG QtEgfDCBRGR0YSuUfbAMCt2Xe2+y0heh0P0/0BcGuSqiT3HXAg3nz9gMHa9cV7Pd vxxv4ByayzZFtpOZnZcr0etLfJPqcRS/LfDXx7lo3z6ZHprfBR+WfRBYZcGyFgga eqWxMLkavU9ez9dISA/H+SBRljX01rug67ejrfEVzs43XWFugSbSkII5Bbk5nVs6 Z0tv4y0K7jN4vTTMEqcB+gVQ+03XxeU3ORVn5mFe1a7vjN+IiUt3ezKaDSkg192v wM2QY6srSot3kq2nPjgKuO0VPHOEPHYmMei4kPLOIXUG5p00SdAVVz3othv/octp 7CseCHtVIZhClyFlh/WJ3Uas1kPLp1abZMEqmUoMUviBu0GDwsS3GQY4W5P724du BM3CfsAx2FjC0wJW5YqGcg/dDJ2zbLBs6DQmT7ikBhm+TEwzVF4= =6qHV -----END PGP SIGNATURE----- --gow9lImvwwFsbBJv-- --===============7420532900871135727== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7420532900871135727==--