From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3C7C43334 for ; Tue, 19 Jul 2022 13:32:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B23634CB6C; Tue, 19 Jul 2022 09:32:31 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s7b8xPrxGQWB; Tue, 19 Jul 2022 09:32:26 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DFC7C4CB5A; Tue, 19 Jul 2022 09:32:26 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7EBC34CB5A for ; Tue, 19 Jul 2022 09:32:25 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LkpBP27giG8j for ; Tue, 19 Jul 2022 09:32:24 -0400 (EDT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 524BF4C8C3 for ; Tue, 19 Jul 2022 09:32:24 -0400 (EDT) Received: by mail-wr1-f41.google.com with SMTP id a5so21588282wrx.12 for ; Tue, 19 Jul 2022 06:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FrozUrwgIOtPZPU7Vt+EwKFtk6342ujDLZysxCGk/2U=; b=S5+hpwih6SZVqj/aZj22GkTtB6kZfbDkhiG9Hf++s/M60OXgNZ/J9S/iUKontqxajh OzXnE52J9XzWdiwGbTqN1ITAQKNwzA4v3az0hShMM6Va2ngQvc5JMkF4xEx34Jek+4hX xqIY6w51YepwMJdLLJUAeAc+jbuEZPdqniB9QcMW0l12HW6bgo5C0nE5rvUq5oSo93eZ MgfZljgodBz8jCjeI/ve6kl4ger6fvg1/P9WWN/hiiTxkThSTx5Uc9CpWqBpwNbmYBkb YMB6utRhH5yLR2qAIvbA/yi19l14EDbTsMIcnboJI/3gyW6RtBzaRL/gtAshqmzTkcXa 2b3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FrozUrwgIOtPZPU7Vt+EwKFtk6342ujDLZysxCGk/2U=; b=JBNYa/HcZQt/CZ74Mb2D/ebQrCNF3PNULLyWcL65I5ic1qu0n2eUT0irc6BCYGLzSh R/uu5cocnFDapuwW/Wc5J1uk4JtcO66+95lQc15VK3SGUaG69URPdukB4jkPOUSoOm76 OL9/yYJIUY4qStBvY/D1fUwJZ/FPB+d9Wo70z+w2VJYGyT4OOo3rfDsUrg9E0Tb4B7FL NJAuO1sJ4RRp3H18AZ4XsAMkx/2qndk+NSDkQBvpMQeyhK2bBBKkrOf7830b+tplefl6 x3TdORQQVpROQcsaGF8cjrUwNtR8FGagXAXNr9iUZdUM4shlNy4b5SqjyLPgRmDZiXLZ v+SA== X-Gm-Message-State: AJIora9uyVXpB852ebh3Li7L44GoPOJfiUrowRcCvEHjX7N2HNmjFc35 TMHGHDMLFGzULFBKtEIX3+tqOQ== X-Google-Smtp-Source: AGRyM1tBOCHh1mly6SNagRp9Dh5EU1Ka18SIzDcfqYtAbUecvNXPxURgsOuO1nVIX4WV8COO/Prb7A== X-Received: by 2002:a05:6000:1081:b0:21d:6b27:b12d with SMTP id y1-20020a056000108100b0021d6b27b12dmr25759245wrw.504.1658237543035; Tue, 19 Jul 2022 06:32:23 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id i4-20020a05600c354400b003a2c7bf0497sm17206016wmq.16.2022.07.19.06.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 06:32:22 -0700 (PDT) Date: Tue, 19 Jul 2022 14:32:18 +0100 From: Vincent Donnefort To: Will Deacon Subject: Re: [PATCH v2 18/24] KVM: arm64: Instantiate guest stage-2 page-tables at EL2 Message-ID: References: <20220630135747.26983-1-will@kernel.org> <20220630135747.26983-19-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220630135747.26983-19-will@kernel.org> Cc: Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Oliver Upton , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, Michael Roth , Catalin Marinas , Chao Peng , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu [...] > } > > void reclaim_guest_pages(struct kvm_shadow_vm *vm) > { > - unsigned long nr_pages; > + unsigned long nr_pages, pfn; > > nr_pages = kvm_pgtable_stage2_pgd_size(vm->kvm.arch.vtcr) >> PAGE_SHIFT; > - WARN_ON(__pkvm_hyp_donate_host(hyp_virt_to_pfn(vm->pgt.pgd), nr_pages)); > + pfn = hyp_virt_to_pfn(vm->pgt.pgd); > + > + guest_lock_component(vm); > + kvm_pgtable_stage2_destroy(&vm->pgt); > + vm->kvm.arch.mmu.pgd_phys = 0ULL; > + guest_unlock_component(vm); > + > + WARN_ON(__pkvm_hyp_donate_host(pfn, nr_pages)); > } The pfn introduction being removed in a subsequent patch, this is probably unecessary noise. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8490DC43334 for ; Tue, 19 Jul 2022 13:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TQNcXvasduFyiyjhEg+Cojr/xbcVVl+iZnd8JrXEbYs=; b=2B7z6aXWqlljXX v6X9FJc2LbmD3Hxd2O83A+pjhNye0Los1FTNzqfPxzBzRleA2hWNz2yJd4mw2KLZvxM76WSlOrBgL t1GPpo9aWMq4Fq+G3wfo3uUFcvj4S5klVbhQae9PzuYPPSlp6OSnxibVD7+Betu2jQLNEVilYz9nr Wr6H6mfOJxsrsW7B3tOBtd7nrqFKq5R2zmOaCIYaymWEiA/UhIjNvZY3+vfJ5JHsx0v7mh/VcNFdO FWjJGLj5CQTFYExzP2slZ4UlZxwMy44MkKgVDbvPzbEmV55LyOdBJTBmODJjuDoW+HBlYh5JBmt55 BtXgWskFleU73rM1t09w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnKv-009EHK-AF; Tue, 19 Jul 2022 13:32:29 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnKt-009EEe-0f for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 13:32:28 +0000 Received: by mail-wr1-x42f.google.com with SMTP id e15so16364573wro.5 for ; Tue, 19 Jul 2022 06:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FrozUrwgIOtPZPU7Vt+EwKFtk6342ujDLZysxCGk/2U=; b=S5+hpwih6SZVqj/aZj22GkTtB6kZfbDkhiG9Hf++s/M60OXgNZ/J9S/iUKontqxajh OzXnE52J9XzWdiwGbTqN1ITAQKNwzA4v3az0hShMM6Va2ngQvc5JMkF4xEx34Jek+4hX xqIY6w51YepwMJdLLJUAeAc+jbuEZPdqniB9QcMW0l12HW6bgo5C0nE5rvUq5oSo93eZ MgfZljgodBz8jCjeI/ve6kl4ger6fvg1/P9WWN/hiiTxkThSTx5Uc9CpWqBpwNbmYBkb YMB6utRhH5yLR2qAIvbA/yi19l14EDbTsMIcnboJI/3gyW6RtBzaRL/gtAshqmzTkcXa 2b3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FrozUrwgIOtPZPU7Vt+EwKFtk6342ujDLZysxCGk/2U=; b=J4M4D1sKD+SjN/qJTVhuKSCrMxFQLFu2BT3Vw3eQRLnsTyPAH9Fjt2IBWcGJ2mnSpy UzKC5uFrnHZRIX2zWYdYJ2vk9p15Q4PGy2eCHeu4bXaSRoLHrhdN75wEAuYFtKr/jTyO sM/MeRutWDHh1qIq/2tP/F0iZLARuAiHua29/glD0l7/dhemxBGkFm3LIQqfk+cjbxht zRX7qZr3S3HMZI3qerfT7w7IyBD05cNNbAhtxcgyxDt0F0pGz4rTOB1AFevU+3KllhE1 O/9S91K8hwVdVsQ4y6l/eTKSifmom0zLTV2QGRx0+TFPN2V58catxbFEadeLFpXddhh6 dRsA== X-Gm-Message-State: AJIora+RZ7d6x4Fz8QSwnxBYNX9QjTyAuL1FTJ39KRvpYwhoH3u+9Wnx EvkdBPIbKrulv+DzcbVcLz4gOg== X-Google-Smtp-Source: AGRyM1tBOCHh1mly6SNagRp9Dh5EU1Ka18SIzDcfqYtAbUecvNXPxURgsOuO1nVIX4WV8COO/Prb7A== X-Received: by 2002:a05:6000:1081:b0:21d:6b27:b12d with SMTP id y1-20020a056000108100b0021d6b27b12dmr25759245wrw.504.1658237543035; Tue, 19 Jul 2022 06:32:23 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id i4-20020a05600c354400b003a2c7bf0497sm17206016wmq.16.2022.07.19.06.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 06:32:22 -0700 (PDT) Date: Tue, 19 Jul 2022 14:32:18 +0100 From: Vincent Donnefort To: Will Deacon Cc: kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 18/24] KVM: arm64: Instantiate guest stage-2 page-tables at EL2 Message-ID: References: <20220630135747.26983-1-will@kernel.org> <20220630135747.26983-19-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220630135747.26983-19-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_063227_091572_60579342 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [...] > } > > void reclaim_guest_pages(struct kvm_shadow_vm *vm) > { > - unsigned long nr_pages; > + unsigned long nr_pages, pfn; > > nr_pages = kvm_pgtable_stage2_pgd_size(vm->kvm.arch.vtcr) >> PAGE_SHIFT; > - WARN_ON(__pkvm_hyp_donate_host(hyp_virt_to_pfn(vm->pgt.pgd), nr_pages)); > + pfn = hyp_virt_to_pfn(vm->pgt.pgd); > + > + guest_lock_component(vm); > + kvm_pgtable_stage2_destroy(&vm->pgt); > + vm->kvm.arch.mmu.pgd_phys = 0ULL; > + guest_unlock_component(vm); > + > + WARN_ON(__pkvm_hyp_donate_host(pfn, nr_pages)); > } The pfn introduction being removed in a subsequent patch, this is probably unecessary noise. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D95EBC433EF for ; Tue, 19 Jul 2022 14:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238922AbiGSOL4 (ORCPT ); Tue, 19 Jul 2022 10:11:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238777AbiGSOLg (ORCPT ); Tue, 19 Jul 2022 10:11:36 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD7A804B4 for ; Tue, 19 Jul 2022 06:32:24 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id r14so21657218wrg.1 for ; Tue, 19 Jul 2022 06:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FrozUrwgIOtPZPU7Vt+EwKFtk6342ujDLZysxCGk/2U=; b=S5+hpwih6SZVqj/aZj22GkTtB6kZfbDkhiG9Hf++s/M60OXgNZ/J9S/iUKontqxajh OzXnE52J9XzWdiwGbTqN1ITAQKNwzA4v3az0hShMM6Va2ngQvc5JMkF4xEx34Jek+4hX xqIY6w51YepwMJdLLJUAeAc+jbuEZPdqniB9QcMW0l12HW6bgo5C0nE5rvUq5oSo93eZ MgfZljgodBz8jCjeI/ve6kl4ger6fvg1/P9WWN/hiiTxkThSTx5Uc9CpWqBpwNbmYBkb YMB6utRhH5yLR2qAIvbA/yi19l14EDbTsMIcnboJI/3gyW6RtBzaRL/gtAshqmzTkcXa 2b3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FrozUrwgIOtPZPU7Vt+EwKFtk6342ujDLZysxCGk/2U=; b=TN/R5tuaXO1dFmvVceYL59N+znPki66XOS6gVBFVezPMNMbDqi1nzOA4KM9N7Jjwm6 UzSUXXc59gbDUPpW2RU0DVn8nV2ef2LVexTECYAvjZFTh194ZoXngvuU/SfCR3AdSsmh eWGd2BweDCNjeppg0hBCnLWq9iNxl5OWbRsNXs55VuEIzfWamzIhnyuZBJgt3aRtKYfU iJ/5k1qf6K2EW/ei5QlAVfeFYKqvJkkkEHPK3L2h3cx8YngAGo2K2oVFvEoO6gLiSEjP UIcgErZPLEiBEpJNTZawZcOcjoPY0N0DwUwGMrA6YrjIPIkI0CEOSLVkL5/IpsLLOX8U FAsg== X-Gm-Message-State: AJIora94lm4VItA/0Q0a2wJjAwdFhshJv0doVnIxgr6J1bVI0fPvbbLi YJuSMoC4okbd3N98wke5vBi39Q== X-Google-Smtp-Source: AGRyM1tBOCHh1mly6SNagRp9Dh5EU1Ka18SIzDcfqYtAbUecvNXPxURgsOuO1nVIX4WV8COO/Prb7A== X-Received: by 2002:a05:6000:1081:b0:21d:6b27:b12d with SMTP id y1-20020a056000108100b0021d6b27b12dmr25759245wrw.504.1658237543035; Tue, 19 Jul 2022 06:32:23 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id i4-20020a05600c354400b003a2c7bf0497sm17206016wmq.16.2022.07.19.06.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 06:32:22 -0700 (PDT) Date: Tue, 19 Jul 2022 14:32:18 +0100 From: Vincent Donnefort To: Will Deacon Cc: kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 18/24] KVM: arm64: Instantiate guest stage-2 page-tables at EL2 Message-ID: References: <20220630135747.26983-1-will@kernel.org> <20220630135747.26983-19-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630135747.26983-19-will@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org [...] > } > > void reclaim_guest_pages(struct kvm_shadow_vm *vm) > { > - unsigned long nr_pages; > + unsigned long nr_pages, pfn; > > nr_pages = kvm_pgtable_stage2_pgd_size(vm->kvm.arch.vtcr) >> PAGE_SHIFT; > - WARN_ON(__pkvm_hyp_donate_host(hyp_virt_to_pfn(vm->pgt.pgd), nr_pages)); > + pfn = hyp_virt_to_pfn(vm->pgt.pgd); > + > + guest_lock_component(vm); > + kvm_pgtable_stage2_destroy(&vm->pgt); > + vm->kvm.arch.mmu.pgd_phys = 0ULL; > + guest_unlock_component(vm); > + > + WARN_ON(__pkvm_hyp_donate_host(pfn, nr_pages)); > } The pfn introduction being removed in a subsequent patch, this is probably unecessary noise.