From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E1BC43334 for ; Wed, 20 Jul 2022 06:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbiGTGdm (ORCPT ); Wed, 20 Jul 2022 02:33:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232597AbiGTGdl (ORCPT ); Wed, 20 Jul 2022 02:33:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F0875925E for ; Tue, 19 Jul 2022 23:33:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DB104B81D5C for ; Wed, 20 Jul 2022 06:33:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20388C3411E; Wed, 20 Jul 2022 06:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658298814; bh=39oZdu+K0quf0QE+0o7BPycVsWNv+Dtz6IySVyE9CQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XMYEPeB+PfKYexDaeZdK8BlSjPycmiOgCw8dhZGAEd5VRxYn682kR9LxZTeZTkPbJ cJiN23zIKBAiNujD+ICAQJZjCBSxZGeGKxS8ZswapJWoFEnm1DNXmRcY8/dsVh82nu VCyyyt0zQdUkWpP+8XUi/k/mt1DvMqyb7hO4lvCoaQPbRQ4RpbJ1tJD3nqI2JUrEdo pyljitHHJN9avcKX/WQr1zJ87WON9UKkzI2QlCTgn3bx5KnkXhjfEjtxvYxMdaQ3we jZMk2H4V7QRfpmRz/9HR76pdPv6SotSOH5Xq/YtTYaAxcBUBPQR4v0C42hJbpyQqAG 1QQcVpSACFQbQ== Date: Wed, 20 Jul 2022 09:33:30 +0300 From: Leon Romanovsky To: "lizhijian@fujitsu.com" Cc: Yanjun Zhu , Jason Gunthorpe , Haakon Bugge , "linux-rdma@vger.kernel.org" , Bob Pearson , Cheng Xu Subject: Re: [PATCH v5 0/4] RDMA/rxe: Fix no completion event issue Message-ID: References: <20220704060806.1622849-1-lizhijian@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Jul 20, 2022 at 06:21:29AM +0000, lizhijian@fujitsu.com wrote: > Hi Leon > > > On 20/07/2022 13:38, Leon Romanovsky wrote: > > On Mon, Jul 04, 2022 at 06:00:54AM +0000, lizhijian@fujitsu.com wrote: > > > > Please fix your gitconfig to have same From/author fields as in Signed-off-by. > > I'm sorry about that, tay I know which patch has something wrong? I have not updated these fields recently. > Do you mean "[PATCH v5 3/4] RDMA/rxe: Split qp state for requester and completer" which is from Bob. So > I keep his author and SOB. No, I'm talking about something else. Almost all your patches are sent with wrong "From:" field. Let's take your first patch as an example: https://lore.kernel.org/linux-rdma/20220704060806.1622849-2-lizhijian@fujitsu.com/ From: "lizhijian@fujitsu.com" ... Signed-off-by: Li Zhijian and if i try to apply it, the checkpatch will throw the following error: ➜ kernel git:(rdma-next) ✗ git am --continue Applying: RDMA/rxe: Update wqe_index for each wqe error completion ➜ kernel git:(rdma-next) git checkpatch WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: qp->req.wqe_index==queue.index in next round, req_next_wqe() will treat queue WARNING: From:/Signed-off-by: email name mismatch: 'From: "lizhijian@fujitsu.com" ' != 'Signed-off-by: Li Zhijian ' 0001-RDMA-rxe-Update-wqe_index-for-each-wqe-error-complet.patch total: 0 errors, 2 warnings, 8 lines checked > > Thanks > Zhijian > > > > > > Thanks