From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB3E0C43334 for ; Wed, 20 Jul 2022 18:46:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231831AbiGTSqC (ORCPT ); Wed, 20 Jul 2022 14:46:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbiGTSp6 (ORCPT ); Wed, 20 Jul 2022 14:45:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21A7CDF0B; Wed, 20 Jul 2022 11:45:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7357B821B4; Wed, 20 Jul 2022 18:45:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F990C3411E; Wed, 20 Jul 2022 18:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658342755; bh=BPQTo+ZMfUwnwE9+Ibb9aPcdaThaA2NZNCEJsUhFYb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rpiu+lMOe7LQw/XQwmcjijloEwn1YnudjjKKMYUVSvWT5SbnUfgaZeMK62bUm7xXf 2f/mreg3MhoNdFgbpQBx4qWmwVKQMXhtql6GqzEWknr211aiFb7V+wStgsWkXdVS6y wlJB7BQXhhJkhuXpSE92LzZS53GZEETkB4RzTkZDDsZMlc1qCLQRmpsKMXq8ciGny0 GZGz74tOKpaVKXCo465haSW5yfeKCWgyAdf8IbdIb2/KymyjAC1uZMnJg3YjKPUYPd W9POy3dIVtWdg7MNvqjbLxRRfRJz4irpSIpI6Cj8t01nP9UhmlEsUS+jtN+zrqO17n g9BUMvIwM/weg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id A625E40374; Wed, 20 Jul 2022 15:45:51 -0300 (-03) Date: Wed, 20 Jul 2022 15:45:51 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , Will Deacon , James Clark , German Gomez , Ali Saidi , Joe Mario , Adam Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kajol Jain Subject: Re: [PATCH v5 01/17] perf: Add SNOOP_PEER flag to perf mem data struct Message-ID: References: <20220604042820.2270916-1-leo.yan@linaro.org> <20220604042820.2270916-2-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220604042820.2270916-2-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Jun 04, 2022 at 12:28:04PM +0800, Leo Yan escreveu: > From: Ali Saidi > > Add a flag to the perf mem data struct to signal that a request caused a > cache-to-cache transfer of a line from a peer of the requestor and > wasn't sourced from a lower cache level. The line being moved from one > peer cache to another has latency and performance implications. On Arm64 > Neoverse systems the data source can indicate a cache-to-cache transfer > but not if the line is dirty or clean, so instead of overloading HITM > define a new flag that indicates this type of transfer. > > Signed-off-by: Ali Saidi > Reviewed-by: Leo Yan > Reviewed-by: Kajol Jain Hey, any knews about this going upstream? PeterZ? - Arnaldo > --- > include/uapi/linux/perf_event.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index d37629dbad72..7b88bfd097dc 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -1310,7 +1310,7 @@ union perf_mem_data_src { > #define PERF_MEM_SNOOP_SHIFT 19 > > #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ > -/* 1 free */ > +#define PERF_MEM_SNOOPX_PEER 0x02 /* xfer from peer */ > #define PERF_MEM_SNOOPX_SHIFT 38 > > /* locked instruction */ > -- > 2.25.1 -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FCE9C433EF for ; Wed, 20 Jul 2022 18:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FgoGtmYwXC0CcIAoeit8z9DMCC6GWboBtz7ufFnHKsY=; b=TBmj2i1xNnHyIV e4pjqTOAxUBA8BpGNOH5W6PF2a2BBIEhpWyHT/7cBTqh9uuwWgOTB6A1msY+WoIYj+znMV7S5Gkqq ulS5TGzmM3L+YeAPtrTt7sUQmfqXCafPY2vJ67QqXdQWGYfodXp4wKH4uGTyLJQJ0PgHSqDckiHfj PDWqRb9lJ3bmUZ5tp3n979QFKt5NVYG9kjUx2MPmWhDvalSsWxhUPcXMTKGBTLbvx+wGpoXQ/Nbvs 522q7cP+RlUKtG0afFMNn5917+/U1u+sQswS1UhIxPIRHHje/GwdMfwG+qwpuXBihYrqEqGnV8Y3c IpdmJ6+XQYj9Regd4OVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEEhr-009TXV-Dd; Wed, 20 Jul 2022 18:45:59 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEEhq-009TWW-7D for linux-arm-kernel@bombadil.infradead.org; Wed, 20 Jul 2022 18:45:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zVxTcAKYxr6zgo99bjNNcvquAqEG3JXh5Q1FGt4/ppo=; b=mm4pQbc4p/lKjlMZADHmF5CG/J iHRmi1BXKlSEXqEce3aSv5LD1YLnj3E54t0dpjQ8ZMJwALKJsUQ4flzx+6gaxYNMLqxBXwSSXPhft OL7cmw2z0fBhixTWMRhk68WYz3n3W50KtOtH66vss+WR0Iht2E1gU1zf1nthKKzQVJIH3kiv/cdkX seFMsBVTAMQyIJlS6ittApMT5MJCQkgW0//j+1G6a299wg5/bw7Fp5zoVSzJe9vFHLoAyvkSLLaKe gAbjbkisLZpAQPofxiySGkChLoIKQ5Opo92//uuLpCMvuTNAtk09o3O+ThSiCDK7A++xmzhiHtfee RfdYJkBA==; Received: from [187.19.239.32] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEEhn-005Nls-JL; Wed, 20 Jul 2022 18:45:56 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id A625E40374; Wed, 20 Jul 2022 15:45:51 -0300 (-03) Date: Wed, 20 Jul 2022 15:45:51 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , Will Deacon , James Clark , German Gomez , Ali Saidi , Joe Mario , Adam Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kajol Jain Subject: Re: [PATCH v5 01/17] perf: Add SNOOP_PEER flag to perf mem data struct Message-ID: References: <20220604042820.2270916-1-leo.yan@linaro.org> <20220604042820.2270916-2-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220604042820.2270916-2-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Sat, Jun 04, 2022 at 12:28:04PM +0800, Leo Yan escreveu: > From: Ali Saidi > > Add a flag to the perf mem data struct to signal that a request caused a > cache-to-cache transfer of a line from a peer of the requestor and > wasn't sourced from a lower cache level. The line being moved from one > peer cache to another has latency and performance implications. On Arm64 > Neoverse systems the data source can indicate a cache-to-cache transfer > but not if the line is dirty or clean, so instead of overloading HITM > define a new flag that indicates this type of transfer. > > Signed-off-by: Ali Saidi > Reviewed-by: Leo Yan > Reviewed-by: Kajol Jain Hey, any knews about this going upstream? PeterZ? - Arnaldo > --- > include/uapi/linux/perf_event.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index d37629dbad72..7b88bfd097dc 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -1310,7 +1310,7 @@ union perf_mem_data_src { > #define PERF_MEM_SNOOP_SHIFT 19 > > #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ > -/* 1 free */ > +#define PERF_MEM_SNOOPX_PEER 0x02 /* xfer from peer */ > #define PERF_MEM_SNOOPX_SHIFT 38 > > /* locked instruction */ > -- > 2.25.1 -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel