All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: John Ogness <john.ogness@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v2] printk: Skip console drivers on PREEMPT_RT.
Date: Thu, 21 Jul 2022 08:50:38 +0200	[thread overview]
Message-ID: <Ytj3PisFjOfS9L0Y@linutronix.de> (raw)
In-Reply-To: <87ilnrn06u.fsf@jogness.linutronix.de>

printk might be invoked in a context with disabled interrupts and or
preemption and additionally disables interrupts before it invokes the
console drivers. This is behaviour is not compatible with PREEMPT_RT.

Disable console printing until the return of atomic consoles and the
printing thread. This allows to retrieve the log buffer from user space
which is not possible by disable printk.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
v1…v2:
   - Use __console_unlock() as suggested by John.

 kernel/printk/printk.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2843,6 +2843,16 @@ void console_unlock(void)
 	}
 
 	/*
+	 * On PREEMPT_RT it is not possible to invoke console drivers with
+	 * disabled interrupts and or preemption. Therefore all drivers are
+	 * skipped and the output can be retrieved from the buffer.
+	 */
+	if (IS_ENABLED(CONFIG_PREEMPT_RT)) {
+		__console_unlock();
+		return;
+	}
+
+	/*
 	 * Console drivers are called with interrupts disabled, so
 	 * @console_may_schedule should be cleared before; however, we may
 	 * end up dumping a lot of lines, for example, if called from

  reply	other threads:[~2022-07-21  6:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 15:48 [PATCH] printk: Skip console drivers on PREEMPT_RT Sebastian Andrzej Siewior
2022-07-20 16:26 ` John Ogness
2022-07-20 16:35   ` Sebastian Andrzej Siewior
2022-07-20 17:50     ` John Ogness
2022-07-21  6:50       ` Sebastian Andrzej Siewior [this message]
2022-07-22 12:39         ` [PATCH v2] " Petr Mladek
2022-07-22 17:03           ` Sebastian Andrzej Siewior
2022-07-25 12:30             ` Petr Mladek
2022-07-25 12:51               ` John Ogness
2022-07-25 13:55               ` Sebastian Andrzej Siewior
2022-07-25 14:24                 ` Petr Mladek
2022-07-25 15:16                   ` [PATCH v3] " Sebastian Andrzej Siewior
2022-07-26  7:39                     ` Petr Mladek
2022-07-26  7:57                     ` John Ogness
2022-07-26 13:11                       ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ytj3PisFjOfS9L0Y@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.