From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF212C43334 for ; Thu, 21 Jul 2022 22:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234040AbiGUWAL (ORCPT ); Thu, 21 Jul 2022 18:00:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234000AbiGUWAI (ORCPT ); Thu, 21 Jul 2022 18:00:08 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 827C1339 for ; Thu, 21 Jul 2022 15:00:05 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id t3-20020a17090a3b4300b001f21eb7e8b0so5956352pjf.1 for ; Thu, 21 Jul 2022 15:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7gujx4/vn7+YQjww67d8XBsvreA1sJCQ6MzDAhjTGYE=; b=fuqsh1fdgWgyWIc3fyOeUlM0zge5cMl9ja2YPhfmZaLQUb4GzD/h/rXb4XU5wYi5gz emIaaSuEyLgh3bCaXJVJ/NFX0ntkQZnOtKlVYksiAGvxFLct8I91wYSSh3wvRVVUFJHO 8Vj9F9FNB2ZcxFiPlFey/al8u/sSTFnSrTNkc3iXHEM0ZAaNjDfV0O3q3JpA0s9pyjWt oMD1/v0EyEu8iSCu63aJLtVvQy5qhW6Fi7afpnn5Bg8E2k35c5xxI7NRLkzj6ddOOGDN friI4hPRN++XZFhEe4saVRA+N8GcvRbmA4NLvfLVFfR7Ppy4g8XTu734gCXm+h3ZiGWs Wlkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7gujx4/vn7+YQjww67d8XBsvreA1sJCQ6MzDAhjTGYE=; b=SLk9gjvJcElJiFMuNMwMnAUWKT+I/N2kjtPsxjlOXt5DFYlmab0+4giyqT/FOZcWvA NDow0zAbgTH930Vkf02RQx/yeYGOMh/hkXhug32HhYYwEBeL/FNXabA/r2BvVUZG87Yb cQS+AJM5CrmMVWvLNYIjysHbQ038r5efdMSMs08Ip6XvMwWXODdTOn7KhMdD4edbvUs4 AV7Xk8pqs8cU2SCXOI1dQIyGSJil/UlGGlpBVu45boOsGWUaC32U0bqVAswST9ejzqdP 1bWFmA4PIyhJ+RTtFJlI9RcD+1C+O+5ShGf0UynKJOUgbkKdk9sN9MtXXE7/ih/4pE2s QUlw== X-Gm-Message-State: AJIora9H/xvqL1XyywWsidBwd1LmPA6EVxbTOtjo7NWobwAmOtumuFGH qcoxKNfTYUIvv1AI7ILdJemdjg== X-Google-Smtp-Source: AGRyM1sY/4JL0WvYhndZ87X4aQbb6i7KlSC28zRbWT8KnZlwPKrRh5hGkUHGV+oWANevxZgcFbtYWQ== X-Received: by 2002:a17:903:11d2:b0:167:8a0f:8d33 with SMTP id q18-20020a17090311d200b001678a0f8d33mr509111plh.95.1658440804817; Thu, 21 Jul 2022 15:00:04 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id 82-20020a621455000000b0052bae7b2af8sm2243275pfu.201.2022.07.21.15.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 15:00:04 -0700 (PDT) Date: Thu, 21 Jul 2022 22:00:00 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Anirudh Rayabharam , Wanpeng Li , Jim Mattson , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/25] KVM: VMX: Check VM_ENTRY_IA32E_MODE in setup_vmcs_config() Message-ID: References: <20220714091327.1085353-1-vkuznets@redhat.com> <20220714091327.1085353-13-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220714091327.1085353-13-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022, Vitaly Kuznetsov wrote: > VM_ENTRY_IA32E_MODE control is toggled dynamically by vmx_set_efer() > and setup_vmcs_config() doesn't check its existence. On the contrary, > nested_vmx_setup_ctls_msrs() doesn set it on x86_64. Add the missing > check and filter the bit out in vmx_vmentry_ctrl(). > > No (real) functional change intended as all existing CPUs supporting > long mode and VMX are supposed to have it. > > Reviewed-by: Maxim Levitsky > Reviewed-by: Jim Mattson > Signed-off-by: Vitaly Kuznetsov > --- Reviewed-by: Sean Christopherson