* [PATCH] i2c: brcmstb: Use dev_name() for adapter name
@ 2022-07-19 4:06 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-07-19 4:06 UTC (permalink / raw)
To: linux-kernel
Cc: Florian Fainelli, Kamal Dasu,
Broadcom internal kernel review list,
open list:BROADCOM BRCMSTB I2C DRIVER,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE
This make it easier to disambiguate the different i2c controllers
present in a system, and then correlating with /proc/interrupts allows
to know which instance is interrupt driven and which one is not.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/i2c/busses/i2c-brcmstb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
index b00f35c0b066..3ba6cbbe84ac 100644
--- a/drivers/i2c/busses/i2c-brcmstb.c
+++ b/drivers/i2c/busses/i2c-brcmstb.c
@@ -684,9 +684,7 @@ static int brcmstb_i2c_probe(struct platform_device *pdev)
adap = &dev->adapter;
i2c_set_adapdata(adap, dev);
adap->owner = THIS_MODULE;
- strlcpy(adap->name, "Broadcom STB : ", sizeof(adap->name));
- if (int_name)
- strlcat(adap->name, int_name, sizeof(adap->name));
+ strlcpy(adap->name, dev_name(&pdev->dev), sizeof(adap->name));
adap->algo = &brcmstb_i2c_algo;
adap->dev.parent = &pdev->dev;
adap->dev.of_node = pdev->dev.of_node;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] i2c: brcmstb: Use dev_name() for adapter name
@ 2022-07-19 4:06 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-07-19 4:06 UTC (permalink / raw)
To: linux-kernel
Cc: Florian Fainelli, Kamal Dasu,
Broadcom internal kernel review list,
open list:BROADCOM BRCMSTB I2C DRIVER,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE
This make it easier to disambiguate the different i2c controllers
present in a system, and then correlating with /proc/interrupts allows
to know which instance is interrupt driven and which one is not.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/i2c/busses/i2c-brcmstb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
index b00f35c0b066..3ba6cbbe84ac 100644
--- a/drivers/i2c/busses/i2c-brcmstb.c
+++ b/drivers/i2c/busses/i2c-brcmstb.c
@@ -684,9 +684,7 @@ static int brcmstb_i2c_probe(struct platform_device *pdev)
adap = &dev->adapter;
i2c_set_adapdata(adap, dev);
adap->owner = THIS_MODULE;
- strlcpy(adap->name, "Broadcom STB : ", sizeof(adap->name));
- if (int_name)
- strlcat(adap->name, int_name, sizeof(adap->name));
+ strlcpy(adap->name, dev_name(&pdev->dev), sizeof(adap->name));
adap->algo = &brcmstb_i2c_algo;
adap->dev.parent = &pdev->dev;
adap->dev.of_node = pdev->dev.of_node;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: brcmstb: Use dev_name() for adapter name
2022-07-19 4:06 ` Florian Fainelli
@ 2022-07-22 16:57 ` Wolfram Sang
-1 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-07-22 16:57 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, Kamal Dasu, Broadcom internal kernel review list,
open list:BROADCOM BRCMSTB I2C DRIVER,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On Mon, Jul 18, 2022 at 09:06:10PM -0700, Florian Fainelli wrote:
> This make it easier to disambiguate the different i2c controllers
> present in a system, and then correlating with /proc/interrupts allows
> to know which instance is interrupt driven and which one is not.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: brcmstb: Use dev_name() for adapter name
@ 2022-07-22 16:57 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-07-22 16:57 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, Kamal Dasu, Broadcom internal kernel review list,
open list:BROADCOM BRCMSTB I2C DRIVER,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE
[-- Attachment #1.1: Type: text/plain, Size: 374 bytes --]
On Mon, Jul 18, 2022 at 09:06:10PM -0700, Florian Fainelli wrote:
> This make it easier to disambiguate the different i2c controllers
> present in a system, and then correlating with /proc/interrupts allows
> to know which instance is interrupt driven and which one is not.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-22 16:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 4:06 [PATCH] i2c: brcmstb: Use dev_name() for adapter name Florian Fainelli
2022-07-19 4:06 ` Florian Fainelli
2022-07-22 16:57 ` Wolfram Sang
2022-07-22 16:57 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.