From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EE4C433EF for ; Fri, 22 Jul 2022 18:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235843AbiGVSBk (ORCPT ); Fri, 22 Jul 2022 14:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235478AbiGVSBj (ORCPT ); Fri, 22 Jul 2022 14:01:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E4613F93; Fri, 22 Jul 2022 11:01:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7EBA622D7; Fri, 22 Jul 2022 18:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BD37C341C6; Fri, 22 Jul 2022 18:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658512897; bh=eZLmaZ6G6g5lqte/Ys+R+WbUlvjke0UdT436JFR7AIM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nb+MLDqg88rYpbxrrfNfRc3ai+Ysgc0CNPh7FHGrlUDATD+ocIqvXJ35tQf8Bmawh fE/cI36MPvhsPcQIEhiw3qEsB4d7Dp6H4DbdzLuTBavZPesmUF+6OFjJd9AFdAJqGO B/XHy9HhApKhY4eZZy36dUhtt1FI6m6yNjJRjYWQtdQZ/5tYk42FDjBb4DssM3uIul hQ0LWohGSZnoZuTya3nHC378UU7PqhPSOwIAFbotzkmPb6lPPW2Er35I/Sf2szA2Z7 miaWI/J/IP25LAYqpG5O/gmsdoXc2D+QzitWgWXBRjCgDsKcNTpveYwNeye2N76blH qv3frkibWXyxw== Date: Fri, 22 Jul 2022 18:01:35 +0000 From: Eric Biggers To: Keith Busch Cc: Keith Busch , Jaegeuk Kim , Chao Yu , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@kernel.dk, Kernel Team , hch@lst.de, bvanassche@acm.org, damien.lemoal@opensource.wdc.com, pankydev8@gmail.com, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCHv6 11/11] iomap: add support for dma aligned direct-io Message-ID: References: <20220610195830.3574005-1-kbusch@fb.com> <20220610195830.3574005-12-kbusch@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Jul 22, 2022 at 08:43:55AM -0600, Keith Busch wrote: > On Fri, Jul 22, 2022 at 12:36:01AM -0700, Eric Biggers wrote: > > [+f2fs list and maintainers] > > > > On Fri, Jun 10, 2022 at 12:58:30PM -0700, Keith Busch wrote: > > > From: Keith Busch > > > > > > Use the address alignment requirements from the block_device for direct > > > io instead of requiring addresses be aligned to the block size. > > > > > > Signed-off-by: Keith Busch > > > Reviewed-by: Christoph Hellwig > > > --- > > > fs/iomap/direct-io.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > > > index 370c3241618a..5d098adba443 100644 > > > --- a/fs/iomap/direct-io.c > > > +++ b/fs/iomap/direct-io.c > > > @@ -242,7 +242,6 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter, > > > struct inode *inode = iter->inode; > > > unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev)); > > > unsigned int fs_block_size = i_blocksize(inode), pad; > > > - unsigned int align = iov_iter_alignment(dio->submit.iter); > > > loff_t length = iomap_length(iter); > > > loff_t pos = iter->pos; > > > unsigned int bio_opf; > > > @@ -253,7 +252,8 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter, > > > size_t copied = 0; > > > size_t orig_count; > > > > > > - if ((pos | length | align) & ((1 << blkbits) - 1)) > > > + if ((pos | length) & ((1 << blkbits) - 1) || > > > + !bdev_iter_is_aligned(iomap->bdev, dio->submit.iter)) > > > return -EINVAL; > > > > > > if (iomap->type == IOMAP_UNWRITTEN) { > > > > I noticed that this patch is going to break the following logic in > > f2fs_should_use_dio() in fs/f2fs/file.c: > > > > /* > > * Direct I/O not aligned to the disk's logical_block_size will be > > * attempted, but will fail with -EINVAL. > > * > > * f2fs additionally requires that direct I/O be aligned to the > > * filesystem block size, which is often a stricter requirement. > > * However, f2fs traditionally falls back to buffered I/O on requests > > * that are logical_block_size-aligned but not fs-block aligned. > > * > > * The below logic implements this behavior. > > */ > > align = iocb->ki_pos | iov_iter_alignment(iter); > > if (!IS_ALIGNED(align, i_blocksize(inode)) && > > IS_ALIGNED(align, bdev_logical_block_size(inode->i_sb->s_bdev))) > > return false; > > > > return true; > > > > So, f2fs assumes that __iomap_dio_rw() returns an error if the I/O isn't logical > > block aligned. This patch changes that. The result is that DIO will sometimes > > proceed in cases where the I/O doesn't have the fs block alignment required by > > f2fs for all DIO. > > > > Does anyone have any thoughts about what f2fs should be doing here? I think > > it's weird that f2fs has different behaviors for different degrees of > > misalignment: fail with EINVAL if not logical block aligned, else fallback to > > buffered I/O if not fs block aligned. I think it should be one convention or > > the other. Any opinions about which one it should be? > > It looks like f2fs just falls back to buffered IO for this condition without > reaching the new code in iomap_dio_bio_iter(). No. It's a bit subtle, so read the code and what I'm saying carefully. f2fs only supports 4K aligned DIO and normally falls back to buffered I/O; however, for DIO that is *very* misaligned (not even LBS aligned) it returns EINVAL instead. And it relies on __iomap_dio_rw() returning that EINVAL. Relying on __iomap_dio_rw() in that way is definitely a bad design on f2fs's part (and I messed that up when switching f2fs from fs/direct-io.c to iomap). The obvious fix is to just have f2fs do the LBS alignment check itself. But I think that f2fs shouldn't have different behavior for different levels of misalignment in the first place, so I was wondering if anyone had any thoughts on which behavior (EINVAL or fallback to buffered I/O) should be standardized on in all cases, at least for f2fs. There was some discussion about this sort of thing for ext4 several years ago on the thread https://lore.kernel.org/linux-ext4/1461472078-20104-1-git-send-email-tytso@mit.edu/T/#u, but it didn't really reach a conclusion. I'm wondering if the f2fs maintainers have any thoughts about why the f2fs behavior is as it is. I.e. is it just accidental, or are there specific reasons... - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94FA2C43334 for ; Fri, 22 Jul 2022 18:01:53 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1oEwyF-0007Je-Iy; Fri, 22 Jul 2022 18:01:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oEwyE-0007JY-Et for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Jul 2022 18:01:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UE2SWZ2sFwWhMvaaUBgTFpKTAm6g6UxtGH9gIlpyzRg=; b=PtI9cYihaU9a4XpF4Ua/mm2MGj diGUYi1F4FlSbUu4/j+hPyXXP+OZLyi6+1xO0sFEJDZlfhly3pQ5RPPUbdijvr3v2BkBnNPNmMB01 KWeZmRBfY4eqQnrVmBCz6m7FHGQMSUv1oui3D0Cvxr3nT5zk2/6SyAkUXyWUgtP8QT2s=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UE2SWZ2sFwWhMvaaUBgTFpKTAm6g6UxtGH9gIlpyzRg=; b=RxbQZsGnmp1vBEXWAJmBzM2DiS 28O5x60K5HZjZac4rKGG1tRfHI9onyiEpr+vHGsVJcEeaA/ZseEIwfiFkVozbWI5c74frjLMkbim9 Orz8DH7VLT43OG/I9pL4eVNx2qY2Cxb8yPl45efasf00V//UJXNrayLeVxA6OjKqa9lo=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1oEwy8-0004x1-Oc for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Jul 2022 18:01:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78338B82977; Fri, 22 Jul 2022 18:01:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BD37C341C6; Fri, 22 Jul 2022 18:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658512897; bh=eZLmaZ6G6g5lqte/Ys+R+WbUlvjke0UdT436JFR7AIM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nb+MLDqg88rYpbxrrfNfRc3ai+Ysgc0CNPh7FHGrlUDATD+ocIqvXJ35tQf8Bmawh fE/cI36MPvhsPcQIEhiw3qEsB4d7Dp6H4DbdzLuTBavZPesmUF+6OFjJd9AFdAJqGO B/XHy9HhApKhY4eZZy36dUhtt1FI6m6yNjJRjYWQtdQZ/5tYk42FDjBb4DssM3uIul hQ0LWohGSZnoZuTya3nHC378UU7PqhPSOwIAFbotzkmPb6lPPW2Er35I/Sf2szA2Z7 miaWI/J/IP25LAYqpG5O/gmsdoXc2D+QzitWgWXBRjCgDsKcNTpveYwNeye2N76blH qv3frkibWXyxw== Date: Fri, 22 Jul 2022 18:01:35 +0000 From: Eric Biggers To: Keith Busch Message-ID: References: <20220610195830.3574005-1-kbusch@fb.com> <20220610195830.3574005-12-kbusch@fb.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1oEwy8-0004x1-Oc Subject: Re: [f2fs-dev] [PATCHv6 11/11] iomap: add support for dma aligned direct-io X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, bvanassche@acm.org, pankydev8@gmail.com, damien.lemoal@opensource.wdc.com, linux-nvme@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, Keith Busch , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Kernel Team , hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Jul 22, 2022 at 08:43:55AM -0600, Keith Busch wrote: > On Fri, Jul 22, 2022 at 12:36:01AM -0700, Eric Biggers wrote: > > [+f2fs list and maintainers] > > > > On Fri, Jun 10, 2022 at 12:58:30PM -0700, Keith Busch wrote: > > > From: Keith Busch > > > > > > Use the address alignment requirements from the block_device for direct > > > io instead of requiring addresses be aligned to the block size. > > > > > > Signed-off-by: Keith Busch > > > Reviewed-by: Christoph Hellwig > > > --- > > > fs/iomap/direct-io.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > > > index 370c3241618a..5d098adba443 100644 > > > --- a/fs/iomap/direct-io.c > > > +++ b/fs/iomap/direct-io.c > > > @@ -242,7 +242,6 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter, > > > struct inode *inode = iter->inode; > > > unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev)); > > > unsigned int fs_block_size = i_blocksize(inode), pad; > > > - unsigned int align = iov_iter_alignment(dio->submit.iter); > > > loff_t length = iomap_length(iter); > > > loff_t pos = iter->pos; > > > unsigned int bio_opf; > > > @@ -253,7 +252,8 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter, > > > size_t copied = 0; > > > size_t orig_count; > > > > > > - if ((pos | length | align) & ((1 << blkbits) - 1)) > > > + if ((pos | length) & ((1 << blkbits) - 1) || > > > + !bdev_iter_is_aligned(iomap->bdev, dio->submit.iter)) > > > return -EINVAL; > > > > > > if (iomap->type == IOMAP_UNWRITTEN) { > > > > I noticed that this patch is going to break the following logic in > > f2fs_should_use_dio() in fs/f2fs/file.c: > > > > /* > > * Direct I/O not aligned to the disk's logical_block_size will be > > * attempted, but will fail with -EINVAL. > > * > > * f2fs additionally requires that direct I/O be aligned to the > > * filesystem block size, which is often a stricter requirement. > > * However, f2fs traditionally falls back to buffered I/O on requests > > * that are logical_block_size-aligned but not fs-block aligned. > > * > > * The below logic implements this behavior. > > */ > > align = iocb->ki_pos | iov_iter_alignment(iter); > > if (!IS_ALIGNED(align, i_blocksize(inode)) && > > IS_ALIGNED(align, bdev_logical_block_size(inode->i_sb->s_bdev))) > > return false; > > > > return true; > > > > So, f2fs assumes that __iomap_dio_rw() returns an error if the I/O isn't logical > > block aligned. This patch changes that. The result is that DIO will sometimes > > proceed in cases where the I/O doesn't have the fs block alignment required by > > f2fs for all DIO. > > > > Does anyone have any thoughts about what f2fs should be doing here? I think > > it's weird that f2fs has different behaviors for different degrees of > > misalignment: fail with EINVAL if not logical block aligned, else fallback to > > buffered I/O if not fs block aligned. I think it should be one convention or > > the other. Any opinions about which one it should be? > > It looks like f2fs just falls back to buffered IO for this condition without > reaching the new code in iomap_dio_bio_iter(). No. It's a bit subtle, so read the code and what I'm saying carefully. f2fs only supports 4K aligned DIO and normally falls back to buffered I/O; however, for DIO that is *very* misaligned (not even LBS aligned) it returns EINVAL instead. And it relies on __iomap_dio_rw() returning that EINVAL. Relying on __iomap_dio_rw() in that way is definitely a bad design on f2fs's part (and I messed that up when switching f2fs from fs/direct-io.c to iomap). The obvious fix is to just have f2fs do the LBS alignment check itself. But I think that f2fs shouldn't have different behavior for different levels of misalignment in the first place, so I was wondering if anyone had any thoughts on which behavior (EINVAL or fallback to buffered I/O) should be standardized on in all cases, at least for f2fs. There was some discussion about this sort of thing for ext4 several years ago on the thread https://lore.kernel.org/linux-ext4/1461472078-20104-1-git-send-email-tytso@mit.edu/T/#u, but it didn't really reach a conclusion. I'm wondering if the f2fs maintainers have any thoughts about why the f2fs behavior is as it is. I.e. is it just accidental, or are there specific reasons... - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel