From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3902DC04A68 for ; Wed, 27 Jul 2022 13:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233598AbiG0NJc (ORCPT ); Wed, 27 Jul 2022 09:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbiG0NJ3 (ORCPT ); Wed, 27 Jul 2022 09:09:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C566F3C for ; Wed, 27 Jul 2022 06:09:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEEFD6165E for ; Wed, 27 Jul 2022 13:09:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0747C433D6; Wed, 27 Jul 2022 13:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658927368; bh=IYDLcAKXv/t7eNqAwBTA6CMf/htt9xYg7+mFITnxwmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1mvs57IjIqp4Fh7iev+2LO1V+4e1RjgVA+QWd4SvGXfL5pI6p80JJ1/oAsIVhowfE IMvVdA/9Aa5/xHLVf+nH9BocrQVmhcc4AmtIbkY33+uBADHWIDzwWMpHKHZP4mPrg0 LZ5aQGXq3FQSKIk9B1zKeK9Ei9wMrA1j56dm5RCI= Date: Wed, 27 Jul 2022 15:09:25 +0200 From: Greg KH To: Jiho Chu Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, yelini.jeong@samsung.com, myungjoo.ham@samsung.com Subject: Re: [PATCH 4/9] trinity: Add schduler module Message-ID: References: <20220725065308.2457024-1-jiho.chu@samsung.com> <20220725065308.2457024-5-jiho.chu@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220725065308.2457024-5-jiho.chu@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2022 at 03:53:03PM +0900, Jiho Chu wrote: > This patch includes NPU scheduler interface. > > Tasks can be pushed to the NPU in order by the scheduler. The default > schduling algorithm is provided using Priority policy. > The scheduler waits request from the user. When the requests are > invoked, it submits each request to the NPU by the priority, and waits > until complete interrupt arrives. The priority is calculated with > remained time to requested timeout. > > Thus the scheduler algorithm may be added more in the later, it > provides an interface which can support various schedulers. Please do not add interfaces that you do not use at all. Just make it simple for the first version and then, if you really need to add new types of "schedulers" add them later on. As it is, this is a whole layer of abstraction that is not needed and can be removed. thanks, greg k-h