From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B8FC04A68 for ; Wed, 27 Jul 2022 13:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233733AbiG0NPj (ORCPT ); Wed, 27 Jul 2022 09:15:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233711AbiG0NPa (ORCPT ); Wed, 27 Jul 2022 09:15:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EB662019B for ; Wed, 27 Jul 2022 06:15:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2F47616E8 for ; Wed, 27 Jul 2022 13:15:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED042C433C1; Wed, 27 Jul 2022 13:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658927728; bh=+YT+ojoK3bYTC00tyuvmILyv2F2d7TCBW5svs+Jz8OU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cKcxWSE27As7BZFD/QEEnFfa1/w1NtyCUV4fIphw+Ii2MRRPPr7pUBZwMKy+fyDaT k06w5zwLlP+IR/MBHxp2l9+EgOictrpwPimQeJQdl+Gq2DpjBbpAXWz8c4mrzkjUqj wdwjXJ/97uesu1//W3Qkqoo8FxDxirTAQi/Dypvo= Date: Wed, 27 Jul 2022 15:15:25 +0200 From: Greg KH To: Jiho Chu Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, yelini.jeong@samsung.com, myungjoo.ham@samsung.com Subject: Re: [PATCH 2/9] tirnity: Add dma memory module Message-ID: References: <20220725065308.2457024-1-jiho.chu@samsung.com> <20220725065308.2457024-3-jiho.chu@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220725065308.2457024-3-jiho.chu@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2022 at 03:53:01PM +0900, Jiho Chu wrote: > This patch includes memory management module. > > It provides abstraction layer to handle DMA buffer. Again, no abstactions please. Get this working and merged properly first, before worrying about any sort of additional hardware models or abstractions. It just makes this so much harder to review and to determine what you really are, or are not, using here. So far, it seems you aren't using any of these new abstractions, which is odd. Or I just can't find them. Either way that's a huge sign this code is wrong and needs to be cleaned up. thanks, greg k-h