From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA02CC04A68 for ; Wed, 27 Jul 2022 16:48:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240365AbiG0QsF (ORCPT ); Wed, 27 Jul 2022 12:48:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240369AbiG0QrM (ORCPT ); Wed, 27 Jul 2022 12:47:12 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BADBE52E5F for ; Wed, 27 Jul 2022 09:32:05 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id r186so16364313pgr.2 for ; Wed, 27 Jul 2022 09:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1TRS6lxdC7P+TgLzuseNCh/XM3JcRUBPWPh5jtlW9yA=; b=dylDx0BBPfbwR7b/4kCuHZNaewyhKf5EOaExE5+Kmb0Pj2jzay+RWZ14VpWqECHOTk Sp3FkxlOqqWYYd3pW90Y8QZnjg9fm8cQ2+LW7SOTSoINdunWBr4AWGeLkupMEUTTojDm zcmBr6qR6DjwtD0RwfLopOIHZfWoOFLWU61yw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1TRS6lxdC7P+TgLzuseNCh/XM3JcRUBPWPh5jtlW9yA=; b=BwMtAeR4OZOICL5hN/D9dVdDuKlKavd+rRtGKuxRG5Qr5owy7SLJz6GPawVKxipaVe S8oOTkqeQLZYnPG7W2uuHb7IYKjCr9SivkXlKpbmmZ+GnPxGH0tXWoQaucR/1o1rLnRP 19frlSqwUPFwEqTREAYWsu7t5QWup5bk01OorFNzbo7s/021nKA5a4fTulnc3H9YM5iY bBL3CC4f8of+yNBV8K0JR65vPyOarI+nf5FZ6X+SdDMUo1lEuKnvnY9hRdCDlyWg+fhb adNG7h+2qPKwk+l53Fsqq5KIjntb284tQbnUj5mHgLai7TRZ/NFrqFlEcWWJ6qlAVFsf I8JQ== X-Gm-Message-State: AJIora9Q52c3WR3iavI5rmHbp0VQ/Aff1P7ziUMBqC+sK+A8rZOEXnTV 1BUJLGeVB5QCKPJ3ihP6gsLc9Q== X-Google-Smtp-Source: AGRyM1vQU2jYl7HdvxRw2AE0c/TAVSrUdt4XzX2IDRlho/1FNtKWLInu4htlin0G04xwOjmNqQqI0A== X-Received: by 2002:a63:ba18:0:b0:412:afd5:1260 with SMTP id k24-20020a63ba18000000b00412afd51260mr20009579pgf.617.1658939525302; Wed, 27 Jul 2022 09:32:05 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:472c:7351:bacf:5228]) by smtp.gmail.com with UTF8SMTPSA id z28-20020aa7949c000000b0052516db7123sm14089324pfk.35.2022.07.27.09.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 09:32:04 -0700 (PDT) Date: Wed, 27 Jul 2022 09:32:03 -0700 From: Matthias Kaehlcke To: Alexander Stein Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/3] usb: misc: onboard_usb_hub: Add reset-gpio support Message-ID: References: <20220727093801.687361-1-alexander.stein@ew.tq-group.com> <20220727093801.687361-2-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220727093801.687361-2-alexander.stein@ew.tq-group.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Alexander, On Wed, Jul 27, 2022 at 11:38:00AM +0200, Alexander Stein wrote: > Despite default reset upon probe, release reset line after powering up > the hub and assert reset again before powering down. > > Signed-off-by: Alexander Stein > --- > Thanks Matthias for your review. > > Changes in v3: > * Require platform data unconditionally > * Removed unecessary checks for that reason > * Merged power_stable_time into reset_duration (no difference for now) > * Rename 'reset_duration' to 'reset_us' > * Renamed platform structure to onboard_hub_pdata > * Renamed device struct field to pdata as well > > Changes in v2: > * Use device specific sleep times, if present > * Use fsleep instead of usleep_range > > drivers/usb/misc/onboard_usb_hub.c | 28 ++++++++++++++++++++++++++++ > drivers/usb/misc/onboard_usb_hub.h | 16 ++++++++++++---- > 2 files changed, 40 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c > index 6b9b949d17d3..2aa1db528b31 100644 > --- a/drivers/usb/misc/onboard_usb_hub.c > +++ b/drivers/usb/misc/onboard_usb_hub.c > @@ -7,6 +7,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -38,6 +39,8 @@ struct usbdev_node { > struct onboard_hub { > struct regulator *vdd; > struct device *dev; > + const struct onboard_hub_pdata *pdata; > + struct gpio_desc *reset_gpio; > bool always_powered_in_suspend; > bool is_powered_on; > bool going_away; > @@ -56,6 +59,9 @@ static int onboard_hub_power_on(struct onboard_hub *hub) > return err; > } > > + fsleep(hub->pdata->reset_us); > + gpiod_set_value_cansleep(hub->reset_gpio, 0); > + > hub->is_powered_on = true; > > return 0; > @@ -65,6 +71,11 @@ static int onboard_hub_power_off(struct onboard_hub *hub) > { > int err; > > + if (hub->reset_gpio) { > + gpiod_set_value_cansleep(hub->reset_gpio, 1); > + fsleep(hub->pdata->reset_us); Is this delay here actually needed? There is a delay in onboard_hub_power_on(), before de-asserting the reset, isn't that enough? > + } > + > err = regulator_disable(hub->vdd); > if (err) { > dev_err(hub->dev, "failed to disable regulator: %d\n", err); > @@ -219,6 +230,7 @@ static void onboard_hub_attach_usb_driver(struct work_struct *work) > > static int onboard_hub_probe(struct platform_device *pdev) > { > + const struct of_device_id *of_id; > struct device *dev = &pdev->dev; > struct onboard_hub *hub; > int err; > @@ -227,10 +239,26 @@ static int onboard_hub_probe(struct platform_device *pdev) > if (!hub) > return -ENOMEM; > > + of_id = of_match_device(onboard_hub_match, &pdev->dev); > + if (!of_id) > + return -ENODEV; > + > + hub->pdata = of_id->data; > + if (!hub->pdata) > + return -EINVAL; > + > hub->vdd = devm_regulator_get(dev, "vdd"); > if (IS_ERR(hub->vdd)) > return PTR_ERR(hub->vdd); > > + hub->reset_gpio = devm_gpiod_get_optional(dev, "reset", > + GPIOD_OUT_HIGH); > + if (IS_ERR(hub->reset_gpio)) > + return dev_err_probe(dev, PTR_ERR(hub->reset_gpio), "failed to get reset GPIO\n"); > + > + if (hub->reset_gpio) > + fsleep(hub->pdata->reset_us); Same question here: onboard_hub_power_on() is called a few lines below and has a delay before de-asserting the reset. Is the delay here really needed?